[ET Trac] [Einstein Toolkit] #702: Tests should use IO::out_fileinfo = "none"
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Sun Apr 17 05:09:41 CDT 2016
#702: Tests should use IO::out_fileinfo = "none"
--------------------------+-------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: reviewed_ok
Priority: minor | Milestone:
Component: Other | Version:
Resolution: | Keywords:
--------------------------+-------------------------------------------------
Comment (by rhaas):
Replying to [comment:4 hinder]:
> Replying to [comment:1 eschnett]:
> > Please go ahead. Ideally, you would generate the new test case output
by removing lines from the old output, but that may be too much to ask
for.
>
> Since the changes should be invisible to the Cactus test mechanism, it
should be enough to rerun the tests with the new output, verify that they
still pass, then commit the new data. We can then use version-control
tools to examine the diff, which should consist only of these header
lines.
I would actually be very surprised if the differences were only the header
lines. Some of those test files were generated years ago with a compiler
and options that are no longer in use. I would very much expect that
regenerating the data would change the data in the files (this already
happens when comparing intel and gcc compiler results).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/702#comment:6>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list