[ET Trac] [Einstein Toolkit] #1875: SetMask_SphericalSurface: retain mask

[Einstein Toolkit]

#1875: SetMask_SphericalSurface: retain mask
-------------------------------------+--------------------------------------
  Reporter:  cott@…                  |       Owner:                     
      Type:  enhancement             |      Status:  review             
  Priority:  unset                   |   Milestone:                     
 Component:  Other                   |     Version:  development version
Resolution:                          |    Keywords:                     
-------------------------------------+--------------------------------------

Comment (by rhaas):

 I added a handful of comments to the pull request
 (https://bitbucket.org/einsteintoolkit/einsteinutils/pull-requests/1
 /setmask_sphericalsurface-retain-mask/diff), nothing major. I would like
 to make sure that math.h does not need to be included.

 The patch changes {{{setmask_sphericalsurface}}}'s from one extreme to the
 other: rather than always expecting the horizon to be found, it will use
 possibly old horizon data forever. This is probably fine until the horizon
 moves and some regions of the actual horizon are no longer in the mask, at
 which point it will likely fail in con2prim in GRhydro just as the old
 code did. A dangerous situation could arise when the horizon actually
 shrinks without moving so that more and more of the outside of the horizon
 is flagged as being inside.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1875#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit