[ET Trac] [Einstein Toolkit] #1986: this compared to NULL in CarpetLib

Einstein Toolkit trac-noreply at einsteintoolkit.org
Wed Nov 23 12:42:22 CST 2016


#1986: this compared to NULL in CarpetLib
---------------------+------------------------------------------------------
  Reporter:  rhaas   |       Owner:  eschnett           
      Type:  defect  |      Status:  review             
  Priority:  minor   |   Milestone:                     
 Component:  Carpet  |     Version:  development version
Resolution:          |    Keywords:                     
---------------------+------------------------------------------------------

Comment (by rhaas):

 That will take care of the NULL this I guess as long as srcs is never
 empty (in which case I'd expect AT to assert() or if not we'll have
 undefined behaviour since the pointer src [while presumably not "really"
 used], is not a pointer to a gdata object).

 I am not sure how much can be reviewed in this. If this patch works for
 the test cases then "Please apply". Should we include the patch in the
 test suites on at least some machines?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1986#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list