[ET Trac] [Einstein Toolkit] #1971: GRHydro: comment fprintf if eps<0, and explicitly instantiate templates
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Wed Oct 5 11:07:56 CDT 2016
#1971: GRHydro: comment fprintf if eps<0, and explicitly instantiate templates
-----------------------------------+----------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2016_11
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
The output for eps<0 is done using fprintf, which is bad anyway, and can
potentially lead to problems with large output files - not to mention how
to deal with this in a multi-process MPI run. This only disables the crude
output. It does not change the behaviour of the code itself.
Instantiation of all three versions is needed in any case, and making this
explicit potentially reduces copies of the same code used in different
files.
These two changes are implemented the pull request
https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-
requests/8/parma/diff
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1971>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list