[ET Trac] [Einstein Toolkit] #1958: parfiles accept 1.0, 0.0, 1e3 for integer typed parameters

Einstein Toolkit trac-noreply at einsteintoolkit.org
Thu Oct 20 11:34:24 CDT 2016


#1958: parfiles accept 1.0, 0.0, 1e3 for integer typed parameters
-----------------------+----------------------------------------------------
  Reporter:  rhaas     |       Owner:                     
      Type:  defect    |      Status:  new                
  Priority:  optional  |   Milestone:  ET_2016_11         
 Component:  Cactus    |     Version:  development version
Resolution:            |    Keywords:                     
-----------------------+----------------------------------------------------

Comment (by rhaas):

 Sorry, this all seems to have gotten a bit out of hand to me.

 I think that we really cannot change (again) how the parfiles act since we
 have to remain backwards compatible with old parfiles. Ideally this should
 have been the original parfile parser, yet when we introduced piraha we
 changed what parfiles are acceptable (specifically we disallowed some that
 were acceptable before). We should not be changing this yet again. In this
 light even my request to disallow "1.0" for an int is questionable since
 apparently even having this abilityaround for a single release had
 parameter files using it crop up in our test suites (though this may
 actually have been a change in type of the parameters in McLachlan from
 real to int due to the rewrite branch).

 Rather than extend the discussion even further, I'd like to suggest to
 leave it as it was in the last release. Would this be with all involved?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1958#comment:23>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list