[ET Trac] [Einstein Toolkit] #2034: CarpetLib's defs.hh and defs.cc file don't encapsulate defintions in a namespace

[Einstein Toolkit]

#2034: CarpetLib's defs.hh and defs.cc file don't encapsulate defintions in a
namespace
--------------------+-------------------------------------------------------
 Reporter:  rhaas   |       Owner:  eschnett           
     Type:  defect  |      Status:  new                
 Priority:  minor   |   Milestone:                     
Component:  Carpet  |     Version:  development version
 Keywords:          |  
--------------------+-------------------------------------------------------
 CarpetLib's defs.hh and defs.cc do not (as far as I can tell) contain any
 namespace enclosing the defined functions so that they all end up in the
 global namespace eg its ipow and also its get_poison_value function. It
 should however either put them into a CarpetLib namespace or prefix them
 by CarpetLib_ like other symbols with global linkage.

 This apparently has always been the case at least far back as importing
 carpet-5 into git (5 years ago).

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2034>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit