[ET Trac] [Einstein Toolkit] #2068: Support KNL's AVX512 instruction set

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Aug 22 12:46:56 CDT 2017


#2068: Support KNL's AVX512 instruction set
--------------------------+-------------------------------------------------
  Reporter:  eschnett     |       Owner:                     
      Type:  enhancement  |      Status:  review             
  Priority:  major        |   Milestone:                     
 Component:  Cactus       |     Version:  development version
Resolution:               |    Keywords:                     
--------------------------+-------------------------------------------------

Comment (by rhaas):

 Alright, this worked without problems, not sure what I had tried to do
 before. The only downside is that the comments do not show up in the pull
 request diff but only in the individual commits, so here's links to them:

 *
 https://bitbucket.org/cactuscode/cactusutils/commits/624ecd2afa085fad9794e42905f87233527c121e?at=master
 *
 https://bitbucket.org/cactuscode/cactusutils/commits/555cfe712f869ba45da200e1bdde52e8cf39fb9a?at=master

 Looks fine in general. Usual disclaimers apply: these comments are all
 very terse and just comments that came to my mind when reading the code,
 not intended to be very well worded or final requests.

 Two more comments:

 * does the final version of the commits still pass through clang-format
 unchanged?
 * I don't know what was done in thorn Vectors (compared to vecmathlib)
 before: are approximated answers used or was there a promise that (as much
 as possible) results that simple use vectorization to do the same thing to
 multiple grid points and doing the same thing to multiple grid points
 using a loop return the same result (ignoring fma and the like).

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2068#comment:7>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list