[ET Trac] [Einstein Toolkit] #2060: Parallel checkout fails on systems with threading missing from the perl installation
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Thu Aug 24 12:17:01 CDT 2017
#2060: Parallel checkout fails on systems with threading missing from the perl
installation
----------------------------+-----------------------------------------------
Reporter: diener | Owner:
Type: defect | Status: review
Priority: minor | Milestone:
Component: GetComponents | Version: development version
Resolution: | Keywords: newuser
----------------------------+-----------------------------------------------
Changes (by rhaas):
* status: new => review
Comment:
I am very confused as to why setting $PARALLEL=1 helped. The code *only*
enters the block that contains line 1025 *if* $PARALLEL==1. So the actual
bug seems to be to blindly trust the user when --parallel is given and
setting $PARALLEL=1. Instead I suggest to add a second variable
$HAVE_PARALLEL that is only set to 1 if the test for the "threads" package
around line 48 succeeds.
To answer sbrandt's question: teh line was commented out when it was
decided to not make --parallel the default behaviour of GetComponents.
This pull request:
https://github.com/gridaphobe/CRL/pull/5
should fix this.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2060#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list