[ET Trac] [Einstein Toolkit] #2090: GetComponents should not prompt in a Jupyter notebook

Einstein Toolkit trac-noreply at einsteintoolkit.org
Thu Dec 7 11:45:32 CST 2017


#2090: GetComponents should not prompt in a Jupyter notebook
----------------------------+-----------------------------------------------
  Reporter:  sbrandt        |       Owner:                     
      Type:  defect         |      Status:  reviewed_ok        
  Priority:  unset          |   Milestone:                     
 Component:  GetComponents  |     Version:  development version
Resolution:                 |    Keywords:                     
----------------------------+-----------------------------------------------
Changes (by rhaas):

  * status:  review => reviewed_ok


Comment:

 Looks like a hack. Ideally one would not want to tie this to just jupyter
 yet it seems impossible to find out if the user could actually respond
 since jupyter insists on creating a tty (and then does not properly
 support it since once cannot read from stdin :-( ).

 There is a second change in there that now uses {{{$answer}}} instead of
 "no" in the default shown to the user. This involves no functional change
 since {{{$answer}}} has already been initialized to "no" at this point and
 is actually an improvement since it shows the actual default that will be
 used and not what the author of the code thinks that default was.

 So ok to apply to *master only*, please make this two commits, one for the
 {{{$answer}}} change, one for the jupyter support.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2090#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list