[ET Trac] [Einstein Toolkit] #1939: Cactus: Add CCTK_VINFO, CCTK_VERROR, CCTK_VWARN
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Mon Feb 6 12:37:22 CST 2017
#1939: Cactus: Add CCTK_VINFO, CCTK_VERROR, CCTK_VWARN
--------------------------+-------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: enhancement | Status: review
Priority: unset | Milestone:
Component: Cactus | Version: development version
Resolution: | Keywords:
--------------------------+-------------------------------------------------
Comment (by knarf):
Some points:
- I don't link other changes in the same diff. It's ok for now, but please
don't mix changes even if it just changes upper case / lower case of
something unrelated
- If I read the changes to the documentation correctly, places with, e.g.,
CCTK_VInfo are replaced by CCTK_VINFO. Isn't CCTK_VInfo still there,
usable, and should stay mentioned, like in "Note that the routines
\texttt{CCTK\_VError()} and \texttt{CCTK\_VWarn()} can only be called from
C"
- Seeing the diff of the pdf in github mixed with the other changes is
annoying. I know this decision was made to keep the diffs to the pdfs
small, but it is really annoying here.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1939#comment:5>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list