[ET Trac] [Einstein Toolkit] #1916: GetComponents checks out git repositories serially

Einstein Toolkit trac-noreply at einsteintoolkit.org
Sun Feb 12 16:30:56 CST 2017


#1916: GetComponents checks out git repositories serially
----------------------------+-----------------------------------------------
  Reporter:  hinder         |       Owner:                     
      Type:  defect         |      Status:  confirmed          
  Priority:  major          |   Milestone:                     
 Component:  GetComponents  |     Version:  development version
Resolution:                 |    Keywords:                     
----------------------------+-----------------------------------------------

Comment (by rhaas):

 I suspect that this is actually due to
 6dc98e842bad513ddbc5724ebb4f521823574020 in #1395. If you follow the code
 then you can see that there is one call to checkout per TARGET instruction
 the CRL file. However the checkout subroutine serializes the first
 checkout of each call and since for git there is often one git repo per
 TARGET (since the url is unique) this means that effectively all git repos
 are checked out serially.

 A full fix would be to track dependencies between checkouts (ie which
 combination of TARGET/CHECKOUT is contained in other TARGET/CHECKOUTs) and
 wait for dependencies to be satisfied before continuing.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1916#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list