[ET Trac] [Einstein Toolkit] #1819: CarpetMask: add option to exclude boxes

Einstein Toolkit trac-noreply at einsteintoolkit.org
Mon Jan 16 10:11:35 CST 2017


#1819: CarpetMask: add option to exclude boxes
--------------------------+-------------------------------------------------
  Reporter:  bmundim      |       Owner:  eschnett               
      Type:  enhancement  |      Status:  reopened               
  Priority:  unset        |   Milestone:                         
 Component:  Carpet       |     Version:  development version    
Resolution:               |    Keywords:  CarpetMask CarpetReduce
--------------------------+-------------------------------------------------
Changes (by rhaas):

  * status:  reviewed_ok => reopened


Comment:

 Bruno: unfortunately the tests fail on my laptop. Unless they are fixed
 the patch cannot be applied. I tried this with your branch from you
 bitbucket repo as well as with a branch that I rebased onto master
 (rhaas/carpetmask in the main repo).

 I get differences like this:
 {{{#!diff
 diff -rw --from repos/carpet/CarpetMask/test
 repos/carpet/CarpetMask/test/test_mask_exclude_boxes/weight.x.asc
 TEST/sim/CarpetMask/test_mask_exclude_boxes/weight.x.asc
 37c37
 < 0     0       0 0 0   34 22 22        0       0.6 0 0 0
 ---
 > 0     0       0 0 0   34 22 22        0       0.6 0 0 1
 84c84
 < 1     0       0 0 0   34 22 22        1       0.6 0 0 0
 ---
 > 1     0       0 0 0   34 22 22        1       0.6 0 0 1
 131c131
 < 2     0       0 0 0   34 22 22        2       0.6 0 0 0
 ---
 > 2     0       0 0 0   34 22 22        2       0.6 0 0 1
 diff -rw --from repos/carpet/CarpetMask/test
 repos/carpet/CarpetMask/test/test_mask_exclude_boxes_exterior/weight.x.asc
 TEST/sim/CarpetMask/test_mask_exclude_boxes_exterior/weight.x.asc
 37c37
 < 0     0       0 0 0   34 22 22        0       0.6 0 0 0
 ---
 > 0     0       0 0 0   34 22 22        0       0.6 0 0 1
 84c84
 < 1     0       0 0 0   34 22 22        1       0.6 0 0 0
 ---
 > 1     0       0 0 0   34 22 22        1       0.6 0 0 1
 131c131
 < 2     0       0 0 0   34 22 22        2       0.6 0 0 0
 ---
 > 2     0       0 0 0   34 22 22        2       0.6 0 0 1
 }}}

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1819#comment:7>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list