[ET Trac] [Einstein Toolkit] #2039: Meudon_Bin_NS update

[Einstein Toolkit]

#2039: Meudon_Bin_NS update
------------------------------------+---------------------------------------
  Reporter:  knarf                  |       Owner:                     
      Type:  enhancement            |      Status:  reopened           
  Priority:  minor                  |   Milestone:                     
 Component:  EinsteinToolkit thorn  |     Version:  development version
Resolution:                         |    Keywords:  parma              
------------------------------------+---------------------------------------

Comment (by knarf):

 You are right about the file existence check. I removed the new one, as
 the older covers more cases and includes the new check.

 > Does that always work (and gives the very same results as before for the
 same correct set of parameter values)? I thought that before eg for a
 polytropic EOS it would pass havetemp=1 even though there was not storage
 for temperature?

 The thorn includes a new paramter recalculate_eps, which by default is 1.
 This will recalculate eps by passing '1' as keytemp to the EOS routines.
 If the EOS values are consistent, this should give the same results as if
 taken from Lorene directly. Calling the EOS routines makes sure that the
 hydro variables are consistent at least with respect to the evolution EOS.

 If you set the parameter to 0, eps will be used from Lorene, and '0' will
 be passed as keytemp to the EOS routines, causing them to not overwrite
 eps.

 Before this change, the EOS routines were not called at all, a polytrope
 was hard-coded, and eps taken from Lorene.
 In this sense, there is a change in the behavior when using a polytrope
 and for some reason eps from Lorene isn't the same as eps using the EOS
 routines. This should only make sense if you want to perturb the stars,
 which really doesn't make a lot of sense for Lorene Bin_NS data I would
 think. Even if you'd want that, this should be done in other ways than
 like this.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2039#comment:13>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit