[ET Trac] [Einstein Toolkit] #2013: piraha breaks ThornDoc building

Einstein Toolkit trac-noreply at einsteintoolkit.org
Wed Mar 1 11:39:27 CST 2017


#2013: piraha breaks ThornDoc building
---------------------+------------------------------------------------------
  Reporter:  rhaas   |       Owner:  brandt             
      Type:  defect  |      Status:  review             
  Priority:  major   |   Milestone:                     
 Component:  Cactus  |     Version:  development version
Resolution:          |    Keywords:                     
---------------------+------------------------------------------------------

Comment (by rhaas):

 My feeling would be that the modules (ie the parsers) should encapsulate
 information that CST or their other callers do not need to know about
 (such as whether Piraha or another parser is used) and that as little
 information as possible should be passed from callers to the modules using
 global variables. So with that in mind I would move both the {{{require
 "$main::sbin_dir/Piraha.pm";}}} and the code that computes sbin_dir to the
 parser packages or (alternatively and probably better) have main adjust
 the perl search path to include the Cactus perl module directory where
 Piraha lives.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2013#comment:8>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list