[ET Trac] [Einstein Toolkit] #2040: EOS_Omni: piecewise polytrope support with up to 10 pieces
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Wed May 24 08:04:43 CDT 2017
#2040: EOS_Omni: piecewise polytrope support with up to 10 pieces
------------------------------------+---------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: reopened
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Resolution: | Keywords: parma
------------------------------------+---------------------------------------
Changes (by rhaas):
* status: review => reopened
Comment:
Comments are in the pull request. Basically: the code is fine, the physics
as well (I had tested against another code and re-derived most of the
expressions).
I am not sure if it should go in right away as it is unclear how much of a
speed impact (for example) the loops over pieces have and *also* for the
fact that this is a backwards incompatible change very shortly before the
release. It does seem to introduce a handful of changes of behaviour which
should not go into the ET without testing first.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2040#comment:4>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list