[ET Trac] [Einstein Toolkit] #2087: Scheduling of GRHydro_SqrtSpatialDeterminant.
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Mon Nov 20 13:58:43 CST 2017
#2087: Scheduling of GRHydro_SqrtSpatialDeterminant.
------------------------------------+---------------------------------------
Reporter: bentivegna | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Resolution: | Keywords:
------------------------------------+---------------------------------------
Comment (by rhaas):
The logic is flawed :-). Just because both GRHydro_SqrtSpatialDeterminant
and ADMBase_PostInitial are scheduled to run before
HydroBase_Prim2ConInitial, no ordering is yet imposed between
GRHydro_SqrtSpatialDeterminant and ADMBase_PostInitial. Your updated patch
does impose a correct ordering though.
I think my original comment was based on not knowing on top of my head
whether HydroBase_Prim2ConInitial was scheduled to run after
ADMBase_PostInitial or not.
Your patch looks fine to me. Please apply (do you have commit rights?).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2087#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list