[ET Trac] [Einstein Toolkit] #2211: gh::regrid contains code whose runtime is quadratic in number of components

Einstein Toolkit trac-noreply at einsteintoolkit.org
Thu Dec 6 12:41:40 CST 2018


#2211: gh::regrid contains code whose runtime is quadratic in number of components
--------------------------+---------------------------------
  Reporter:  Roland Haas  |      Owner:  (none)
      Type:  defect       |     Status:  new
  Priority:  minor        |  Milestone:
 Component:  Carpet       |    Version:  development version
Resolution:               |   Keywords:
--------------------------+---------------------------------

Comment (by Roland Haas):

 My branch isn't really changes that should be applied (since it hacks
 Carpet and adds a testing thorn).

 The possibly applicable changes are surrounding the consistency checks in
 gh::regrid with a
 {{{
 #ifndef CARPET_OPTIMiSE
 ...
 #endif
 }}}
 and the same for the consistency checks in dh::regrid (the part timed by
 the "tests" timer).

 Erik's suggestion is basically to surround the gh::regrid stuff with
 {{{
 #ifdef CARPET_DEBUG
 }}}
 which makes disables the tests unless explicitly asked for while my
 suggestion would have left them in unless explicitly disabled. The ones in
 dh::regrid are already (mostly) no-ops for CARPET_OPTIMISE since the
 ASSERT_XXX macros become no-ops in that case.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2211#comment:6>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list