[ET Trac] #2485: include complex and real scalar evolution code from Canuda in ET

[Miguel Zilhão]

#2485: include complex and real scalar evolution code from Canuda in ET

 Reporter: Roland Haas
   Status: open
Milestone: 
  Version: 
     Type: task
 Priority: major
Component: 

Comment (by Miguel Zilhão):

> ‌    In ScalarEvolve, why BSSN-like variables are public ? Since same name variables are used in other thorn \(like lean\_public\) and they are just auxiliary field to calculate rhs of the equations, private is better for them.

fixed in https://bitbucket.org/canuda/scalar/commits/98828a12f314e91e3af135a4f4b58743d47a32fc

> ‌    In Scalar\_calc\_Tmunu.F90, in Scalar\_calc\_Tmunu, xx and rr should be private in OpenMP in grid loop.

fixed in https://bitbucket.org/canuda/scalar/commits/44027452fc248b00e2e99b31d42cb23215c2aad1

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2485/include-complex-and-real-scalar-evolution
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20220818/143f9bda/attachment.html