[ET Trac] #2653: Carpet PreSync triggering syncs for all refinement levels unnecessarily

[Samuel Cupp]

#2653: Carpet PreSync triggering syncs for all refinement levels unnecessarily

 Reporter: Samuel Cupp
   Status: new
Milestone: 
  Version: 
     Type: bug
 Priority: major
Component: Carpet

Comment (by Samuel Cupp):

I haven’t yet run a simulation with a lot of reflevels, but I verified that this code doesn’t call `SyncProlongateGroups` except for the current reflevel when coarser levels don’t need to be synced. Thus, it is equivalent to commenting out the loop. The only added time will be from looping over the groups and comparing ints at each reflevel, which should be negligible. I’ll run the BaikalVacuum with this and check performance.

Since I don’t have a code where the coarser levels aren’t synced before getting to the finer level, I can’t do a ‘real’ test of the case where this loop is actually necessary. I’m still not convinced that’s something that can happen without a thorn having incorrect reads/writes.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2653/carpet-presync-triggering-syncs-for-all
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20221005/7769d060/attachment-0001.html