[ET Trac] #2647: incorrect WENO coefficient in GRHydro WENO reconstruction code

[Roland Haas]

#2647: incorrect WENO coefficient in GRHydro WENO reconstruction code

 Reporter: Roland Haas
   Status: new
Milestone: 
  Version: 
     Type: bug
 Priority: major
Component: EinsteinToolkit thorn

The GRHydro WENO reconstruction code selected by `GRHydro::recon_method = "weno"` employs incorrect values for the `weno_coeffs` array that is constructed from the WENO $omega\_r$ values. 

The current values are in fact WENO interpolation instead of WENO reconstruction.

Pull request

[https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-requests/17/rhaas-wenocoeffsfix](https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-requests/17/rhaas-wenocoeffsfix)

corrects the coefficients, re-computing them from the original publication used to implement the code \(“WHAM paper”, [https://arxiv.org/abs/0704.2608](https://arxiv.org/abs/0704.2608)\) and updates the test data as well.

The attached stand-alone test \(extracted code from GRHydro\) demonstrates the issue and shows that only WENO-Z and WHAM’s WENO do show the WENO property of exactly reconstructing smooth data of low order polynomials \(2nd order in the test, but should be up to 5th order\). It also shows that WENO as implemented by GRHydro is actually WENO interpolation.

This effectively reduces WENO to a 2nd order accurate scheme similar to a basic tvd scheme I would guess.
attachment: weno.cc (https://api.bitbucket.org/2.0/repositories/einsteintoolkit/tickets/issues/2647/attachments/weno.cc)


--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2647/incorrect-weno-coefficient-in-grhydro-weno
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20220927/e1a126e2/attachment.html