[ET Trac] #2619: include Ellipitca (reader) in Einstein Toolkit

[Roland Haas]

#2619: include Ellipitca (reader) in Einstein Toolkit

 Reporter: Roland Haas
   Status: open
Milestone: 
  Version: 
     Type: enhancement
 Priority: major
Component: 

Comment (by Roland Haas):

Looking at thornlist fragment included in in manifest:

```
# Elliptic ID reader
!TARGET   = $ARR
!TYPE     = git
!URL      = https://github.com/aup1075/EllipticaID.git
!REPO_BRANCH = BHNS_reader
!REPO_PATH = $2
!CHECKOUT =
EllipticaID/Elliptica_BHNS

# required lib for Elliptica BHNS ID reader
!TARGET   = $ARR
!TYPE     = git
!URL      = https://github.com/rashti-alireza/Elliptica_ID_Reader.git
!REPO_BRANCH = Cactus
!REPO_PATH = ../$2
!CHECKOUT =
ExternalLibraries/Elliptica_ID_Reader
```

then both use a non-default branch \(not just not named “master” but actually not the default branch\). This is ok as long as those branches are \(in the “master” branch manifest\) are the ones that will continue to be the ones that releases will be spun off from and are the ones that are actually used by the authors. That is they should not be branches created _solely_ for this ticket. 

`https://github.com/rashti-alireza/Elliptica_ID_Reader.git` seems to be ok in that respect since it is the branch containing the Cactus ExternalLibrary like thorn and includes a tar file of the source \(though it could have also been included in a subdirectory of the main branch \[and include its own tar-file there\] in the way RePrimAnd does\).

However [https://github.com/aup1075/EllipticaID/tree/BHNS\_reader](https://github.com/aup1075/EllipticaID/tree/BHNS_reader) has what looks like the same `Elliptica_BHNS` thorn also available in `main`. If the copy of the thorn is `BHNS_reader` is just a copy of the one in `main` then it would be preferable to track `main` where presumably the actual updates will happen. In particular in anticipation of a future inclusion of other types of readers. There is no harm in having extra thorns \(or other code\) in the repo and branch that is used with Cactus. The extra ones are just ignored as long as they are not actually listed in the thornlist \(and are not subject to review\).  
The added simplicity of not having to maintain multiple branches that need to be kept up to date with bugfixes and \(possibly\) improvements may well be worth the larger size on disk when checking out the repo.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca-reader-in-einstein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20230406/dd2b5a69/attachment.html