From trac-noreply at einsteintoolkit.org Wed Aug 2 12:17:27 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Wed, 02 Aug 2023 17:17:27 +0000 Subject: [ET Trac] #2744: Cactus: New cGH entries `cctk_level`, `cctk_block` Message-ID: #2744: Cactus: New cGH entries `cctk_level`, `cctk_block` Reporter: Erik Schnetter Status: new Milestone: Version: Type: enhancement Priority: major Component: Cactus Comment (by Erik Schnetter): Merged. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2744/cactus-new-cgh-entries-cctk_level -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Aug 2 12:17:36 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Wed, 02 Aug 2023 17:17:36 +0000 Subject: [ET Trac] #2744: Cactus: New cGH entries `cctk_level`, `cctk_block` Message-ID: #2744: Cactus: New cGH entries `cctk_level`, `cctk_block` Reporter: Erik Schnetter Status: resolved Milestone: Version: Type: enhancement Priority: major Component: Cactus Changes (by Erik Schnetter): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2744/cactus-new-cgh-entries-cctk_level -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:10:46 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:10:46 +0000 Subject: [ET Trac] #2745: Inclusion of GRHayL library and associated MHD thorns Message-ID: #2745: Inclusion of GRHayL library and associated MHD thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn The General Relativistic Hydrodynamics Library \(GRHayL\) provides core functionality for IllinoisGRMHD-like codes in an infrastructure-agnostic form. The _GRHayLib_ thorn sets up the core library in the Cactus Framework. Included in this update is the change to _IllinoisGRMHD_ to use this new library, which also includes many improvements, simplifications, and other enhancements. Additionally, we provide the _GRHayLHD_ thorn for purely hydrodynamic simulations which has noticeable speed improvements over the MHD code. For CarpetX, we provide _IllinoisGRMHDX_ and _GRHayLHDX_. To help with testing and future work, we also provide _GRHayLID_ and _GRHayLIDX_, which set up simple MHD data for _HydroBase_ \(e.g. the Balsara tests\). Note that since _GRHayLib_ only provides the library, one can use _GRHayLib_/_GRHayLID_ to set up initial data and then use an _EOS\_Omni_- or _EOSX_-based evolution thorn with no issues. Part of the simplifications to _IllinoisGRMHD_ make the _ID\_converter\_ILGRMHD_ and _Convert\_to\_HydroBase_ thorns obsolete, and they are deprecated in this release. Special deprecation code is scheduled to ensure the core behavior is maintained till the next release cycle which checks the parameters of these auxiliary thorns. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2745/inclusion-of-grhayl-library-and-associated -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:11:17 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:11:17 +0000 Subject: [ET Trac] #2745: Inclusion of GRHayL library and associated MHD thorns Message-ID: #2745: Inclusion of GRHayL library and associated MHD thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{557058:f7fd5133-6eee-4385-a5e5-3e03342a0b24} is the reviewer -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2745/inclusion-of-grhayl-library-and-associated -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:12:58 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:12:58 +0000 Subject: [ET Trac] #2694: include CarpetX prerelease in Einstein Toolkit Message-ID: #2694: include CarpetX prerelease in Einstein Toolkit Reporter: Roland Haas Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Changes (by Samuel Cupp): milestone: ET_2023_11 (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2694/include-carpetx-prerelease-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:14:18 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:14:18 +0000 Subject: [ET Trac] #2694: include CarpetX prerelease in Einstein Toolkit Message-ID: #2694: include CarpetX prerelease in Einstein Toolkit Reporter: Roland Haas Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): CarpetX and the associated thorns are proposed to be included in the ET\_2023\_11 release. Can I get a full list of the thorns that are in this proposal? @{557058:56049c54-f8c2-4b6c-9b88-ab697c967495} @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} @{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2694/include-carpetx-prerelease-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:16:31 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:16:31 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Changes (by Samuel Cupp): milestone: ET_2023_11 (was ) title: Inclusion of AsterX in the Einstein Toolkit (was Inclusion of AsterX pre-release in the Einstein Toolkit) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:18:09 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:18:09 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{5accca1cc8c4282b41e130e4} Can I get a list of what thorns are being included in this proposal from the AsterX repo? Also, please @ anyone else that should be involved in this discussion. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:18:37 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:18:37 +0000 Subject: [ET Trac] #2694: include CarpetX in Einstein Toolkit Message-ID: #2694: include CarpetX in Einstein Toolkit Reporter: Roland Haas Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Changes (by Samuel Cupp): title: include CarpetX in Einstein Toolkit (was include CarpetX prerelease in Einstein Toolkit) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2694/include-carpetx-in-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:23:32 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:23:32 +0000 Subject: [ET Trac] #2746: Make Seed_Magnetic_Fields independent of IllinoisGRMHD Message-ID: #2746: Make Seed_Magnetic_Fields independent of IllinoisGRMHD Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn _Seed\_Magnetic\_Fields_ schedules its functions with respect to _IllinoisGRMHD_, which is an unnecessary dependency since this thorn only depends on HydroBase. Changing this scheduling would allow for other thorns to use it, as currently its scheduling would be very unpredictable without _IllinoisGRMHD_ scheduled. Additionally, this update merges the features of _wvuthorns\_diagnostics_/_Seed\_Magnetic\_Fields\_BNS_ into this thorn. The BNS variant thorn will be deprecated to be removed in the ET\_2024\_05 release. There is no need for separate thorns, and this merge serves to unify their scheduling and general behavior, since they currently do not behave in the same way and would likely confuse those attempting to use them with a thorn other than _IllinoisGRMHD_. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2746/make-seed_magnetic_fields-independent-of -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:24:11 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:24:11 +0000 Subject: [ET Trac] #2746: Make Seed_Magnetic_Fields independent of IllinoisGRMHD Message-ID: #2746: Make Seed_Magnetic_Fields independent of IllinoisGRMHD Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{557058:8bc23f2a-45c0-477d-8ac4-a5a16c734278} is the reviewer for this update, to be included in the ET\_2023\_11 release. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2746/make-seed_magnetic_fields-independent-of -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:35:19 2023 From: trac-noreply at einsteintoolkit.org (Jay Kalinani) Date: Mon, 07 Aug 2023 20:35:19 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Jay Kalinani): @{557058:088051f9-5b94-4b5e-bfbe-71137030b9c1} Here are the list of thorns to be included from the AsterX repo \(given that CarpetX is included as well\): - AsterX - AsterSeeds - Con2PrimFactory - EOSX - ReconX - TOVSolver Note that we still need reviewers for these thorns, and we are currently working on the first AsterX paper. ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:41:54 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:41:54 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Samuel Cupp): _TOVSolver_ can?t be named _TOVSolver_, as that is already a thorn. It would either need to be e.g. _TOVSolverX_ or somehow have its changed merged into the original thorn. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:44:16 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 20:44:16 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Also, don?t forget that several thorns have unneeded dependencies \(e.g. TOVSolver depending on AsterX\) that should be removed. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 15:46:12 2023 From: trac-noreply at einsteintoolkit.org (Jay Kalinani) Date: Mon, 07 Aug 2023 20:46:12 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Jay Kalinani): Points well noted! Will certainly incorporate the suggested changes. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 16:19:12 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 07 Aug 2023 21:19:12 +0000 Subject: [ET Trac] #2308: SummationByParts: Use centred stencils on multipatch symmetry boundaries Message-ID: #2308: SummationByParts: Use centred stencils on multipatch symmetry boundaries Reporter: Roland Haas Status: open Milestone: Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Roland Haas): @{557058:ae98ab72-3754-49e1-9230-5c814d4c790b} is this still relevant? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2308/summationbyparts-use-centred-stencils-on -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 16:59:37 2023 From: trac-noreply at einsteintoolkit.org (Zach Etienne) Date: Mon, 07 Aug 2023 21:59:37 +0000 Subject: [ET Trac] #2706: Update default TwoPunctures parameters, or at least default parameters in BBH gallery example Message-ID: #2706: Update default TwoPunctures parameters, or at least default parameters in BBH gallery example Reporter: Roland Haas Status: new Milestone: Version: Type: enhancement Priority: minor Component: EinsteinToolkit website Changes (by Zach Etienne): title: Update default TwoPunctures parameters, or at least default parameters in BBH gallery example (was increase TwoPunctures resolution in BBH gallery example) Comment (by Zach Etienne): There are two major improvements I would recommend. The first is for TwoPunctures, and the second for the BBH gallery example: 1. For most binary black hole simulations, the early evolution constraint violations are dominated by the initial data, when using the default TwoPunctures grid resolution of 30x30x16. I strongly recommend increasing the default resolution to at least 48x48x20. 2. The BBH gallery example has a rather unusual choice of initial lapse, setting it to the average value of 1 - m\_i / \(2r\_i\) for both punctures i. More typically the initial lapse is set to the ?pre-collapsed? value of psi^\{-2\} which goes like 1 - M/r at large radii for total binary mass M. This is the same asymptotic behavior that the will lapse relax to, and so this choice results in less gauge dynamics than the ?averaged lapse? value. TwoPunctures supports `initial_lapse = "psi^n"` and chooses a perfectly fine default value of `n=initial_lapse_psi_exponent=-2` . Note that the BBH gallery example is negatively impacted by \(1\) as well. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2706/update-default-twopunctures-parameters-or -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 17:02:53 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 22:02:53 +0000 Subject: [ET Trac] #2745: Inclusion of GRHayL library and associated MHD thorns Message-ID: #2745: Inclusion of GRHayL library and associated MHD thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): To check out the Carpet-based thorns, simply add ``` !TARGET = $ARR !TYPE = git !URL = https://github.com/GRHayL/GRHayL.git !REPO_BRANCH = main !REPO_PATH= implementations/$2 !CHECKOUT = GRHayL/GRHayLib !TARGET = $ARR !TYPE = git !URL = https://github.com/GRHayL/GRHayLET.git !REPO_BRANCH = main !REPO_PATH= $2 !CHECKOUT = GRHayLET/GRHayLHD GRHayLET/GRHayLMHD #GRHayLET/IllinoisGRMHD GRHayLET/GRHayLID ``` Note that `GRHayLMHD` is the current name of `IllinoisGRMHD` on the main branch, as I am still comparing with `IllinoisGRMHD` and wanted to compile them together. In the release, it will be `IllinoisGRMHD`, and the thorn in the WVUThorns arrangement will be removed. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2745/inclusion-of-grhayl-library-and-associated -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 7 17:05:37 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 07 Aug 2023 22:05:37 +0000 Subject: [ET Trac] #2745: Inclusion of GRHayL library and associated MHD thorns Message-ID: #2745: Inclusion of GRHayL library and associated MHD thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): The CarpetX thorns are also in the GRHayLET repo, but require CarpetX to compile. They are ``` GRHayLET/GRHayLIDX GRHayLET/GRHayLHDX ``` `GRHayLET/IllinoisGRMHDX` is still in a separate branch being debugged, and I will update when it is merged or if it won?t make it in time for the release. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2745/inclusion-of-grhayl-library-and-associated -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 10 09:28:40 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 10 Aug 2023 14:28:40 +0000 Subject: [ET Trac] #2653: Carpet PreSync triggering syncs for all refinement levels unnecessarily Message-ID: #2653: Carpet PreSync triggering syncs for all refinement levels unnecessarily Reporter: Samuel Cupp Status: new Milestone: Version: Type: bug Priority: major Component: Carpet Comment (by Samuel Cupp): Thinking about this problem again, I think that this PR is not the proper solution. The recursive syncs are not the core problem if I remember correctly. It has been some time since I?ve looked at this, but as I recall the core issue was when I had no BCs registered for a variable. I had another PR \(accepted a while ago\) that added a warning for this, but originally there was a silent issue when trying to sync \+ apply BCs to a variable with no BCs registered. Carpet PreSync sees that it is valid in the interior and schedules these routines, but the BC call is effectively empty because nothing is registered. It silently returns to the function and then continues on. This means that it syncs every time something tries to read it because it is always at best `interior+ghosts`, and applying BCs always includes syncs. This ticket comes from the fact that the recursive part of the code accumulates these syncs, recursively syncs everything all the time, which is terrible. There should be something in Carpet or Boundary that properly warns/errors due to this, but that doesn?t seem to be the case. Once this behavior is fixed, we can see if we need this change to the recursive part of the code or not. However, my current thinking \(having admittedly not looked at this for quite some time\) is that this is more a mitigation of the issue than a true fix. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2653/carpet-presync-triggering-syncs-for-all -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 17 09:04:38 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 17 Aug 2023 14:04:38 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn SGRID is a code for generating binary neutron star data with arbitrary masses, spins and orbital eccentricities. This thorn provides an interface to import SGRID initial data into the Einstein Toolkit. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 17 09:11:37 2023 From: trac-noreply at einsteintoolkit.org (tootle) Date: Thu, 17 Aug 2023 14:11:37 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by tootle): I can offer being a reviewer if need be -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 17 09:12:22 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 17 Aug 2023 14:12:22 +0000 Subject: [ET Trac] #2748: Inclusion of SpaceTimeX in Einstein Toolkit Message-ID: #2748: Inclusion of SpaceTimeX in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn SpaceTimeX is an arrangement containing a collection of thorns for spacetime initial data, evolution, and analysis with CarpetX. ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2748/inclusion-of-spacetimex-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 17 09:13:18 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 17 Aug 2023 14:13:18 +0000 Subject: [ET Trac] #2748: Inclusion of SpaceTimeX in Einstein Toolkit Message-ID: #2748: Inclusion of SpaceTimeX in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{557058:d079f9c2-ad27-47b2-bf4b-ecc6bbe288b0} is a reviewer. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2748/inclusion-of-spacetimex-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 17 09:14:52 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 17 Aug 2023 14:14:52 +0000 Subject: [ET Trac] #2748: Inclusion of SpaceTimeX in Einstein Toolkit Message-ID: #2748: Inclusion of SpaceTimeX in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{557058:56049c54-f8c2-4b6c-9b88-ab697c967495} Please provide the list of thorns to be included in the release as soon as possible. The deadline for reviews is only a month away, so this will be quite difficult to meet if reviews do not start soon. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2748/inclusion-of-spacetimex-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 17 14:42:23 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 17 Aug 2023 19:42:23 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Hi @{5e5fc4216e8fdd0cd81720ad} . Thanks for offering to help. We asked Bruno?s group but haven?t heard back yet. If they do respond soon, I would see whether AsterX or SpaceTimeX is in more need of a second reviewer and ask you to help with that. If we don?t hear anything back, Jay and I would greatly appreciate you reviewing AsterX. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Aug 23 14:23:44 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Wed, 23 Aug 2023 19:23:44 +0000 Subject: [ET Trac] #2749: WVUThorns: sprintf use violates standard Message-ID: #2749: WVUThorns: sprintf use violates standard Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn I see these warnings when building WVUThorns: ``` /Users/eschnett/Cactus/arrangements/WVUThorns_Diagnostics/particle_tracerET/src/file_output_routines.C: In function 'void particle_tracerET_file_output_ascii(cGH*)': /Users/eschnett/Cactus/arrangements/WVUThorns_Diagnostics/particle_tracerET/src/file_output_routines.C:143:14: warning: 'sprintf' argument 3 overlaps destination object 'buffer' [-Wrestrict] 143 | sprintf(buffer, "%s %e %e %e %e", buffer, particle_u4U0[which_particle], particle_u4U1[which_particle], particle_u4U2[which_particle], particle_u4U3[which_particle]); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/eschnett/Cactus/arrangements/WVUThorns_Diagnostics/particle_tracerET/src/file_output_routines.C:154:14: warning: 'sprintf' argument 3 overlaps destination object 'buffer' [-Wrestrict] 154 | sprintf(buffer, "%s %e %e %e %e", buffer, particle_u4D0[which_particle], particle_u4D1[which_particle], particle_u4D2[which_particle], particle_u4D3[which_particle]); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/eschnett/Cactus/arrangements/WVUThorns_Diagnostics/particle_tracerET/src/file_output_routines.C:132:12: warning: 'sprintf' argument 3 overlaps destination object 'buffer' [-Wrestrict] 132 | sprintf(buffer, "%s %e %e %e", buffer, particle_position_x[which_particle], particle_position_y[which_particle], particle_position_z[which_particle]); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ COMPILING WVUThorns_Diagnostics/particle_tracerET/src/Interpolate_velocities_at_particle_positions.C ``` The C/C\+\+ standards do not allow writing the buffer to itself \(although this is a convenient way to append to a string\). Since this is C\+\+ code I suggest to use `std::ostringstream` instead. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2749/wvuthorns-sprintf-use-violates-standard -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Aug 23 14:28:35 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Wed, 23 Aug 2023 19:28:35 +0000 Subject: [ET Trac] #2750: HTTPD: Array access out of bounds Message-ID: #2750: HTTPD: Array access out of bounds Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Building HTTPD I see these warnings: ``` In function 'StringSetToBuffer', inlined from 'StringSetToBuffer' at /home/eschnetter/Cactus/arrangements/CactusConnect/HTTPD/src/SString.c:268:1, inlined from 'StringSetToCString' at /home/eschnetter/Cactus/arrangements/CactusConnect/HTTPD/src/SString.c:226:10: /home/eschnetter/Cactus/arrangements/CactusConnect/HTTPD/src/SString.c:273:7: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] 273 | strncpy( s->chars, buf, len ); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/eschnetter/Cactus/arrangements/CactusConnect/HTTPD/src/SString.c: In function 'StringSetToCString': /home/eschnetter/Cactus/arrangements/CactusConnect/HTTPD/src/SString.c:226:10: note: length computed here 226 | return StringSetToBuffer( s, c_string, strlen( c_string ) ); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` and ``` In function 'String_Copy', inlined from 'StringInsert' at /home/eschnetter/Cactus/arrangements/CactusConnect/HTTPD/src/SString.c:396:26: /home/eschnetter/Cactus/arrangements/CactusConnect/HTTPD/src/SString.c:125:3: warning: 'memcpy' offset [0, 2] is out of the bounds [0, 0] [-Warray-bounds=] 125 | memcpy( s->line_end, other->line_end, LINE_END_BUFSIZE | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 126 | * sizeof( SSCHAR ) ); | ~~~~~~~~~~~~~~~~~~~~ ``` These look serious. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2750/httpd-array-access-out-of-bounds -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Aug 23 14:31:54 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Wed, 23 Aug 2023 19:31:54 +0000 Subject: [ET Trac] #2751: EHFinder: Array reference out of bounds Message-ID: #2751: EHFinder: Array reference out of bounds Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: minor Component: Building EHFinder I see this warning: ``` /Users/eschnett/Cactus/arrangements/EinsteinAnalysis/EHFinder/src/EHFinder_IsoSurface_optimized.F90:448:10: 445 | do j=241,257 | 2 ...... 448 | a(j,i)=b9(i,jj) | 1 Warning: Array reference at (1) out of bounds (257 > 256) in loop beginning at (2) ``` ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2751/ehfinder-array-reference-out-of-bounds -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Aug 23 14:35:19 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Wed, 23 Aug 2023 19:35:19 +0000 Subject: [ET Trac] #2752: Parameter file parser generates illegal (?) C code Message-ID: #2752: Parameter file parser generates illegal (?) C code Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: major Component: Cactus I see this warnings when building the autogenerated Cactus bindings: ``` /Users/eschnett/Cactus/configs/sim-debug/bindings/Parameters/TwoPunctures_BBHSF_Parameters.c: In function 'CCTKi_BindingsCreateTwoPunctures_BBHSFParameters': /Users/eschnett/Cactus/configs/sim-debug/bindings/Parameters/TwoPunctures_BBHSF_Parameters.c:193:116: warning: unknown escape sequence: '\p' 193 | "Exponent delta for conformal decomposition of the scalar field \phi = \psi^delta \bar\phi", | ^ /Users/eschnett/Cactus/configs/sim-debug/bindings/Parameters/TwoPunctures_BBHSF_Parameters.c:193:116: warning: unknown escape sequence: '\p' /Users/eschnett/Cactus/configs/sim-debug/bindings/Parameters/TwoPunctures_BBHSF_Parameters.c:193:116: warning: unknown escape sequence: '\p' ``` It seems that a parameter description in a ccl file contains latex code, and the parameter file parse does not properly escape backslashes when generating C strings for them. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2752/parameter-file-parser-generates-illegal-c -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Aug 23 17:26:40 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Wed, 23 Aug 2023 22:26:40 +0000 Subject: [ET Trac] #2749: WVUThorns: sprintf use violates standard Message-ID: #2749: WVUThorns: sprintf use violates standard Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{5bae587b96242d2e2b6110a4} -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2749/wvuthorns-sprintf-use-violates-standard -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Aug 23 17:29:49 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Wed, 23 Aug 2023 22:29:49 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{5e5fc4216e8fdd0cd81720ad} Hey Samuel. Are you still willing to review AsterX? If so, I?ll send out an email with info \(though you?ve gone through this process recently\) to you and Jay. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Aug 23 17:33:17 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Wed, 23 Aug 2023 22:33:17 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Also, @{5accca1cc8c4282b41e130e4} , if anyone else should be listed as contributors on the release please let me know and make sure to double-check those lists when they come out. There?s been some issues in the past regarding people not getting listed because the release managers weren?t informed that there were additional code authors. ?Contributor? here generally means major contributors to the AsterX thorns, similar to paper authorship. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 24 09:14:36 2023 From: trac-noreply at einsteintoolkit.org (tootle) Date: Thu, 24 Aug 2023 14:14:36 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by tootle): @{557058:088051f9-5b94-4b5e-bfbe-71137030b9c1} No problem -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 24 13:24:10 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 24 Aug 2023 18:24:10 +0000 Subject: [ET Trac] #2749: WVUThorns: sprintf use violates standard Message-ID: #2749: WVUThorns: sprintf use violates standard Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Roland Haas): alternatively \(if one needs control over formatting\) one can use something like: ``` snprintf(buffer+strlen(buffer), sizeof(buffer) - strlen(buffer), "...", particle_u4U0[which_particle]) ``` where one leaves out the first ?buffer? \(and its ?%s?\). Alternatively, if this, as I suspect, is written to a file anyway, just use multiple `fprintf` calls which do use buffering anyway so will typically only write \(to a file\) in 1k or so chunks. If this is ASCII file IO, then any optimization on the code part is premature anyway since IO \(and the binary to ASCII conversion\) will be the slow parts anyway \(well unless one plasters the code with many many malloc/new/string/osstream object creations that is\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2749/wvuthorns-sprintf-use-violates-standard -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 24 13:31:42 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Thu, 24 Aug 2023 18:31:42 +0000 Subject: [ET Trac] #2753: Add CarpetX thorns to Einstein Toolkit manifest Message-ID: #2753: Add CarpetX thorns to Einstein Toolkit manifest Reporter: Erik Schnetter Status: new Milestone: Version: Type: proposal Priority: major Component: Other [https://bitbucket.org/einsteintoolkit/manifest/pull-requests/18](https://bitbucket.org/einsteintoolkit/manifest/pull-requests/18) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2753/add-carpetx-thorns-to-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 24 14:26:16 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 24 Aug 2023 19:26:16 +0000 Subject: [ET Trac] #2752: Parameter file parser generates illegal (?) C code Message-ID: #2752: Parameter file parser generates illegal (?) C code Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): component: EinsteinToolkit thorn (was Cactus) Comment (by Roland Haas): Most likely this is a ?\\phi? \(ie LaTeX syntax\) in one of the parameter descriptions of TwoPunctures\_BBHSF. Those get copied to C strings and will then trigger this. The simplest solution is to not use LaTeX code in Cactus description strings \(or double up on the backslash\). A better solution \(in Cactus\) may to sanitize strings passed in by users, but is only doable if there are not yet thorns that that double up the backslash already \(right now `grep -rF '\\' arrangements///*.ccl` returns none\). Cheng-Hsin and Giuseppe are maintainers, but Bitbucket will not let me enter Cheng-Hsin into the assignee field \(even though he is a teammate\) and Giuseppe does not seem to be a team member. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2752/parameter-file-parser-generates-illegal-c -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 24 14:33:51 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 24 Aug 2023 19:33:51 +0000 Subject: [ET Trac] #2753: Add CarpetX thorns to Einstein Toolkit manifest Message-ID: #2753: Add CarpetX thorns to Einstein Toolkit manifest Reporter: Erik Schnetter Status: new Milestone: Version: Type: proposal Priority: major Component: Other Comment (by Roland Haas): This would currently ?do harm? and prevent the thorn list from compiling for \(at least\) two reasons: ? * CarpetX and AMReX require C\+\+17 which is not enabled by any \(?\) of the option lists that ship with Simfactory in the ET * the thornlist lacks that ExternalLibraries required to compile CarpetX ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2753/add-carpetx-thorns-to-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 24 18:52:22 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 24 Aug 2023 23:52:22 +0000 Subject: [ET Trac] #2753: Add CarpetX thorns to Einstein Toolkit manifest Message-ID: #2753: Add CarpetX thorns to Einstein Toolkit manifest Reporter: Erik Schnetter Status: new Milestone: Version: Type: proposal Priority: major Component: Other Comment (by Samuel Cupp): As I said on the PR, this also has the issue that PoissonX inherits from PDESolvers, which is disabled. They probably should both be disabled or both enabled. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2753/add-carpetx-thorns-to-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Aug 25 08:22:39 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Fri, 25 Aug 2023 13:22:39 +0000 Subject: [ET Trac] #2753: Add CarpetX thorns to Einstein Toolkit manifest Message-ID: #2753: Add CarpetX thorns to Einstein Toolkit manifest Reporter: Erik Schnetter Status: new Milestone: Version: Type: proposal Priority: major Component: Other Comment (by Erik Schnetter): I corrected the missing ExternalLibraries and disabled the PoissonX thorn. I am looking for guidance regarding C\+\+17. I can see several ways forward: * Update currently supported machines, possibly removing some old machines from the list * Disabling CarpetX by default everywhere * Explicitly disabling CarpetX on those machines that don?t support C\+\+17 \(possibly many machines\) and updating others Sam, do you have a list of machines that you consider ?high priority? for the release? -erik ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2753/add-carpetx-thorns-to-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Aug 25 13:34:20 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Fri, 25 Aug 2023 18:34:20 +0000 Subject: [ET Trac] #2754: Inconsistent definition of B in evolution thorns Message-ID: #2754: Inconsistent definition of B in evolution thorns Reporter: Samuel Cupp Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn GRHydro and IllinoisGRMHD use different definitions for several quantities. This is mostly fine, as IllinoisGRMHD converts `vel` to get its desired velocity variable. However, the magnetic variable `B` also differs between these two thorns by a factor of `sqrt(4pi)`. This means that GRHydro couldn't use, for example, initial data from the Seed\_Magnetic\_Fields thorns without rescaling them. Without an expectation for what `B` is, diagnostic thorns that need this variable will produce incorrect results if used with anything except for the evolution thorn they were designed for. Presumably, all the WVUThorns are using IlliniosGRMHD?s `B`, and GRHydro\_InitData uses GRHydro?s `B`. Anything that isn't explicitly tied to an evolution thorn would be ambiguous. Is there a consensus on what `B` in HydroBase is expected to be? Especially with the transition to CarpetX, having a single definition for B would likely help keep thorns mutually compatible. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2754/inconsistent-definition-of-b-in-evolution -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Aug 25 14:04:38 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 25 Aug 2023 19:04:38 +0000 Subject: [ET Trac] #2754: Inconsistent definition of B in evolution thorns Message-ID: #2754: Inconsistent definition of B in evolution thorns Reporter: Samuel Cupp Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Roland Haas): Documented in: ? [https://bitbucket.org/einsteintoolkit/einsteinbase/src/db5777d1f921254d3e8d489c5b2e2b1c336113ef/HydroBase/interface.ccl#lines-15](https://bitbucket.org/einsteintoolkit/einsteinbase/src/db5777d1f921254d3e8d489c5b2e2b1c336113ef/HydroBase/interface.ccl#lines-15) and [https://bitbucket.org/einsteintoolkit/einsteinbase/src/master/HydroBase/doc/documentation.tex#lines-152](https://bitbucket.org/einsteintoolkit/einsteinbase/src/master/HydroBase/doc/documentation.tex#lines-152) which hopefully is determining all factors for sqrt\(4pi\) uniquely. This has been a bit of a headache since the very beginning of GRHydro. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2754/inconsistent-definition-of-b-in-evolution -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Aug 25 15:23:03 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Fri, 25 Aug 2023 20:23:03 +0000 Subject: [ET Trac] #2754: Inconsistent definition of B in evolution thorns Message-ID: #2754: Inconsistent definition of B in evolution thorns Reporter: Samuel Cupp Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Erik Schnetter): I am surprised that there is no consensus about `HydroBase`; this should be documented in that thorn. Given historic precedence, I would go with the definition used in `GRHydro`. `HydroBaseX` should then use the same definition. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2754/inconsistent-definition-of-b-in-evolution -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Aug 28 10:09:47 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 28 Aug 2023 15:09:47 +0000 Subject: [ET Trac] #2753: Add CarpetX thorns to Einstein Toolkit manifest Message-ID: #2753: Add CarpetX thorns to Einstein Toolkit manifest Reporter: Erik Schnetter Status: new Milestone: Version: Type: proposal Priority: major Component: Other Comment (by Roland Haas): Since we only really support gcc or \(on some systems\) clang I ran a quick test to see just how involved this might be: ``` .../mdb/optionlists$ git grep -l CC.*gcc * db-sing-cpu.cfg db-sing-nv.cfg debian-cuda.cfg expanse-gnu.cfg generic.cfg graham-gpu.cfg graham.cfg orca-gcc.cfg raspbian.cfg summit.cfg thornyflat.cfg wheeler.cfg ``` which shows that almost none of the big US production clusters \(except expanse and summit\) use `gcc` and none clang. `db-sing-nv` and `db-sing-cpu` are are both special for deepbayou and singularity and CarpetX so they are ok. So we would be disabling everywhere and enable only on db1, expanse and summit. We cannot easily enable on generic since that would push the minimum required gcc on workstations where we do not know what is present \(one hopes that everybody runs a gcc new enough, though gcc-11 might be too new for some setups\). I could not find any cluster officially using clang \(an only theta uses Cray?s `cc` wrapper but uses the intel compiler\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2753/add-carpetx-thorns-to-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Aug 29 20:44:51 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Wed, 30 Aug 2023 01:44:51 +0000 Subject: [ET Trac] #2753: Add CarpetX thorns to Einstein Toolkit manifest Message-ID: #2753: Add CarpetX thorns to Einstein Toolkit manifest Reporter: Erik Schnetter Status: new Milestone: Version: Type: proposal Priority: major Component: Other Comment (by Samuel Cupp): Sorry for not responding to this promptly. I do not have a complete list of machines that people are currently using. However, I know for sure people are using Deep Bayou, the INL machines, and Falcon. It looks like Falcon has gcc 12, which I believe has all of the '17 standard. Can you confirm what version of gcc is the minimum for CarpetX currently? I don?t know what machines the RIT group is using, but it sounded like several of their machines probably don?t have access to C\+\+17 \(or anything beyond like 2011?\). I agree with Roland that it would likely be untenable to require C\+\+17 by default to compile the toolkit. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2753/add-carpetx-thorns-to-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Aug 29 20:48:34 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Wed, 30 Aug 2023 01:48:34 +0000 Subject: [ET Trac] #2753: Add CarpetX thorns to Einstein Toolkit manifest Message-ID: #2753: Add CarpetX thorns to Einstein Toolkit manifest Reporter: Erik Schnetter Status: new Milestone: Version: Type: proposal Priority: major Component: Other Comment (by Samuel Cupp): I logged into the INL machines. The most recent versions listed by module are * sawtooth: gcc/10.4.0 * lemhi: gcc/11.2.0 ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2753/add-carpetx-thorns-to-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 31 07:41:17 2023 From: trac-noreply at einsteintoolkit.org (Peter Diener) Date: Thu, 31 Aug 2023 12:41:17 +0000 Subject: [ET Trac] #2745: Inclusion of GRHayL library and associated MHD thorns Message-ID: #2745: Inclusion of GRHayL library and associated MHD thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Peter Diener): I added the repository at the end of my einstein toolkit thornlist and got errors from GetComponents: ```none Do you want to update all existing components? yes, no [no] : n ----------------------------------------------------------------- Checking out module: Scalar/doc from repository: https://bitbucket.org/canuda/Scalar.git into: Cactus/arrangements ----------------------------------------------------------------- Checking out module: GRHayL/GRHayLib from repository: https://github.com/GRHayL/GRHayL.git into: Cactus/arrangements ----------------------------------------------------------------- Checking out module: GRHayLET/GRHayLHD from repository: https://github.com/GRHayL/GRHayLET.git into: Cactus/arrangements Warning: Could not checkout GRHayLET/GRHayLHD, unable to switch to branch main. Any existing symlinks to GRHayLET/GRHayLHD will be broken ----------------------------------------------------------------- Checking out module: GRHayLET/GRHayLMHD from repository: https://github.com/GRHayL/GRHayLET.git into: Cactus/arrangements ----------------------------------------------------------------- Checking out module: GRHayLET/GRHayLID from repository: https://github.com/GRHayL/GRHayLET.git into: Cactus/arrangements Warning: Could not checkout GRHayL/GRHayLib, unable to switch to branch main. Any existing symlinks to GRHayL/GRHayLib will be broken ----------------------------------------------------------------- 1 components checked out. 0 components updated. Unable to process GRHayLET/GRHayLHD Unable to process GRHayL/GRHayLib Summary of Warnings: Could not checkout GRHayLET/GRHayLHD, unable to switch to branch main. Any existing symlinks to GRHayLET/GRHayLHD will be broken Could not checkout GRHayL/GRHayLib, unable to switch to branch main. Any existing symlinks to GRHayL/GRHayLib will be broken ``` ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2745/inclusion-of-grhayl-library-and-associated -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 31 09:06:59 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 31 Aug 2023 14:06:59 +0000 Subject: [ET Trac] #2753: Add CarpetX thorns to Einstein Toolkit manifest Message-ID: #2753: Add CarpetX thorns to Einstein Toolkit manifest Reporter: Erik Schnetter Status: new Milestone: Version: Type: proposal Priority: major Component: Other Comment (by Samuel Cupp): Based on the call, the consensus seems to be to include CarpetX but have it disabled by default. We can, of course, change this to enabled in a future release. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2753/add-carpetx-thorns-to-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 31 09:35:32 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 31 Aug 2023 14:35:32 +0000 Subject: [ET Trac] #2753: Add CarpetX thorns to Einstein Toolkit manifest Message-ID: #2753: Add CarpetX thorns to Einstein Toolkit manifest Reporter: Erik Schnetter Status: new Milestone: Version: Type: proposal Priority: major Component: Other Comment (by Roland Haas): We have a list of tested compilers on [https://github.com/eschnett/CarpetX/wiki/CompilerCompatibility](https://github.com/eschnett/CarpetX/wiki/CompilerCompatibility) so we could for now add the thornlist to master to see what \(not if, we know something will\) breaks and then get started fixing things. gcc-9 is the earliest gcc compiler that was found to work which is newer than the current minimum of gcc-6 \(for C\+\+11\), so we may have to scout out which OS / distros / package manager provide older gcc by default \(or disable-thorns the CarpetX thorns in generic.ini which is opaque to users usually\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2753/add-carpetx-thorns-to-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 31 11:10:15 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 31 Aug 2023 16:10:15 +0000 Subject: [ET Trac] #2695: Inclusion of AsterX in the Einstein Toolkit Message-ID: #2695: Inclusion of AsterX in the Einstein Toolkit Reporter: Jay Kalinani Status: new Milestone: ET_2024_05 Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Changes (by Roland Haas): milestone: ET_2024_05 (was ET_2023_11) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2695/inclusion-of-asterx-in-the-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 31 11:39:17 2023 From: trac-noreply at einsteintoolkit.org (Anuj Kankani) Date: Thu, 31 Aug 2023 16:39:17 +0000 Subject: [ET Trac] #2755: bugs in POWER code Message-ID: #2755: bugs in POWER code Reporter: Anuj Kankani Status: submitted Milestone: Version: Type: bug Priority: minor Component: I noticed two bugs in the POWER code \([https://git.ncsa.illinois.edu/elihu/Gravitational\_Waveform\_Extractor](https://git.ncsa.illinois.edu/elihu/Gravitational_Waveform_Extractor)\) that I have l listed below. 1. Running the code as is on the GW150914 gallery example does not match the reference waveform provided. I believe this is due to lines 601-624 in the code, in the POWER function, where the amplitude and phase are fit to polynomials and extrapolated. Replacing these lines with numpy polyfit seems to fix the issue as far as I can tell, and I have provided a plot comparing the reference waveform with and without the fix. The code I used to replace line 601 and down is ``` #Extrapolate ? ? ? ? phase_extrapolation_order = 1 ? ? ? ? amp_extrapolation_order = 2 ? ? ? ? radii = np.asarray(radii, dtype=float) ? ? ? ? b_phase = np.empty(dtype=radii.dtype, shape=(len(radii), len(t))) ? ? ? ? b_amp = np.empty(dtype=radii.dtype, shape=(len(radii), len(t))) ? ? ? ? for j in range(len(radii)): ? ? ? ? ? ? b_phase[j] = phase[j][:, 1] ? ? ? ? ? ? b_amp[j] = amp[j][:, 1] ? ? ? ? ? ? ? ? radially_extrapolated_amp=np.polyfit(1/radii,b_amp,amp_extrapolation_order)[-1] ? ? ? ? radially_extrapolated_phase=np.polyfit(1/radii,b_phase,phase_extrapolation_order)[-1] ? ? ? ? ? ? ? ? radially_extrapolated_h_plus = radially_extrapolated_amp * np.cos(radially_extrapolated_phase) ? ? ? ? radially_extrapolated_h_cross = radially_extrapolated_amp * np.sin(radially_extrapolated_phase) ? ? ? ? extrapolated_strains[None][el,em] = np.column_stack((t, radially_extrapolated_h_plus, radially_extrapolated_h_cross)) ? ? return extrapolated_strains ``` ? 2\. In the `getCutoffFrequencyFromTwoPuncturesBBH` function lines 341-351 have incorrect equations for angular momentum. It looks like a typo between position and momentum in the second term. For example one equation is given as `angularmomentum1x = position1y * momentum1z - momentum1z * momentum1y` ? These are just two bugs I have found, I haven?t checked the whole code. Also, in the angular\_momentum function, it says ``` # RH: expression was originally provided by EAH ? ? # TODO: get referecen for this from EAH ``` I was just wondering if you had a reference for the equation used? ? Thanks! ? attachment: waveform-comparison.png (https://api.bitbucket.org/2.0/repositories/einsteintoolkit/tickets/issues/2755/attachments/waveform-comparison.png) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2755/bugs-in-power-code -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 31 16:13:14 2023 From: trac-noreply at einsteintoolkit.org (Peter Diener) Date: Thu, 31 Aug 2023 21:13:14 +0000 Subject: [ET Trac] #2745: Inclusion of GRHayL library and associated MHD thorns Message-ID: #2745: Inclusion of GRHayL library and associated MHD thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Peter Diener): The code compiled okay, but I have trouble running the Balsara1 tests in GRHayLHD and GRHayLMHD. First of all both tests tried to set a parameter from GRHayLID called test\_1D\_initial\_data. However, the parameter defined there is initial\_data\_1D. In addition they tried to set test\_shock\_direction, whereas the parameter defined in GRHayLID is shock\_direction.After fixing those, the tests started running but failed when trying to do output of GRHayLHD::rho\_b and GRHayLHD::pressure \(similarly for GRHayLMHD\). Looking in the interface.ccl of the hydro thorns is see rho\_b and pressure mentioned in a comment but they are not defined. ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2745/inclusion-of-grhayl-library-and-associated -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 31 16:37:16 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 31 Aug 2023 21:37:16 +0000 Subject: [ET Trac] #2755: bugs in POWER code Message-ID: #2755: bugs in POWER code Reporter: Anuj Kankani Status: submitted Milestone: Version: Type: bug Priority: major Component: Other Changes (by Roland Haas): responsible: [] (was ) component: Other (was ) priority: major (was minor) assignee: Roland Haas (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2755/bugs-in-power-code -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 31 16:39:05 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 31 Aug 2023 21:39:05 +0000 Subject: [ET Trac] #2755: bugs in POWER code Message-ID: #2755: bugs in POWER code Reporter: Anuj Kankani Status: submitted Milestone: Version: Type: bug Priority: major Component: Other Comment (by Roland Haas): Ouch, very wrong indeed. Thanks for the report. I will try and incorporate them as soon as I can. The angular momentum expression is probably one of those things that no one quite remembers where they got it from I \(RH\) can try and poke Eliu \(EAH\). Maybe he still recalls. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2755/bugs-in-power-code -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Aug 31 17:20:47 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 31 Aug 2023 22:20:47 +0000 Subject: [ET Trac] #2745: Inclusion of GRHayL library and associated MHD thorns Message-ID: #2745: Inclusion of GRHayL library and associated MHD thorns Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Sorry, I was actually working on that right now. Also, there?s been some internal pressure to make sure this gets in this release, but I am not sure how feasible it is to actually get them all ready. However, I at the very least would like to see if I can get `GRHayLib`, `GRHayLID`, and `GRHayLHD` in. I did push changes that should make the Balsara1 test work. We had switched the thorn from using its own copies of HydroBase to directly using HydroBase variables, which led to the issues you saw in regards to `rho` and `P`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2745/inclusion-of-grhayl-library-and-associated -------------- next part -------------- An HTML attachment was scrubbed... URL: