[ET Trac] #1842: clang-format options not valid for versions <=3.5

[Roland Haas]

#1842: clang-format options not valid for versions <=3.5

 Reporter: Frank Löffler
   Status: wontfix
Milestone: 
  Version: development version
     Type: bug
 Priority: minor
Component: Cactus

Changes (by Roland Haas):

status: wontfix (was new)

The current .clang-format file is not valid for clang-format versions 3.5 and below. The attached patch would 'fix' this by removing key words not known in version 3.5, but still wouldn't work for versions below that. I do not suggest to apply the patch - it should just show that this is quite some number.

Looking at the .clang-format file it seems that it does not use one of the pre-defined styles, but rather creates it's own (even if it is based on one given the comment in the file). I wonder if all of this is really necessary, or if we could not simply use one of the pre-defined styles, possibly with a few changes that work across clang-format versions.



**Keyword:**
Comment (by Roland Haas):

clang-format's output or options are not stable across versions. We currently (2023-02-03) require us of clang-format 9.0.1-16 for reproducible results.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1842/clang-format-options-not-valid-for
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20230203/88b13291/attachment.html