[ET Trac] #2686: Rename CCTK_REAL -> double when float is not tested

Erik Schnetter trac-noreply at einsteintoolkit.org
Wed Jan 25 20:36:02 CST 2023


#2686: Rename CCTK_REAL -> double when float is not tested

 Reporter: Zach Etienne
   Status: new
Milestone: 
  Version: 
     Type: enhancement
 Priority: minor
Component: 

Comment (by Erik Schnetter):

I’m not convinced they would break. I assume that many of them would switch to double precision for intermediate calculations, but they wouldn’t per se break. And if they break then it’s usually just a compile-time error that is straightforward to correct, such as e.g. calling `max(x, 1.0)` in C\+\+.

In fact, I am going to propose that we should build the commonly used thorns with single precision and correct these compiler errors.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2686/rename-cctk_real-double-when-float-is-not
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20230126/4b572504/attachment.html 


More information about the Trac mailing list