[ET Trac] #2697: Include BBH+scalar field initial data code from Canuda in ET

Roland Haas trac-noreply at einsteintoolkit.org
Wed Mar 22 21:09:32 CDT 2023


#2697: Include BBH+scalar field initial data code from Canuda in ET

 Reporter: Cheng-Hsin Cheng
   Status: new
Milestone: 
  Version: 
     Type: enhancement
 Priority: major
Component: 

Comment (by Roland Haas):

uh, not quite sure I follow. For the ET owned repo’s branch \(I guess manifest is the repo\) branching off of master is preferred. The reason being that “master” is the branch that actually gets tested on the cluster and that people who want the bleeding edge code download.   
For branches in Canuda’s home org: your choice really. As long as the master branch of `einsteintoolkit/manifest/einsteintoolkit.th` points to the the proposed branch in Canuda \(after the does no harm\) then this is fine \(eg a couple contributions use “main” instead of “master”\). There is a slight advantage if the proposed branch is the default branch since that is the one GetComponents will chose if not branch name is given \(and the vanilla “development” thornlist has no `REPO_BRANCH` statements\). But that is very minor and really only exploitable if the default branch is the branch development happens on \(and not eg the last stable release one\).

Note for release manager: having `REPO_BRANCH` in the development thornlist will likely require some changes to the scripts \(and script fragments\) used to create the release thornlist \(since it assumes that it can just add `REPO_BRANCH` and does not have to modify existing `REPO_BRANCH` statements\).

The branch name in outside repos is not under control anyway and with GitHub advertising against “master” there is a proliferation anyway \(“main”, “devel”, “development” seem to be popular\).

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scalar-field-initial-data-code
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20230323/cbf692c0/attachment-0001.html 


More information about the Trac mailing list