From trac-noreply at einsteintoolkit.org Wed Nov 1 12:25:56 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 01 Nov 2023 17:25:56 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Has someone tried? :-\) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 2 06:34:19 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Thu, 02 Nov 2023 11:34:19 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): I have tried, of course. However, I'm not sure what to expect after this test. Could any of you take a look at it and give me your feedback? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 2 12:09:35 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 02 Nov 2023 17:09:35 +0000 Subject: [ET Trac] #2761: some ExternalLibraries require cmake to build Message-ID: #2761: some ExternalLibraries require cmake to build Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: We do not list cmake as a requirement for the ET but some ExternalLibarries require it. A quick use of grep reveals: ``` grep -li cmake arrangements/ExternalLibraries/*/src/build.sh ``` these ``` arrangements/ExternalLibraries/ADIOS2/src/build.sh arrangements/ExternalLibraries/AMReX/src/build.sh arrangements/ExternalLibraries/NSIMD/src/build.sh arrangements/ExternalLibraries/openPMD/src/build.sh arrangements/ExternalLibraries/yaml_cpp/src/build.sh ``` For some cluster we may be able to enable cmake using machine.ini settings by loading a module, but for `generic.ini`we either have to declare cmake a ET dependency and then provide instructions on how to install it on the supported Linux / macOS hosts or disable the ExternalLibraries \(and their dependents, ie CarpetX\) by default. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2761/some-externallibraries-require-cmake-to -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 2 14:44:51 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Thu, 02 Nov 2023 19:44:51 +0000 Subject: [ET Trac] #2761: some ExternalLibraries require cmake to build Message-ID: #2761: some ExternalLibraries require cmake to build Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Erik Schnetter): I thought there was an `ExternalLibrary` that provides `cmake`? Could we use this? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2761/some-externallibraries-require-cmake-to -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 2 15:16:12 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 02 Nov 2023 20:16:12 +0000 Subject: [ET Trac] #2761: some ExternalLibraries require cmake to build Message-ID: #2761: some ExternalLibraries require cmake to build Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): yes, that is a possibility: [https://github.com/EinsteinToolkit/ExternalLibraries-CMake](https://github.com/EinsteinToolkit/ExternalLibraries-CMake) and has been tested in the past. Upside: tested, needs no extra installed packages. Downside: Cmake is very slow to compile, so ideally I would not have to build it. The ExternalLibraries provided CMake has been used on clusters \(where cmake was too old\), so is known to work \(needs some support by their client thorns \[basically have to look for cmake in `$CMAKE_DIR/bin/cmake`\] though since the CST does not allow to manipulate PATH, though I suspect one could actually make that work by manipulating variables in make.FOO.defn in bindings\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2761/some-externallibraries-require-cmake-to -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:40:37 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:40:37 +0000 Subject: [ET Trac] #2174: Test "Multi Patch Scalar Wave Equation" example Message-ID: #2174: Test "Multi Patch Scalar Wave Equation" example Reporter: Roland Haas Status: open Milestone: ET_2023_05 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): status: open (was resolved) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2174/test-multi-patch-scalar-wave-equation -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:40:41 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:40:41 +0000 Subject: [ET Trac] #2173: Test "Poisson equation" example Message-ID: #2173: Test "Poisson equation" example Reporter: Roland Haas Status: open Milestone: ET_2023_05 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): status: open (was resolved) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2173/test-poisson-equation-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:40:44 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:40:44 +0000 Subject: [ET Trac] #2176: Test "Binary neutron star" example Message-ID: #2176: Test "Binary neutron star" example Reporter: Roland Haas Status: open Milestone: ET_2023_05 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): status: open (was resolved) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2176/test-binary-neutron-star-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:41:14 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:41:14 +0000 Subject: [ET Trac] #2175: Test "Single, stable neutron star" example Message-ID: #2175: Test "Single, stable neutron star" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): milestone: ET_2023_11 (was ET_2023_05) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2175/test-single-stable-neutron-star-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:41:47 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:41:47 +0000 Subject: [ET Trac] #2175: Test "Single, stable neutron star" example Message-ID: #2175: Test "Single, stable neutron star" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Comment (by Roland Haas): @{557058:f7fd5133-6eee-4385-a5e5-3e03342a0b24} will handle this for ET\_2023\_11 -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2175/test-single-stable-neutron-star-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:42:01 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:42:01 +0000 Subject: [ET Trac] #2174: Test "Multi Patch Scalar Wave Equation" example Message-ID: #2174: Test "Multi Patch Scalar Wave Equation" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): milestone: ET_2023_11 (was ET_2023_05) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2174/test-multi-patch-scalar-wave-equation -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:42:14 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:42:14 +0000 Subject: [ET Trac] #2173: Test "Poisson equation" example Message-ID: #2173: Test "Poisson equation" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): responsible: (was []) milestone: ET_2023_11 (was ET_2023_05) assignee: (was Bing-Jyun Tsao) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2173/test-poisson-equation-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:42:24 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:42:24 +0000 Subject: [ET Trac] #2174: Test "Multi Patch Scalar Wave Equation" example Message-ID: #2174: Test "Multi Patch Scalar Wave Equation" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): responsible: (was []) assignee: (was jakedoherty) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2174/test-multi-patch-scalar-wave-equation -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:43:03 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:43:03 +0000 Subject: [ET Trac] #2176: Test "Binary neutron star" example Message-ID: #2176: Test "Binary neutron star" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): responsible: [] (was []) milestone: ET_2023_11 (was ET_2023_05) assignee: Steven R. Brandt (was Roland Haas) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2176/test-binary-neutron-star-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:43:32 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:43:32 +0000 Subject: [ET Trac] #2176: Test "Binary neutron star" example Message-ID: #2176: Test "Binary neutron star" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Comment (by Roland Haas): @{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} will handle this for ET\_2023\_11 -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2176/test-binary-neutron-star-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:44:25 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:44:25 +0000 Subject: [ET Trac] #2172: Test "Binary black hole GW150914" example Message-ID: #2172: Test "Binary black hole GW150914" example Reporter: Roland Haas Status: resolved Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): responsible: (was []) milestone: ET_2023_11 (was ET_2023_05) assignee: (was Steven R. Brandt) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2172/test-binary-black-hole-gw150914-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:44:48 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:44:48 +0000 Subject: [ET Trac] #2172: Test "Binary black hole GW150914" example Message-ID: #2172: Test "Binary black hole GW150914" example Reporter: Roland Haas Status: resolved Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Comment (by Roland Haas): @{5ec3db9e04f34b0c2d3a3d45} will handle this for ET\_2023\_11 -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2172/test-binary-black-hole-gw150914-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 11:44:54 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 03 Nov 2023 16:44:54 +0000 Subject: [ET Trac] #2172: Test "Binary black hole GW150914" example Message-ID: #2172: Test "Binary black hole GW150914" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): status: open (was resolved) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2172/test-binary-black-hole-gw150914-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 15:04:53 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Fri, 03 Nov 2023 20:04:53 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Hi Michal. I was looking over your test. It runs fine on my machine, and we?ll mention here if any of the test runners experience a failure. One thing I would suggest is that you activate the scalar output. You can just set it to the last iteration \(currently 10\) ``` IOScalar::outScalar_every = 10 # every_coarse ``` Then, the test will validate not just that the code runs, but also that the results match. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 3 15:05:32 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Fri, 03 Nov 2023 20:05:32 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): You?ll also have to add the output files to the `DNSdata/test/DNSdata_test` directory. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Nov 6 21:59:51 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 07 Nov 2023 03:59:51 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Done. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 7 08:32:44 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 07 Nov 2023 14:32:44 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): The test fails on the test server: [https://einsteintoolkit.github.io/tests/build\_810.html](https://einsteintoolkit.github.io/tests/build_810.html) The reason is that the test data includes data from SystemStatistics which includes eg the amount of free memory. See the diff output linked on the webpage: [https://github.com/EinsteinToolkit/tests/blob/gh-pages/records/version\_810/sim\_810\_1/DNSdata/DNSdata\_test.diffs](https://github.com/EinsteinToolkit/tests/blob/gh-pages/records/version_810/sim_810_1/DNSdata/DNSdata_test.diffs) Tests should not include data that will change each time, see eg [https://docs.einsteintoolkit.org/et-docs/Adding\_a\_test\_case](https://docs.einsteintoolkit.org/et-docs/Adding_a_test_case) for how a test should be structured. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 7 12:47:51 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 07 Nov 2023 18:47:51 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Should I simply remove this file? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 7 13:26:43 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Tue, 07 Nov 2023 19:26:43 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Sorry, I didn?t notice you were outputting a statistics file. You should also remove the SystemStatistics variable from the IO in the parfile so the output generated by the test matches what?s in the test directory. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 7 13:43:36 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 07 Nov 2023 19:43:36 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Done. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 7 14:14:21 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Tue, 07 Nov 2023 20:14:21 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Thanks! The only other changes I would like to suggest are 1\. there are several variables that are outputted but don?t have files in the test dir \(`HydroBase::w_lorentz`, `SphericalSurface::sf_radius`, and `ML_ADMConstraints::ML_Ham`\); I?d just remove these from the parfile, but if you want to check them please add the corresponding output files 2\. we aim to have the tests be as light-weight as possible; to that end, I?d suggest cutting down the number of iterations for the test to two or three scalar outputs two outputs would correspond to setting ``` Cactus::terminate = "iteration" Cactus::cctk_itlast = 512 ``` Changing this also means replacing all the files in `DNSdata/test/DNSdata_test` with the new output. Thanks for working with us on these changes. If the test fails on any machines, we will let you know. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 7 14:33:54 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 07 Nov 2023 20:33:54 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): I?d remove the output file and thorn SystemStatistics from the ActiveThorns line \(to run with as few thorns as possible\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 7 14:36:11 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Tue, 07 Nov 2023 20:36:11 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): He already removed the SystemStatistics output, if that?s what you mean. But yeah, removing the thorn completely is a reasonable request. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 7 14:43:08 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 07 Nov 2023 20:43:08 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): > I?d remove the output file and thorn SystemStatistics from the ActiveThorns line That is what I did. I?m working on the other suggestions now. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 7 15:05:47 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 07 Nov 2023 21:05:47 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Done \(other suggestions\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Nov 8 14:52:05 2023 From: trac-noreply at einsteintoolkit.org (Steven R. Brandt) Date: Wed, 08 Nov 2023 20:52:05 +0000 Subject: [ET Trac] #2762: The flesh is not thread safe Message-ID: #2762: The flesh is not thread safe Reporter: Steven R. Brandt Status: submitted Milestone: ET_2023_11 Version: Type: bug Priority: blocker Component: Cactus The flesh is not thread safe, and therefore CarpetX?s calling of functions through the flesh via openmp is broken. In particular, the function below The variable :`current_scheduled_function` is a global variable. ``` const cFunctionData *CCTK_ScheduleQueryCurrentFunction(const cGH * CCTK_ATTRIBUTE_UNUSED GH) { return current_scheduled_function; } ``` If one makes the following hackish edit \(which I do not recommend\) the problem goes away. ``` db1 flesh$ git diff src/main/ScheduleInterface.c|cat - diff --git a/src/main/ScheduleInterface.c b/src/main/ScheduleInterface.c index 93bdc20..c922904 100644 --- a/src/main/ScheduleInterface.c +++ b/src/main/ScheduleInterface.c @@ -12,6 +12,7 @@ #include #include #include +#include #include "cctk_Flesh.h" #include "cctk_WarnLevel.h" @@ -35,6 +36,8 @@ #include "util_Table.h" +#include "omp.h" + static const char *rcsid = "$Header$"; CCTK_FILEVERSION(main_ScheduleInterface_c); @@ -238,7 +241,7 @@ static int *scheduled_storage_groups_timelevels = NULL; static cTimerData *timerinfo = NULL; static int total_timer = -1; -static const cFunctionData *current_scheduled_function = NULL; +static const cFunctionData *current_scheduled_function[100];// = NULL; /******************************************************************** @@ -286,21 +289,22 @@ int CCTK_CallFunction(void *function, int (*oneargfunc)(void *); + int tn = omp_get_thread_num(); #if ALLOW_RECURSIVE_SCHEDULE_CALLS - const cFunctionData *previous_scheduled_function = current_scheduled_function; + const cFunctionData *previous_scheduled_function = current_scheduled_function[tn]; #else - if(current_scheduled_function != NULL) + if(current_scheduled_function[tn] != NULL) { CCTK_VWarn(CCTK_WARN_PICKY, __LINE__, __FILE__, "Cactus", "CCTK_CallFunction: recursive call, calling " "'%s: %s::%s' while within '%s: %s::%s'", fdata->where, fdata->thorn, fdata->routine, - current_scheduled_function->where, - current_scheduled_function->thorn, - current_scheduled_function->routine); + current_scheduled_function[tn]->where, + current_scheduled_function[tn]->thorn, + current_scheduled_function[tn]->routine); } #endif - current_scheduled_function = fdata; + current_scheduled_function[tn] = fdata; switch(fdata->type) { @@ -317,6 +321,7 @@ int CCTK_CallFunction(void *function, { case LangC: standardfunc = (void (*)(void *))function; + //assert(data != 0); standardfunc(data); break; case LangFortran: @@ -336,9 +341,9 @@ int CCTK_CallFunction(void *function, } #if ALLOW_RECURSIVE_SCHEDULE_CALLS - current_scheduled_function = previous_scheduled_function; + current_scheduled_function[tn] = previous_scheduled_function; #else - current_scheduled_function = NULL; + current_scheduled_function[tn] = NULL; #endif /* Return 0, meaning didn't synchronise */ @@ -369,7 +374,8 @@ int CCTK_CallFunction(void *function, @@*/ const cFunctionData *CCTK_ScheduleQueryCurrentFunction(const cGH * CCTK_ATTRIBUTE_UNUSED GH) { - return current_scheduled_function; + int tn = omp_get_thread_num(); + return current_scheduled_function[tn]; } /*@@ ``` I think what needs to be done is cctkGH needs to hold the current\_scheduled\_function and CarpetX needs to set it appropriately in its various copies. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2762/the-flesh-is-not-thread-safe -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Nov 8 15:07:23 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 08 Nov 2023 21:07:23 +0000 Subject: [ET Trac] #2762: The flesh is not thread safe Message-ID: #2762: The flesh is not thread safe Reporter: Steven R. Brandt Status: open Milestone: ET_2023_11 Version: Type: bug Priority: blocker Component: Cactus Changes (by Roland Haas): status: open (was submitted) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2762/the-flesh-is-not-thread-safe -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Nov 8 15:09:19 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 08 Nov 2023 21:09:19 +0000 Subject: [ET Trac] #2762: The flesh is not thread safe Message-ID: #2762: The flesh is not thread safe Reporter: Steven R. Brandt Status: open Milestone: ET_2023_11 Version: Type: bug Priority: blocker Component: Cactus Comment (by Roland Haas): related to #2326. Maybe use `#pragma omp threadlocal` for the global variable in question? At least somewhat standards conforming. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2762/the-flesh-is-not-thread-safe -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Nov 8 15:14:45 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 08 Nov 2023 21:14:45 +0000 Subject: [ET Trac] #2762: The flesh is not thread safe Message-ID: #2762: The flesh is not thread safe Reporter: Steven R. Brandt Status: open Milestone: ET_2023_11 Version: Type: bug Priority: major Component: Cactus Changes (by Roland Haas): priority: major (was blocker) Comment (by Roland Haas): Dowgrading to ?major?, according to [https://docs.einsteintoolkit.org/et-docs/Tickets#Priority](https://docs.einsteintoolkit.org/et-docs/Tickets#Priority) a ?blocker? is > The ET does not build, or another problem which means development cannot continue. This requires immediate attention. which is not true here. At best one could argue for ?critical? if indeed `CarpetX` is considered an important thorn \(which I would argue against since it?s new\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2762/the-flesh-is-not-thread-safe -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 9 09:28:03 2023 From: trac-noreply at einsteintoolkit.org (Gabriele Bozzola) Date: Thu, 09 Nov 2023 15:28:03 +0000 Subject: [ET Trac] #2757: NSIMD tries to download sleef when compiling Message-ID: #2757: NSIMD tries to download sleef when compiling Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Gabriele Bozzola): This happens on anvil too -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2757/nsimd-tries-to-download-sleef-when -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 10 17:52:14 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 10 Nov 2023 23:52:14 +0000 Subject: [ET Trac] #2172: Test "Binary black hole GW150914" example Message-ID: #2172: Test "Binary black hole GW150914" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): responsible: [] (was ) assignee: Deborah Ferguson (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2172/test-binary-black-hole-gw150914-example -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 10 18:38:08 2023 From: trac-noreply at einsteintoolkit.org (Steven R. Brandt) Date: Sat, 11 Nov 2023 00:38:08 +0000 Subject: [ET Trac] #2762: The flesh is not thread safe Message-ID: #2762: The flesh is not thread safe Reporter: Steven R. Brandt Status: open Milestone: ET_2023_11 Version: Type: bug Priority: major Component: Cactus Comment (by Steven R. Brandt): Add PR [https://bitbucket.org/cactuscode/cactus/pull-requests/158](https://bitbucket.org/cactuscode/cactus/pull-requests/158) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2762/the-flesh-is-not-thread-safe -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Nov 10 18:41:36 2023 From: trac-noreply at einsteintoolkit.org (Steven R. Brandt) Date: Sat, 11 Nov 2023 00:41:36 +0000 Subject: [ET Trac] #2762: The flesh is not thread safe Message-ID: #2762: The flesh is not thread safe Reporter: Steven R. Brandt Status: open Milestone: ET_2023_11 Version: Type: bug Priority: major Component: Cactus Comment (by Steven R. Brandt): Also [https://bitbucket.org/eschnett/carpet/pull-requests/59](https://bitbucket.org/eschnett/carpet/pull-requests/59) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2762/the-flesh-is-not-thread-safe -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 14 11:44:27 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 14 Nov 2023 17:44:27 +0000 Subject: [ET Trac] #2763: improve integration of CarpatX interpolator with Cactus Message-ID: #2763: improve integration of CarpatX interpolator with Cactus Reporter: Roland Haas Status: new Milestone: Version: Type: enhancement Priority: major Component: This adds a "CarpetX" local interpolator name to Cactus list of interpolators, so that client code can request an interpolator handle from `CCTK_InterpHandle` to pass to `CCTK_InterpGridArrays`. The actual handle is checked for and is the only one allowed. This prepares client code for a future full integration of the CarpetX interpolator with Cactus. Pull request is here: [https://github.com/eschnett/CarpetX/pull/248](https://github.com/eschnett/CarpetX/pull/248) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2763/improve-integration-of-carpatx -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Nov 14 11:44:57 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 14 Nov 2023 17:44:57 +0000 Subject: [ET Trac] #2763: improve integration of CarpetX interpolator with Cactus Message-ID: #2763: improve integration of CarpetX interpolator with Cactus Reporter: Roland Haas Status: new Milestone: Version: Type: enhancement Priority: major Component: Changes (by Roland Haas): title: improve integration of CarpetX interpolator with Cactus (was improve integration of CarpatX interpolator with Cactus) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2763/improve-integration-of-carpetx -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 16 08:52:57 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 16 Nov 2023 14:52:57 +0000 Subject: [ET Trac] #2762: The flesh is not thread safe Message-ID: #2762: The flesh is not thread safe Reporter: Steven R. Brandt Status: open Milestone: ET_2023_11 Version: Type: bug Priority: major Component: Cactus Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2762/the-flesh-is-not-thread-safe -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 16 08:53:02 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 16 Nov 2023 14:53:02 +0000 Subject: [ET Trac] #2763: improve integration of CarpetX interpolator with Cactus Message-ID: #2763: improve integration of CarpetX interpolator with Cactus Reporter: Roland Haas Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2763/improve-integration-of-carpetx -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 16 10:24:24 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Thu, 16 Nov 2023 16:24:24 +0000 Subject: [ET Trac] #2763: improve integration of CarpetX interpolator with Cactus Message-ID: #2763: improve integration of CarpetX interpolator with Cactus Reporter: Roland Haas Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Erik Schnetter): Merged as [https://github.com/eschnett/CarpetX/commit/6b2acc45a9ac45b74b88fccf6c9cfbcca847557e](https://github.com/eschnett/CarpetX/commit/6b2acc45a9ac45b74b88fccf6c9cfbcca847557e) . -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2763/improve-integration-of-carpetx -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 16 10:24:30 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Thu, 16 Nov 2023 16:24:30 +0000 Subject: [ET Trac] #2763: improve integration of CarpetX interpolator with Cactus Message-ID: #2763: improve integration of CarpetX interpolator with Cactus Reporter: Roland Haas Status: resolved Milestone: Version: Type: enhancement Priority: major Component: Changes (by Erik Schnetter): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2763/improve-integration-of-carpetx -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 16 10:24:52 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Thu, 16 Nov 2023 16:24:52 +0000 Subject: [ET Trac] #2763: improve integration of CarpetX interpolator with Cactus Message-ID: #2763: improve integration of CarpetX interpolator with Cactus Reporter: Roland Haas Status: closed Milestone: Version: Type: enhancement Priority: major Component: Changes (by Erik Schnetter): status: closed (was resolved) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2763/improve-integration-of-carpetx -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 16 10:25:07 2023 From: trac-noreply at einsteintoolkit.org (Erik Schnetter) Date: Thu, 16 Nov 2023 16:25:07 +0000 Subject: [ET Trac] #2763: improve integration of CarpetX interpolator with Cactus Message-ID: #2763: improve integration of CarpetX interpolator with Cactus Reporter: Roland Haas Status: resolved Milestone: Version: Type: enhancement Priority: major Component: Changes (by Erik Schnetter): status: resolved (was closed) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2763/improve-integration-of-carpetx -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Nov 20 09:15:27 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 20 Nov 2023 15:15:27 +0000 Subject: [ET Trac] #2764: PUGH tries to free memory not allocated by malloc Message-ID: #2764: PUGH tries to free memory not allocated by malloc Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Compiling PUGH I get warnings: ``` In function ?PUGH_SetupPGExtrasMemory?, inlined from ?PUGH_SetupPGExtras? at /data/rhaas/postdoc/gr/cactus/ET_trunk/configs/sim/build/PUGH/SetupPGV.c:101:11: /data/rhaas/postdoc/gr/cactus/ET_trunk/configs/sim/build/PUGH/SetupPGV.c:648:9: warning: ?free? called on pointer ?this? with nonzero offset 136 [-Wfree-nonheap-object] 648 | free(this->overlap); | ^~~~~~~~~~~~~~~~~~~ /data/rhaas/postdoc/gr/cactus/ET_trunk/configs/sim/build/PUGH/SetupPGV.c: In function ?PUGH_SetupPGExtras?: /data/rhaas/postdoc/gr/cactus/ET_trunk/configs/sim/build/PUGH/SetupPGV.c:96:10: note: returned from ?malloc? 96 | this = malloc(sizeof(pGExtras)); | ``` which are correct since `overlap` is not actually from `malloc` \(and neither are `ownvership` and `ghosts`\). The whole erro handling in `SetupPGV.c` is broken though, it e.g. assumes that `malloc` returns memory that is `NULL` initialized. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2764/pugh-tries-to-free-memory-not-allocated-by -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 30 11:52:01 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 30 Nov 2023 17:52:01 +0000 Subject: [ET Trac] #2755: bugs in POWER code Message-ID: #2755: bugs in POWER code Reporter: Anuj Kankani Status: open Milestone: Version: Type: bug Priority: major Component: Other Comment (by Roland Haas): I created a branch rhaas/fixes on the new POWER repo: [https://github.com/NCSAGravity/Gravitational\_Waveform\_Extractor/pull/1](https://github.com/NCSAGravity/Gravitational_Waveform_Extractor/pull/1) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2755/bugs-in-power-code -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 30 12:10:45 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 30 Nov 2023 18:10:45 +0000 Subject: [ET Trac] #2762: The flesh is not thread safe Message-ID: #2762: The flesh is not thread safe Reporter: Steven R. Brandt Status: open Milestone: ET_2023_11 Version: Type: bug Priority: major Component: Cactus Comment (by Roland Haas): Applied as git hash [c734c870](https://bitbucket.org/cactuscode/cactus/commits/c734c870f57b3fe152d60dcce2fd0d01759d9d60) "Cactus: fix DEBUG output for HasAccess, fix warnings" of [cactus](https://bitbucket.org/cactuscode/cactus) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2762/the-flesh-is-not-thread-safe -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 30 12:10:51 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 30 Nov 2023 18:10:51 +0000 Subject: [ET Trac] #2762: The flesh is not thread safe Message-ID: #2762: The flesh is not thread safe Reporter: Steven R. Brandt Status: resolved Milestone: ET_2023_11 Version: Type: bug Priority: major Component: Cactus Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2762/the-flesh-is-not-thread-safe -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 30 12:16:17 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 30 Nov 2023 18:16:17 +0000 Subject: [ET Trac] #2755: bugs in POWER code Message-ID: #2755: bugs in POWER code Reporter: Anuj Kankani Status: open Milestone: Version: Type: bug Priority: major Component: Other Comment (by Roland Haas): Applied as git hash [92d5b3a](https://github.com/NCSAGravity/Gravitational_Waveform_Extractor/commits/92d5b3ae8ec3d474c2af1da43fdfbef376c89e32) "POWER: correct angular momentum expression" of [Gravitational\_Waveform\_Extractor](https://github.com/NCSAGravity/Gravitational_Waveform_Extractor) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2755/bugs-in-power-code -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Nov 30 12:16:27 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 30 Nov 2023 18:16:27 +0000 Subject: [ET Trac] #2755: bugs in POWER code Message-ID: #2755: bugs in POWER code Reporter: Anuj Kankani Status: resolved Milestone: Version: Type: bug Priority: major Component: Other Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2755/bugs-in-power-code -------------- next part -------------- An HTML attachment was scrubbed... URL: