[ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit

Roland Haas trac-noreply at einsteintoolkit.org
Tue Nov 7 08:32:44 CST 2023


#2747: Inclusion of sgrid importer in Einstein Toolkit

 Reporter: Samuel Cupp
   Status: open
Milestone: ET_2023_11
  Version: 
     Type: enhancement
 Priority: major
Component: EinsteinToolkit thorn

Comment (by Roland Haas):

The test fails on the test server: [https://einsteintoolkit.github.io/tests/build\_810.html](https://einsteintoolkit.github.io/tests/build_810.html)

The reason is that the test data includes data from SystemStatistics which includes eg the amount of free memory. See the diff output linked on the webpage: [https://github.com/EinsteinToolkit/tests/blob/gh-pages/records/version\_810/sim\_810\_1/DNSdata/DNSdata\_test.diffs](https://github.com/EinsteinToolkit/tests/blob/gh-pages/records/version_810/sim_810_1/DNSdata/DNSdata_test.diffs)

Tests should not include data that will change each time, see eg [https://docs.einsteintoolkit.org/et-docs/Adding\_a\_test\_case](https://docs.einsteintoolkit.org/et-docs/Adding_a_test_case) for how a test should be structured.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.einsteintoolkit.org/pipermail/trac/attachments/20231107/fe03bdb3/attachment.htm>


More information about the Trac mailing list