From trac-noreply at einsteintoolkit.org Mon Oct 2 14:36:55 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 02 Oct 2023 19:36:55 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): When I try to compile, I get errors like ``` /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(Coordinates.o): in function `xyz_of_AnsorgNS': Coordinates.c:(.text+0xa48e): undefined reference to `GOMP_critical_name_start' /usr/bin/ld: Coordinates.c:(.text+0xa4dc): undefined reference to `GOMP_critical_name_end' /usr/bin/ld: Coordinates.c:(.text+0xac01): undefined reference to `GOMP_critical_name_start' /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(Coordinates.o): in function `dABphi_dxyz_AnsorgNS': Coordinates.c:(.text+0xb8cc): undefined reference to `GOMP_critical_name_start' /usr/bin/ld: Coordinates.c:(.text+0xb91c): undefined reference to `GOMP_critical_name_end' /usr/bin/ld: Coordinates.c:(.text+0xd14c): undefined reference to `GOMP_critical_name_start' /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(Coordinates.o): in function `xyz_of_AnsorgNS': Coordinates.c:(.text+0xac9b): undefined reference to `GOMP_critical_name_end' /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(Coordinates.o): in function `dABphi_dxyz_AnsorgNS': Coordinates.c:(.text+0xd27b): undefined reference to `GOMP_critical_name_end' /usr/bin/ld: /home/sam/grav/toolkit/tmp/Cactus/configs/sim/scratch/external/SGRID/lib/libsgrid.a(DNSgrid.o): in function `Interp_Var_From_Grid1_To_Grid2_star._omp_fn.0': DNSgrid.c:(.text+0x205): undefined reference to `omp_get_num_threads' /usr/bin/ld: DNSgrid.c:(.text+0x20c): undefined reference to `omp_get_thread_num' ``` Is ExternalLibraries/SGRID not properly hooking into the OMP in the toolkit? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 3 07:49:11 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 03 Oct 2023 12:49:11 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): We've made some changes and pushed them to ExternalLibraries-SGRID. Can you try again? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 3 14:22:01 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Tue, 03 Oct 2023 19:22:01 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): That seemed to fix it. Thanks. I?ll merge the new thorns into master to see if it works in the test suite. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 5 15:53:51 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 05 Oct 2023 20:53:51 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{634afd8853df3c01232121fd} Currently, `DNSdata` has a README, but no `doc/documentation.tex`. That means nothing will appear for it on the website, correct? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 5 16:43:04 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Oct 2023 21:43:04 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: new Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Correct. A documentation.tex file is mandatory. [https://docs.einsteintoolkit.org/et-docs/How\_to\_Review\_a\_new\_component#Formal\_criteria](https://docs.einsteintoolkit.org/et-docs/How_to_Review_a_new_component#Formal_criteria) ? ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 5 16:46:37 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Oct 2023 21:46:37 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 5 17:35:39 2023 From: trac-noreply at einsteintoolkit.org (Liwei Ji) Date: Thu, 05 Oct 2023 22:35:39 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Changes (by Liwei Ji): responsible: [] (was ) assignee: Liwei Ji (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 5 17:40:21 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Oct 2023 22:40:21 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): [https://bitbucket.org/einsteintoolkit/tickets/issues?responsible\_account\_id=612e314263f7bb006976dca8](https://bitbucket.org/einsteintoolkit/tickets/issues?responsible_account_id=612e314263f7bb006976dca8) did you take a look at the formal criteria when reviewing the SGRID importer and its associated code? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 5 20:15:36 2023 From: trac-noreply at einsteintoolkit.org (Liwei Ji) Date: Fri, 06 Oct 2023 01:15:36 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Liwei Ji): I?m reading it right now. And will keep it in mind -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 5 20:28:19 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Fri, 06 Oct 2023 01:28:19 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Samuel, Roland, I know I need to get that documentation.tex done, but I'm swamped with teaching right now. Can you give me a deadline to write it to keep this submission on track? I'm guessing it's ASAP, but do you need it by tonight, this weekend, or within the week? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 5 21:44:20 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Fri, 06 Oct 2023 02:44:20 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): The reviews are supposed to be done by next Wednesday. We can a little lenient about when the documentation is provided \(CarpetX has already made a deal with me to get it in a little late\). However, having at least one test parfile is strongly encouraged. This would go in `DNSdata/test/` and runs automatically anytime the testsuite is run. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Oct 6 10:47:42 2023 From: trac-noreply at einsteintoolkit.org (Zach Etienne) Date: Fri, 06 Oct 2023 15:47:42 +0000 Subject: [ET Trac] #2759: TwoPunctures swap_xz results in left-handed coordinate system Message-ID: #2759: TwoPunctures swap_xz results in left-handed coordinate system Reporter: Zach Etienne Status: new Milestone: Version: Type: bug Priority: minor Component: A word of caution: Swapping x<->z in TwoPunctures \(parameter swap\_xz = true\) results in a **non-right-handed coordinate system** \(coordinate permutation zyx\). This flips the sign of the y-component of the BH spin vectors away from what one might expect. In BH at H \([https://github.com/nrpy/nrpy/blob/main/nrpy/infrastructures/BHaH/general\_relativity/TwoPunctures/TP\_interp.py](https://github.com/nrpy/nrpy/blob/main/nrpy/infrastructures/BHaH/general_relativity/TwoPunctures/TP_interp.py)\) I implemented a permutation xyz ? zxy in TwoPunctures that maintains right-handedness, so the BHs will orbit on the zx plane instead of the xy plane. The inputs, including y-components of spin vectors, are consistent with the BHs initially orbiting on the xy plane, which is generally assumed in PN theory. I would recommend implementing a warning in TwoPunctures when swap\_xz is enabled, to make sure the user is aware of the implications of swapping x and z. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2759/twopunctures-swap_xz-results-in-left -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Oct 6 11:02:36 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 06 Oct 2023 16:02:36 +0000 Subject: [ET Trac] #2759: TwoPunctures swap_xz results in left-handed coordinate system Message-ID: #2759: TwoPunctures swap_xz results in left-handed coordinate system Reporter: Zach Etienne Status: new Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): I don?t know. We generally assume people know what they are doing \(they are doing science after all, one assumes a level of care\). Outputting a warning all the time just b/c a \(documented\) parameter is being set, does not seem right. If a warning is desired I would think a textual warning in `param.ccl` is sufficient. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2759/twopunctures-swap_xz-results-in-left -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 9 10:47:23 2023 From: trac-noreply at einsteintoolkit.org (Liwei Ji) Date: Mon, 09 Oct 2023 15:47:23 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Liwei Ji): I have looked at the files in CactusSgrid/DNSdata and they look good to me \(good style, comments and so on\). Is there anything else I need to do \(Sorry that I haven?t review any code before and have no experience\). I think the only miss pieces are documentations and tests. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 9 13:57:54 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 09 Oct 2023 18:57:54 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): @{634afd8853df3c01232121fd} what do other ID thorns do for tests? I know most just rely on evolution thorns which use them for tests, but this one obviously doesn?t have an existing test in any evolution thorns. I would like to see a test for this thorn, but if it needs a file to read I don?t know the right way to do that. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 9 15:22:15 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Mon, 09 Oct 2023 20:22:15 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): It is an initial data reader. I believe we need to provide a sample of the initial data to be read, interpolate onto the Cactus grid, and start the Cactus evolution. There are three files, weighing up to 80MB \(in the lowest resolution version\). My intention was to upload them to the "DNSdata/test/" directory. What do you think? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 9 16:42:02 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 09 Oct 2023 21:42:02 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): right. TwoPunctures just generates some ID at very low resolution. The `Meudon_Bin_Foo` thorns do not have tests. `FLRWSolver` uses a special ?no data file needed? setup for its test. CarpetIOHDF5 has some recover tests \(and ID reader\) in carpet/CarpetIOHDF5/test/input\_initial\_data.par and some data files for that \(15k data\). Same with einsteininitialdata/ReadInterpolate/test/synthetic.par \(1MB data\). 80MB is definitely too large. Ideally the files would <1MB \(they don?t need to be physically sane, so very few modes and few should be sufficient\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 10 07:35:47 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 10 Oct 2023 12:35:47 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): What about 17MB? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 10 09:30:46 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 10 Oct 2023 14:30:46 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): That would make it the largest file use by any test. ``` 0.179688 MB ./carpet/CarpetIOHDF5/test/newsep/grid.coordinates.file_0.h5 0.179688 MB ./carpet/CarpetIOHDF5/test/newsep/grid.coordinates.xyz.file_0.h5 0.191406 MB ./pittnullcode/SphericalHarmonicReconGen/test/CceR0158m.h5 0.996094 MB ./einsteininitialdata/ReadInterpolate/test/synthetic_write/checkpoint.chkpt.it_0.h5 1.32812 MB ./carpet/CarpetIOHDF5/test/CarpetWaveToyCheckpoint_test.it_64.h5 1.39844 MB ./pittnullcode/SphericalHarmonicRecon/test/metric_test_case.h5 11.0977 MB ./einsteinanalysis/AHFinderDirect/test/checkpointML-EE/checkpoint.chkpt.it_1.h5 ``` which I would consider a doubtful distinction. As said the file does not actually have to be a solution to anything real. So setting up eg Minkowski space using a single domain is fine. Though something with some actually non-zero values and spatially varying would of course be nice \(but linear basis functions would be enough\). It does not have to evolve, just read in and eg write out 1d ASCII output. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 10 21:18:14 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Wed, 11 Oct 2023 02:18:14 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): There is a new directory DNSdata/test/ now. It contains minimal initial data for Einstein Toolkit testing. They are: "BNSdata\_properties.txt", "checkpoint.0" \(4.2M\), and "test.par". All of them are necessary, but only "checkpoint.0" has a size in MB, the other two are in KB. The file "et.par" is a parfile for Cactus. It needs a path to this directory to be set as: DNSdata::sgrid\_datadir = "path\_to\_the\_directory/test". I'll appreciate your feedback here. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Oct 11 09:12:06 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 11 Oct 2023 14:12:06 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): the way to do it is to put a clever relative path in there that will work when Cactus runs the testsuite. Eg see `repos/carpet/CarpetIOHDF5/test/input_initial_data.par` which contains: ``` IO::filereader_ID_dir = "../../../arrangements/Carpet/CarpetIOHDF5/test/input_initial_data" ``` ? which will not work if eg you `cd` into the `test` directory and run the parfile manually using `cactus_sim foo.par` \(since the relative locations are different\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Oct 11 21:39:06 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Thu, 12 Oct 2023 02:39:06 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): I believe it's done. At least I did it in the analogous way. BTW: "...when Cactus runs the testsuite...". Can anybody explain how it works, and what is to do in this matter? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 12 07:29:52 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 12 Oct 2023 12:29:52 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Cactus runs the testsuite for compiled configuration ?sim? when you run: ``` make sim-testsuite ``` or use the `--testsuite` option of simfactory \(really only useful for the half-yearly testing\). They are also automatically run for each commit and results are shown on: [https://einsteintoolkit.github.io/tests](https://einsteintoolkit.github.io/tests) Right now it seems no SGRID tests are actually run. What happens if you do `make sim-testsuite`? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 12 20:49:40 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Fri, 13 Oct 2023 01:49:40 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Apparently, I'm doing something fundamentally wrong because ``` make sim-testsuite ``` does not take CactusSgrid into consideration. Extract from an output: ``` ======================================================================== Summary for configuration sim Time -> Thu Oct 12 22:09:09 EDT 2023 Host -> koko-login001.hpc.fau.edu Processes -> 2 User -> mpirog Total available tests -> 350 Unrunnable tests -> 15 Runnable tests -> 335 Total number of thorns -> 262 Number of tested thorns -> 99 Number of tests passed -> 325 Number passed only to set tolerance -> 182 Number failed -> 10 Tests passed: tov (from ADMMass) tov_carpet (from ADMMass) test_AHF_1 (from AHFinder) test_AHF_2 (from AHFinder) Kerr (from AHFinderDirect) Kerr-Cartoon (from AHFinderDirect) Kerr-Cartoon-EE (from AHFinderDirect) Kerr-EE (from AHFinderDirect) Kerr-definition-expansion (from AHFinderDirect) Kerr-definition-expansion-EE (from AHFinderDirect) Kerr-definition-expansion-product (from AHFinderDirect) Kerr-definition-expansion-product-EE (from AHFinderDirect) Kerr-definition-inner-expansion (from AHFinderDirect) Kerr-definition-inner-expansion-EE (from AHFinderDirect) Kerr-definition-mean-curvature (from AHFinderDirect) Kerr-definition-mean-curvature-EE (from AHFinderDirect) Kerr-modification-radius (from AHFinderDirect) Kerr-modification-radius-EE (from AHFinderDirect) Kerr-rotating-180 (from AHFinderDirect) Kerr-rotating-180-EE (from AHFinderDirect) Kerr-rotating-90 (from AHFinderDirect) Kerr-rotating-90-EE (from AHFinderDirect) Kerr-selection-areal-radius (from AHFinderDirect) Kerr-selection-areal-radius-EE (from AHFinderDirect) Kerr-selection-areal-radius-definition-expansion-product (from AHFinderDirect) Kerr-selection-areal-radius-definition-expansion-product-EE (from AHFinderDirect) Kerr-selection-mean-coordinate-radius (from AHFinderDirect) Kerr-selection-mean-coordinate-radius-EE (from AHFinderDirect) checkpointML-EE (from AHFinderDirect) misner1.2-025 (from AHFinderDirect) recoverML-EE (from AHFinderDirect) BaikalVacuum_EE_O8_sgw3d (from BaikalVacuum) BaikalVacuum_PreSync (from BaikalVacuum) boostedpuncture (from CT_MultiLevel) constraints_spherical (from CT_MultiLevel) poisson (from CT_MultiLevel) 64k2 (from Carpet) kasner (from Carpet) kasner_amr (from Carpet) no-overlap (from Carpet) overlap (from Carpet) presync (from Carpet) test_restrict_sync (from Carpet) CarpetEvolutionMask_test (from CarpetEvolutionMask) CarpetEvolutionMask_test_off (from CarpetEvolutionMask) buffer_mask (from CarpetEvolutionMask) compact (from CarpetIOASCII) coords (from CarpetIOASCII) grid-coords (from CarpetIOASCII) newsep (from CarpetIOASCII) CarpetWaveToyNewRecover_test_1proc (from CarpetIOHDF5) CarpetWaveToyRecover_test_1proc (from CarpetIOHDF5) CarpetWaveToyRecover_test_2proc (from CarpetIOHDF5) newsep (from CarpetIOHDF5) nobuffers (from CarpetIOHDF5) presyncRecover (from CarpetIOHDF5) coords (from CarpetIOScalar) coords2 (from CarpetIOScalar) coords3 (from CarpetIOScalar) coords4 (from CarpetIOScalar) newsep (from CarpetIOScalar) carpetintegrate (from CarpetIntegrateTest) carpetintegrate-linear (from CarpetIntegrateTest) waveinterp-1p (from CarpetInterp) waveinterp-2p (from CarpetInterp) test_cc_horest_o3 (from CarpetProlongateTest) test_cc_horest_o5 (from CarpetProlongateTest) test_cc_o0 (from CarpetProlongateTest) test_cc_o1 (from CarpetProlongateTest) test_cc_o2 (from CarpetProlongateTest) test_cc_o3 (from CarpetProlongateTest) test_cc_o4 (from CarpetProlongateTest) test_cc_o5 (from CarpetProlongateTest) test_cc_rest_o0 (from CarpetProlongateTest) test_cc_rest_o1 (from CarpetProlongateTest) test_cc_rest_o2 (from CarpetProlongateTest) test_cc_rest_o3 (from CarpetProlongateTest) test_cc_rest_o4 (from CarpetProlongateTest) test_cc_rest_o5 (from CarpetProlongateTest) test_cc_tvd (from CarpetProlongateTest) test_cc_tvd_hi (from CarpetProlongateTest) test_cc_tvd_x (from CarpetProlongateTest) test_cc_tvd_y (from CarpetProlongateTest) test_cc_tvd_z (from CarpetProlongateTest) test_interp (from CarpetProlongateTest) test_o1 (from CarpetProlongateTest) test_o11 (from CarpetProlongateTest) test_o3 (from CarpetProlongateTest) test_o5 (from CarpetProlongateTest) test_o7 (from CarpetProlongateTest) test_o9 (from CarpetProlongateTest) nonstaggered (from CarpetReduce) nonstaggered_excl (from CarpetReduce) periodic_weight (from CarpetReduce) staggered (from CarpetReduce) regrid2_2D (from CarpetRegrid2) regrid2_2cen (from CarpetRegrid2) regrid2_2cen_minfrac (from CarpetRegrid2) regrid2_granularity (from CarpetRegrid2) carpet (from Cartoon2D) schw-0050 (from Cartoon2D) test_cartoon_2 (from Cartoon2D) test_cartoon_3 (from Cartoon2D) test7patch (from Coordinates) test_ah (from Dissipation) test_ob (from Dissipation) E2xeon_test_dbh (from DistortedBHIVP) test_dbh (from DistortedBHIVP) eos_omni (from EOS_Omni) GaugeWave (from EinsteinExact_Test) KS-tilted-EE (from EinsteinExact_Test) KerrSchild (from EinsteinExact_Test) Minkowski (from EinsteinExact_Test) ModifiedSchwarzschildBL (from EinsteinExact_Test) ShiftedGaugeWave (from EinsteinExact_Test) Vaidya2 (from EinsteinExact_Test) Schwarzschild_EF (from Exact) bowl-init (from Exact) de_Sitter (from Exact) qc0-mclachlan (from Extract) GRHydro_test_shock (from GRHydro) GRHydro_test_shock_hllc (from GRHydro) GRHydro_test_shock_mp5 (from GRHydro) GRHydro_test_shock_ppm (from GRHydro) GRHydro_test_shock_weno (from GRHydro) GRHydro_test_tov_ppm_ML (from GRHydro) GRHydro_test_tov_ppm_ML_disable_internal_excision (from GRHydro) GRHydro_test_tov_ppm_no_trp_ML (from GRHydro) balsara1_1d (from GRHydro) balsara1_1d_dc (from GRHydro) balsara1_2d (from GRHydro) balsara1_2d_dc (from GRHydro) balsara2_1d (from GRHydro) balsara2_2d (from GRHydro) balsara3_1d (from GRHydro) balsara3_2d (from GRHydro) balsara4_1d (from GRHydro) balsara4_2d (from GRHydro) balsara5_1d (from GRHydro) balsara5_2d (from GRHydro) cylexp_tvd_mc2_hlle (from GRHydro) cylexp_tvd_mc2_hlle_dc (from GRHydro) test_one_hybrid (from GRHydro) test_tov_carpet_refined_nosync (from GRHydro) tov_carpetevolutionmask (from GRHydro) tov_carpetevolutionmask2 (from GRHydro) tov_slowsector (from GRHydro) magtov_poloidal (from GRHydro_InitData) magtov_poloidal_poloidal_P_p_2 (from GRHydro_InitData) GiRaFFE_tests_AlfvenWave (from GiRaFFE) GiRaFFE_tests_AlignedRotator (from GiRaFFE) GiRaFFE_tests_DegenAlfvenWave (from GiRaFFE) GiRaFFE_tests_ExactWald (from GiRaFFE) GiRaFFE_tests_FFEBreak (from GiRaFFE) GiRaFFE_tests_FastWave (from GiRaFFE) GiRaFFE_tests_MagnetoWald (from GiRaFFE) GiRaFFE_tests_SplitMonopole (from GiRaFFE) GiRaFFE_tests_ThreeWave (from GiRaFFE) test_restrict_sync (from HighOrderWaveTest) tov_mass_test (from Hydro_Analysis) two_tov (from Hydro_Analysis) diag_flip_pugh_eno (from Hydro_InitExcision) diag_pugh_eno (from Hydro_InitExcision) sphere_pugh_ppm (from Hydro_InitExcision) x_flip_pugh_eno (from Hydro_InitExcision) x_pugh_eno (from Hydro_InitExcision) rnsA2 (from Hydro_RNSID) kerr (from IDAnalyticBH) test_bl (from IDAnalyticBH) test_misner (from IDAnalyticBH) test_axibrill (from IDAxiBrillBH) test_axibrill_nostagger (from IDAxiBrillBH) E2xeon_test_axioddbh (from IDAxiOddBrillBH) test_axioddbh (from IDAxiOddBrillBH) ConstraintViolate (from IDConstraintViolate) test_pw_ADM_dir-x (from IDLinearWaves) test_pw_ADM_dir-z (from IDLinearWaves) test_waveell (from IDScalarWaveElliptic) test_recover (from IOHDF5) wavetoy (from InterpToArray) wavetoy2 (from InterpToArray) LeanBSSN_BY (from LeanBSSNMoL) LeanBSSN_BY-spin (from LeanBSSNMoL) LeanBSSN_BY-spin-no-gauge (from LeanBSSNMoL) LeanBSSN_BY-spin-no-lapse (from LeanBSSNMoL) LeanBSSN_BY-spin-no-shift (from LeanBSSNMoL) LeanBSSN_schw (from LeanBSSNMoL) llamawavetoy_6patch (from LlamaWaveToy) llamawavetoy_7patch (from LlamaWaveToy) test-minkowski-carpet-1lev (from LoopControl) ML_ADMConstraints (from ML_BSSN_Test) ML_BSSN_EE_sgw3d (from ML_BSSN_Test) ML_BSSN_EE_sgw3d_rhs (from ML_BSSN_Test) ML_BSSN_MP_O8_bh (from ML_BSSN_Test) ML_BSSN_NewRad (from ML_BSSN_Test) ML_BSSN_O8_sgw3d (from ML_BSSN_Test) ML_BSSN_sgw3d (from ML_BSSN_Test) ML_BSSN_sgw3d_harmonic (from ML_BSSN_Test) ML_BSSN_sgw3d_harmonic_phi (from ML_BSSN_Test) ML_BSSN_sgw3d_rhs (from ML_BSSN_Test) ML_CCZ4_sgw3d (from ML_CCZ4_Test) ML_CCZ4_sgw3d_rhs (from ML_CCZ4_Test) gaussian-RK4 (from ML_WaveToy_Test) gaussian-RK45 (from ML_WaveToy_Test) gaussian-RK45-adaptive (from ML_WaveToy_Test) memspeed (from MemSpeed) test_22 (from Multipole) test_31 (from Multipole) test_44 (from Multipole) test_driscollhealy (from Multipole) test_midpoint (from Multipole) test_rads (from Multipole) test_simpson (from Multipole) test_trapezoidal (from Multipole) test_vars (from Multipole) teukolsky (from NPScalars) LeanBSSN_Ei_mu0.4_c0.05 (from NPScalars_Proca) nancount (from NaNChecker) moving_tov (from Outflow) papi (from PAPI) ml-gw1d-small (from PeriodicCarpet) ml-gw1d-small-amr (from PeriodicCarpet) testperiodicinterp (from PeriodicCarpet) LeanBSSN_Ei_mu0.4_c0.05 (from ProcaEvolve) ML_BSSN_Ei_mu0.4_c0.05 (from ProcaEvolve) LeanBSSN_Ei_mu0.4_c0.05 (from Proca_simpleID) qlm-bl (from QuasiLocalMeasures) qlm-ks (from QuasiLocalMeasures) qlm-ks-EE (from QuasiLocalMeasures) qlm-ks-boosted (from QuasiLocalMeasures) qlm-ks-shifted (from QuasiLocalMeasures) qlm-ks-tilted (from QuasiLocalMeasures) qlm-minkowski (from QuasiLocalMeasures) admhydro (from ReadInterpolate) synthetic (from ReadInterpolate) E2xeon_test_rdbh (from RotatingDBHIVP) test_rdbh (from RotatingDBHIVP) Kerr-EE (from RotatingSymmetry180) Kerr-rotating-180-EE (from RotatingSymmetry180) Kerr-rotating-180-staggered-EE (from RotatingSymmetry180) Kerr-staggered-EE (from RotatingSymmetry180) KerrSchild-rotating-180-EE (from RotatingSymmetry180) Kerr-rotating-90-EE (from RotatingSymmetry90) Kerr-rotating-90-staggered-EE (from RotatingSymmetry90) KerrSchild-rotating-90-EE (from RotatingSymmetry90) wavetoyc (from SampleBoundary) slabtest (from SlabTest) regression_test (from SphericalHarmonicRecon) SpEC-dat-test (from SphericalHarmonicReconGen) SpEC-h5-test (from SphericalHarmonicReconGen) test_one_boost_max (from TOVSolver) test_one_static_max (from TOVSolver) test_tov_carpet (from TOVSolver) test_two_av (from TOVSolver) test_two_max (from TOVSolver) file (from TerminationTrigger) signal (from TerminationTrigger) walltime (from TerminationTrigger) arrays (from TestArrays) arrays0 (from TestArrays) TestComplex (from TestComplex) TestComplexPow (from TestComplex) test_fpointer_null (from TestFpointerNULL) TestAvg (from TestGlobalReduce) TestAvg_dest0 (from TestGlobalReduce) TestMax (from TestGlobalReduce) TestMax_dest0 (from TestGlobalReduce) TestMin (from TestGlobalReduce) TestMin_dest0 (from TestGlobalReduce) TestScalar (from TestGlobalReduce) TestSum (from TestGlobalReduce) TestSum_dest0 (from TestGlobalReduce) TestWeightAvg (from TestGlobalReduce) TestWeightMax (from TestGlobalReduce) TestWeightMin (from TestGlobalReduce) TestWeightSum (from TestGlobalReduce) gaussianMax (from TestGlobalReduce) gaussianMax_dest0 (from TestGlobalReduce) gaussianSum (from TestGlobalReduce) gaussianSum_dest0 (from TestGlobalReduce) test_local_interp_2 (from TestLocalInterp2) TestAvg (from TestLocalReduce) TestMax (from TestLocalReduce) TestSum (from TestLocalReduce) testloop (from TestLoop) testloop (from TestLoopControl) ICN (from TestMoL) ICN-avg (from TestMoL) RK2 (from TestMoL) RK2-MR-2-1 (from TestMoL) RK2-central (from TestMoL) RK3 (from TestMoL) RK4 (from TestMoL) RK4-MR-2-1 (from TestMoL) RK4-RK2 (from TestMoL) RK45 (from TestMoL) RK45CK (from TestMoL) RK65 (from TestMoL) RK87 (from TestMoL) expressions (from TestPar) ReadWriteCarpet (from TestReadWrite) trigger (from Trigger) bhns_eval (from TwoPunctures) bhns_interp (from TwoPunctures) twopunctures (from TwoPunctures) twopunctures_carpet (from TwoPunctures) twopunctures_kerrproca_c11 (from TwoPunctures_KerrProca) vectors (from Vectors) test_binary_1 (from WaveBinarySource) gaussian (from WaveMoL) wavetoy1df77 (from WaveToy1DF77) test_WaveToy2D (from WaveToy2DF77) test_rad (from WaveToyC) wave_output (from WaveToyC) test_rad (from WaveToyCXX) test_custom (from WaveToyExtra) test_rad (from WaveToyF77) test_rob (from WaveToyF77) test_rad (from WaveToyF90) test_wavef90_flat (from WaveToyF90) test_wavef90_zero (from WaveToyF90) test_rad (from WaveToyFreeF90) teukolsky (from WeylScal4) teukolskyID (from WeylScal4) teukolskyParity (from WeylScal4) Tests failed: Baikal_PreSync (from Baikal) magnetizedTOV-Baikal (from Baikal) FishboneMoncrief_IllinoisGRMHD-LLR (from FishboneMoncriefID) large_Afield_BNS (from Seed_Magnetic_Fields) magnetized_explosionTOV (from Seed_Magnetic_Fields) magnetized_explosionTOV (from Seed_Magnetic_Fields_BNS) magnetized_explosionTOV (from VolumeIntegrals_GRMHD) magnetized_explosionTOV (from VolumeIntegrals_vacuum) magnetized_explosionTOV (from particle_tracerET) magnetized_explosionTOV (from smallbPoynET) ======================================================================== ------------------------------------------------------------------------ ``` ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 16 12:15:59 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 16 Oct 2023 17:15:59 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): This test is trying to use `NSTracker`, which I don't think is part of the Einstein Toolkit. My guess is that its one of the unrunnable tests mentioned at the top. Can you just get rid of that thorn? Also, the parfile says its going to run to a final time of `2500`, which \(unless this runs very quickly\) is incorrect for a test. This isn?t going to run long, if at all, and it should be a minimal code test, not a physics test. So the grid doesn?t have to be well resolved. You can almost certainly move the outer boundary closer, and maybe remove some refinement levels. I?d say the iterations should probably be less than 10, especially if you?re doing full GRMHD. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 16 13:43:58 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 16 Oct 2023 18:43:58 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Additionally, the test shouldn?t try to output 2D or 3D data, since that?ll be way too much for the testsuite to compare against. I?d recommend removing all the extra wave extraction, 2D/3D output, TerminationTrigger, etc. Basically make it as lightweight as possible. To get the test to run successfully, you also need to have a directory `DNSdata/test/CactusSgrid_test`. The expected output for the test should live here. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 16 13:47:13 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Mon, 16 Oct 2023 18:47:13 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): If you want to keep the current parfile as an example for people, you could add `DNSdata/par/` and put a production-level parfile example there. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 10:28:08 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 17 Oct 2023 15:28:08 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): I created the directory "CactusSgrid\_test" as you suggested. Interestingly, when I change its name to, something else I'm getting feedback: "Parameter file CactusSgrid\_test in thorn DNSdata but no output directory" It means that this test procedure is aware of the thorn and the test. However, regardless if the name of this directory is set properly or not, it is not tested. I don't see it on the list of tested thorns, and it's not in the directory "TEST". And the correct directory \(CactusSgrid\_test\) is empty. Is it not tested, or it's failing the test? The feedback is: ``` Time -> Tue Oct 17 10:40:38 EDT 2023 Host -> koko-login003.hpc.fau.edu Processes -> 2 User -> mpirog Total available tests -> 352 Unrunnable tests -> 16 Runnable tests -> 336 Total number of thorns -> 261 Number of tested thorns -> 100 Number of tests passed -> 336 Number passed only to set tolerance -> 188 Number failed -> 0 Tests passed: [here goes the list of the tests but it's not here] ``` Is it among "Unrunnable tests"? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 12:31:22 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Tue, 17 Oct 2023 17:31:22 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Did you remove ?NSTracker?? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 13:50:51 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Tue, 17 Oct 2023 18:50:51 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp):
-- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 13:58:52 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 17 Oct 2023 18:58:52 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): I did it just without NSTracker. It helped. Now there is: Tests passed: \[...\] CactusSgrid\_test \(from DNSdata\) \[...\] -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 14:06:56 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Tue, 17 Oct 2023 19:06:56 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Ok. Are there any expected output files? If the directory with a name matching the parfile is empty, I think it succeeds so long as the run finishes regardless of the data. @{634afd8853df3c01232121fd} can correct me if that is wrong. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 14:28:59 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 17 Oct 2023 19:28:59 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): There is an output. I need to turn it off. And I need to prepare .par file and push it. And I'm super busy now because of teaching and I can take care about it tomorrow late evening/night. Will it be ok? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 14:31:09 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Tue, 17 Oct 2023 19:31:09 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): That?s fine. Also, don?t forget to add documentation. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 14:33:10 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Tue, 17 Oct 2023 19:33:10 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Right... Documentation... Let me think... What about Monday? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 14:49:58 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Tue, 17 Oct 2023 19:49:58 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): That works for me. Once the test is properly set up, it should be easy to tell if its working or not since the CI banner at the top of the website will be passing \(green\), pending \(yellow\), or failing \(red\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 17 17:53:28 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 17 Oct 2023 22:53:28 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): The test counts as ?passed? if there are no output files provided and the code exits cleanly \(exit code 0\). having some output can of course be useful to diagnose what failed \(and also that the numbers are correct\). Eg if the ID reader puts the metric where the curvature is expected that likely still gives exit code 0 but is of course completely wrong. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 19 08:16:55 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Thu, 19 Oct 2023 13:16:55 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): I pushed a new .par file and the test works well. There is an issue to discuss. The thorn reads the Sgrid ID, does the job, and leaves the data stored to be used again \(for the sake of efficiency, to not repeat this "job"\). Is it ok? We can write it that way and remove this data immediately, but it is not going to change the fact, that before Cactus can take the data they have to be \(temporarily or not\) written. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 19 08:53:25 2023 From: trac-noreply at einsteintoolkit.org (Leonardo Werneck) Date: Thu, 19 Oct 2023 13:53:25 +0000 Subject: [ET Trac] #2749: WVUThorns: sprintf use violates standard Message-ID: #2749: WVUThorns: sprintf use violates standard Reporter: Erik Schnetter Status: resolved Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Changes (by Leonardo Werneck): status: resolved (was new) Comment (by Leonardo Werneck): This issue was addressed in commit [72342fa](https://bitbucket.org/zach_etienne/wvuthorns_diagnostics/commits/72342fafe7e64b053b9009b376cef8263605771a). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2749/wvuthorns-sprintf-use-violates-standard -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 19 08:54:27 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 19 Oct 2023 13:54:27 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): The test is failing because if failed to find the BNS\_properties.txt file. It looks like you hard-coded the path for the file to something on your machine. Can you try switching it to the `../../../arrangements/CactusSgrid/DNSdata/test/sgrid_id`? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 19 08:58:27 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Thu, 19 Oct 2023 13:58:27 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Right. I forgot to change it back. Will be done in 10 min. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 19 09:00:41 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Thu, 19 Oct 2023 14:00:41 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Oh, sorry. I didn?t see your message before commenting. I?m not sure I understand. Are you talking about the parfile in test/sgrid\_id? How exactly does it interact with the test parfile? Do users normally have to run 2 different parfiles to use the thorn? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 19 09:14:42 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Thu, 19 Oct 2023 14:14:42 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): The complete set of ID contains three files: 1. BNSdata\_properties.txt - sgrid configuration summary 2. checkpoint.0 - main file with ID 3. sgrid\_id.par - sgrid parfile All of them are required to be there. The only thing you need for Cactus to run \(of for the test\) is a path to the directory where all there are located. It is one line you mentioned before: ``` DNSdata::sgrid_datadir = "../../../arrangements/CactusSgrid/DNSdata/test/sgrid_id" ``` The file ``` "../../../arrangements/CactusSgrid/DNSdata/test/sgrid_id/sgrid_id.par" ``` is not Cactus parfile. It is sgrid parfile and simply must be there. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Sun Oct 22 20:31:24 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Mon, 23 Oct 2023 01:31:24 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Where can I get cactus.sty ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 23 09:02:19 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 23 Oct 2023 14:02:19 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): It's in the Cactus flesh repo, `repos/flesh/doc/latex/cactus.sty` . However, when writing Cactus documentation in the `doc` directory of a thorn, usually you can put in \(well you should not have to put in anything assuming you start from either the template generated by `make newthorn` or copy and pasted an existing `documentation.tex` file \[and you are doing that aren?t you?\]\): ``` \usepackage{../../../../doc/latex/cactus} ``` The unusual case where this fails if when the directory structure does not match the expected one, usually b/c your repository structure is not `REPO_ROOT/Thorn/doc/documentation.tex` but eg instead `REPO_ROOT/CactusCode/Thorn/doc/documentation.tex` \(eg done by RePrimAnd\). Even in _that_ case you should still put in the path shown above, even if this makes running: ``` cd repos/foo/docs pdflatex documentation.tex ``` fail. Reason being that in fact you are not expected to run pdflatex yourself, but instead run `make FOO-ThornDoc` which will need that path \(and will fail otherwise and thus the web-documtentaion will fail and your thorn won?t be seen be anyone\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 26 09:41:32 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 26 Oct 2023 14:41:32 +0000 Subject: [ET Trac] #2609: Trigger thorn does not properly check return value from CCTK_TraverseString Message-ID: #2609: Trigger thorn does not properly check return value from CCTK_TraverseString Reporter: Roland Haas Status: new Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): @{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} says ?please apply?. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2609/trigger-thorn-does-not-properly-check -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 26 09:41:42 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 26 Oct 2023 14:41:42 +0000 Subject: [ET Trac] #2609: Trigger thorn does not properly check return value from CCTK_TraverseString Message-ID: #2609: Trigger thorn does not properly check return value from CCTK_TraverseString Reporter: Roland Haas Status: new Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [f157b7d](https://bitbucket.org/cactuscode/cactusutils/commits/f157b7dfa7468c9c63c7ae8d8e3ef670ff30271f) "Trigger: add more extensive error reporting, fix some border cases" of [cactusutils](https://bitbucket.org/cactuscode/cactusutils) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2609/trigger-thorn-does-not-properly-check -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 26 09:41:45 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 26 Oct 2023 14:41:45 +0000 Subject: [ET Trac] #2609: Trigger thorn does not properly check return value from CCTK_TraverseString Message-ID: #2609: Trigger thorn does not properly check return value from CCTK_TraverseString Reporter: Roland Haas Status: resolved Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2609/trigger-thorn-does-not-properly-check -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Oct 27 14:33:11 2023 From: trac-noreply at einsteintoolkit.org (Thiago Assumpcao) Date: Fri, 27 Oct 2023 19:33:11 +0000 Subject: [ET Trac] #2760: SyntaxWarnings Raised During Build Process with Python 3.12 Message-ID: #2760: SyntaxWarnings Raised During Build Process with Python 3.12 Reporter: Thiago Assumpcao Status: new Milestone: Version: ET_2023_05 Type: bug Priority: major Component: SimFactory When executing the `./simfactory/bin/sim build` command with Python 3.12, I encountered several warnings related to invalid escape sequences. The warnings are as follows: ```python :1: SyntaxWarning: invalid escape sequence '\d' :1: SyntaxWarning: invalid escape sequence '\(' ``` ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2760/syntaxwarnings-raised-during-build-process -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Sat Oct 28 00:06:55 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Sat, 28 Oct 2023 05:06:55 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): OK, the thorn's documentation is seating at: ``` ~/Cactus/repos/CactusSgrid/DNSdata/doc/documentation.tex ``` The path is: ``` \usepackage{../../../../doc/latex/cactus} ``` I'm in the directory "Cactus" and I'm trying: A\) ``` make DNSData-ThornDoc Creating thorn documentations... Created thorn documentations in doc/ThornDoc directory. Done. ``` B\) ``` make CactusSgrid-ThornDoc Creating thorn documentations... Created thorn documentations in doc/ThornDoc directory. Done. ``` C\) ``` make CactusSgrid/DNSData-ThornDoc Creating thorn documentations... Created thorn documentations in doc/ThornDoc directory. Done. ``` There is no such thing like "ThornDoc" at "Cactus/doc". Also, ``` ~/Cactus/repos/CactusSgrid/DNSdata/doc/ ``` does not contain .pdf file. I'm looking for .pdf file to see the output of the text I have written. Any help? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Sat Oct 28 15:51:50 2023 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Sat, 28 Oct 2023 20:51:50 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): the documentation that `make DNSData-ThornDoc` creates \(this being the correct command\) is, as the command reports put into `doc/ThornDoc`. Though in your case, you have a typo \(make is case sensitive\): the thorn is `DNSdata` \(lowercase ?d?\), not `DNSData`. So try: ``` make DNSdata-ThornDoc ``` which will report: ``` Creating thorn documentations... Processing thorn CactusSgrid/DNSdata... Parsing ccl files... ERROR: Could not create documentation (check for latex errors) Created thorn documentations in doc/ThornDoc directory. Done. ``` and you can find the PDF file in `doc/ThornDoc/CactusSgrid/DNSdat/documentation.pdf` \(if it builds, which it does not\). ``` ! LaTeX Error: Command \tableWidth already defined. Or name \end... illegal, see p.192 of the manual. See the LaTeX manual or LaTeX Companion for explanation. Type H for immediate help. ... l.74 ...length{\descWidth} \newlength{\tableWidth} \newlength{\maxVarWidth} ... ``` ? I would very strongly \(ie things will fail horribly if you don?t?\) to not use extra packages and if really, really, really necessary use `\newcommand` and not `\def` to define new commands \(also mind the comments in the template TeX file\). Also read-the-docs: [http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-115000C1.8.4](http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-115000C1.8.4) :-\) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Sat Oct 28 20:07:48 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Sun, 29 Oct 2023 01:07:48 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): > Though in your case, you have a typo \(make is case sensitive\): the thorn is `DNSdata` \(lowercase ?d?\), not `DNSData`. I'm so embarrassed... It works... Thank you \(for both, an advice and patience\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Sat Oct 28 20:22:26 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Sun, 29 Oct 2023 01:22:26 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Now I know I need to prepare the documentation as soon as possible, obviously. What about the upcoming test? What is the current situation regarding it? Is there anything else I should be doing or preparing? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 31 20:38:27 2023 From: trac-noreply at einsteintoolkit.org (Michal Pirog) Date: Wed, 01 Nov 2023 01:38:27 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Update: The documentation is written. Can you tell me what is the situation? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 31 23:06:11 2023 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Wed, 01 Nov 2023 04:06:11 +0000 Subject: [ET Trac] #2747: Inclusion of sgrid importer in Einstein Toolkit Message-ID: #2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): The testing involves people running the testsuite on various machines/clusters. So far, no one has said that the sgrid test is failing. I?ll ask Liwei to look over the documentation. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein -------------- next part -------------- An HTML attachment was scrubbed... URL: