[ET Trac] #2834: Baikal regeneration instruction in README fail
Zach Etienne
trac-noreply at einsteintoolkit.org
Fri Nov 8 11:11:59 CST 2024
#2834: Baikal regeneration instruction in README fail
Reporter: Roland Haas
Status: new
Milestone: ET_2024_11
Version:
Type: bug
Priority: major
Component:
Comment (by Zach Etienne):
Largely this is a README issue:
Only codes requiring NRPy generation will populate the thorns, so test/ doc/ and par/ will not be populated just by running NRPy. Instead, src/ and \*.ccl files should be deleted in the thorns and replaced with generated codes. The README should be updated to reflect this.
In addition, there have been some minor reshufflings to improve maintainability, diagnostics, and performance, including
1. computing the squared momentum constraint \(MSQUAREDGF\).
2. sorting the parameters in param.ccl in a case-insensitive alphabetical way.
3. replacing pow\(x, -1/6\) with 1 / sqrt\(cbrt\(x\)\) \(it is faster!\)
4. Starting all function-level comment blocks with /\*\* instead of /\* . This enables syntax highlighting of @param \[parameter name\] in all IDEs I tried \(emacs & vscode\).
5. simd/simd\_intrinsics.h has been tidied up a bit, and a few new intrinsics \(currently unused by Baikal\*, but used by other \[future ET\] NRPy projects\) were added.
The above changes reflect the Baikal\* thorns in the latest `NRPy-main`. Should I proceed in updating the README to use this? There is no functional change.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2834/baikal-regeneration-instruction-in-readme
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.einsteintoolkit.org/pipermail/trac/attachments/20241108/8df11fd2/attachment.htm>
More information about the Trac
mailing list