From trac-noreply at einsteintoolkit.org Thu Oct 3 09:24:33 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 03 Oct 2024 14:24:33 +0000 Subject: [ET Trac] #2820: NewRadX boundary condition conflicts with symmetry condition Message-ID: #2820: NewRadX boundary condition conflicts with symmetry condition Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): @Steven R Brandt asked if there is a test case that tests the implemented fix? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2820/newradx-boundary-condition-conflicts-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 3 09:53:32 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 03 Oct 2024 14:53:32 +0000 Subject: [ET Trac] #2821: update PETSc to 3.21.5 Message-ID: #2821: update PETSc to 3.21.5 Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): @Leonardo Werneck says: please apply. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2821/update-petsc-to-3215 -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 3 09:56:17 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 03 Oct 2024 14:56:17 +0000 Subject: [ET Trac] #2821: update PETSc to 3.21.5 Message-ID: #2821: update PETSc to 3.21.5 Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [f64a4f0](https://github.com/EinsteinToolkit/ExternalLibraries-PETSc/commits/f64a4f021f41fef96d2c87a9fb1630927f0b54cd) "PETSc: capture option list LIBS and LIBDIRS for [configure.py](http://configure.py)" of [ExternalLibraries-PETSc](https://github.com/EinsteinToolkit/ExternalLibraries-PETSc) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2821/update-petsc-to-3215 -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Oct 4 14:20:33 2024 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Fri, 04 Oct 2024 19:20:33 +0000 Subject: [ET Trac] #2825: GRHayL documentation files uses extra LaTeX package Message-ID: #2825: GRHayL documentation files uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Samuel Cupp): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} The thorns in `GRHayL` and `GRHayLET` should now meet these guidelines. If there?s still something wrong, please let me know. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2825/grhayl-documentation-files-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Oct 4 14:45:54 2024 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Fri, 04 Oct 2024 19:45:54 +0000 Subject: [ET Trac] #2828: WVUThorns_Diagnostics defines new macro outside of the "% START CACTUS THORNGUIDE" block Message-ID: #2828: WVUThorns_Diagnostics defines new macro outside of the "% START CACTUS THORNGUIDE" block Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Samuel Cupp): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} The thorns in `wvuthorns_diagnostics` should now meet these guidelines. If there?s still something wrong, please let me know. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2828/wvuthorns_diagnostics-defines-new-macro -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Oct 4 15:06:44 2024 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Fri, 04 Oct 2024 20:06:44 +0000 Subject: [ET Trac] #2808: prevent wvuthorns/IllinoisGRMHD from compiling in release past 2024_05 Message-ID: #2808: prevent wvuthorns/IllinoisGRMHD from compiling in release past 2024_05 Reporter: Roland Haas Status: resolved Milestone: Version: Type: enhancement Priority: minor Component: Changes (by Samuel Cupp): status: resolved (was new) Comment (by Samuel Cupp): The suggested changes have been implemented in the deprecated `IllinoisGRMHD` thorn. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2808/prevent-wvuthorns-illinoisgrmhd-from -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Oct 4 15:24:31 2024 From: trac-noreply at einsteintoolkit.org (Samuel Cupp) Date: Fri, 04 Oct 2024 20:24:31 +0000 Subject: [ET Trac] #2826: NRPyEllipticET documentation file uses extra LaTeX package Message-ID: #2826: NRPyEllipticET documentation file uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Samuel Cupp): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} This thorn should now meet these guidelines. If there?s still something wrong, please let me know. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2826/nrpyellipticet-documentation-file-uses -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 7 11:52:00 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 07 Oct 2024 16:52:00 +0000 Subject: [ET Trac] #2813: Allow CarpetX to implement Driver. Message-ID: #2813: Allow CarpetX to implement Driver. Reporter: Steven R. Brandt Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: open (was resolved) Comment (by Roland Haas): Merging is blocked so was not actually applied. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-implement-driver -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 7 15:09:47 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 07 Oct 2024 20:09:47 +0000 Subject: [ET Trac] #2813: Allow CarpetX to implement Driver. Message-ID: #2813: Allow CarpetX to implement Driver. Reporter: Steven R. Brandt Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [a941c336](https://github.com/einsteintoolkit/CarpetX/commits/a941c336a422030a1d4d72edcc38f69446ee623e) "WaveToyX: adapt to CarpetX implementation change" of [CarpetX](https://github.com/einsteintoolkit/CarpetX) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-implement-driver -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 7 15:09:53 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 07 Oct 2024 20:09:53 +0000 Subject: [ET Trac] #2813: Allow CarpetX to implement Driver. Message-ID: #2813: Allow CarpetX to implement Driver. Reporter: Steven R. Brandt Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-implement-driver -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Oct 9 13:16:42 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 09 Oct 2024 18:16:42 +0000 Subject: [ET Trac] #2821: update PETSc to 3.21.5 Message-ID: #2821: update PETSc to 3.21.5 Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2821/update-petsc-to-3215 -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Oct 9 17:35:37 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 09 Oct 2024 22:35:37 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: open Milestone: ET_2024_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Comments looking at TOVola:? ? 1. the documentation does not adhere to the rules in [http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-115000C1.8.4](http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-115000C1.8.4) namely it does not correctly ?namespace? the bibtex keys \(important when building the ThornGuide which would see conflicting keys\) 2. `STRING TOVola_ODE_method` in `param.ccl` should be `KEYWORD TOVola_ODE_method` 3. `0.0:* :: "Must be Positive"` is incorrect, unless non-negative is enough. Should use `(0.0:* :: "Must be positive"` as the range \(assuming the docs [http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-187000D2.3.2](http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-187000D2.3.2) still reflect the code and open intervals for double valued parameters have not been silently removed\) 4. same as 3 for `TOVola_absolute_max_step` and `TOVola_absolute_min_step` and possibly others 5. `STEERABLE=always` probably makes no sense for a parameter used by an ID thorn, could be removed 6. test parameter files produce `*.par` files in output, violating [https://docs.einsteintoolkit.org/et-docs/Adding\_a\_test\_case](https://docs.einsteintoolkit.org/et-docs/Adding_a_test_case) 7. `#include ` should be before any other includes \(incl. system ones, since it brings in any DEFINES produced by ExternalLibraries\). Should used `#include "cctk.h"` since `cctk.h`is not a a system provided include file \([https://www.gnu.org/software/c-intro-and-ref/manual/html\_node/include-Syntax.html](https://www.gnu.org/software/c-intro-and-ref/manual/html_node/include-Syntax.html) and [http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-92000C1.6.2](http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-92000C1.6.2)\). 8. `` should use `"` same as in 7. 9. since it?s one file only, could make the various helper functions declared in `TOVola_ODE.h` all `static` \(but is ok right now since properly namespaced\) 10. `void TOVola_exception_handler(double x, double y[])` and other functions must not be _defined_ \(contrasted to being _declared_ \) in header files since the compiler will create one copy of the code each time the header file is included leading to double defined symbols 11. not a bug: uses odd sort of indentation and placement of curly braces. Might want to consider using a ?standard? formatting as shown in [https://bitbucket.org/cactuscode/cactus/src/master/.clang-format](https://bitbucket.org/cactuscode/cactus/src/master/.clang-format) 12. `TOVola_TOV_Integrator_1` is scheduled in `local` mode \(default\), but only does global work, should be scheduled in global mode to not execute multiple times 13. `TOVola_TOV_Integrator_2` \(which should be global, see 12\) does error checks on what is essentially Cactus parameters, those should be done in a ParamCheck scheduled function so that they happen early on \([http://einsteintoolkit.org/referencemanual/ReferenceManual.html#x1-161000A2](http://einsteintoolkit.org/referencemanual/ReferenceManual.html#x1-161000A2)\) 14. the whole set of functions `TOVola_TOV_Integrator_1, TOVola_TOV_Integrator_2, `and` TOVola_TOV_Allocate` seems strange. All of this could be done in a single function without having to escape out to the scheduler shouldn?t it? Using C\+\+ one could use a `std::vector` and its `push_back` member to fill in the output array without having to compute its size first \(speed does not matter here, safety and readability of the code does\) 15. `TOVola_TOV_Allocate` does not handle failure from `malloc`, must be fixed 16. `TOVola_Raw_rSchw != NULL` is superfluous since `free` will accept a `NULL` pointer \(and do nothing\) [https://en.cppreference.com/w/c/memory/free](https://en.cppreference.com/w/c/memory/free) 17. `#define velx (&vel[0*cctk_lsh[0]*cctk_lsh[1]*cctk_lsh[2]])` is incorrect and will fail of array padding is used \(`cctk_lsh != cctk_ash`, [http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-98000C1.6.2](http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-98000C1.6.2)\). Don?t do this. use `CCTK_VECTGFINDEX3D` instead. Speed does not matter. If you do for some reason insist on not using `CCTK_VECTGFINDEX3D` for each access that at least do `#define vely &vel{CCTK_VECTGFINDEX3D(1, 0,0,0)] `but know that doing so will disable the range checks that `CCTK_GFINDEX3D` and related functions would do when Cactus is compiled in debug mode \(`DEBUG=yes`\). 18. in `( abs(x2-x1) == 1` I would think that for a properly coded bisection \(why not use C?s `bsearch` [https://en.cppreference.com/w/c/algorithm/bsearch](https://en.cppreference.com/w/c/algorithm/bsearch)\) 19. `TOVola_TOV_Copy` misses `restrict` keywords on its pointer args making the compiler assume they may be aliasing the same memory location 20. assumes `int == CCTK_INT` which may not be true, I suggest to use one and use it consistently \(or use `size_t` for array sizes and counters in array sizes\) 21. `TOVola_interp_Drive` should use the `DECLARE_CCTK_ARGUMENTS_FOO` checked flavors of argument declarations and should declare its `READS` and `WRITES` in `schedule.ccl` \([http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-86000C1.6.2](http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-86000C1.6.2)\) 22. it does not checked the return code from `malloc`, this must be fixed 23. do not use `CCTK_INFO("TOVola Beginning Grid Placements...");` in a `local` scheduled function since it will output its info warning for each component creating very messy output. If users really need to know when a function runs they can run with `schedule_verbose` in Carpet. And in CarpetX `local` functions run multi-threaded making the output possibly overlap. Don?t do this. 24. `for(int i=0; i From trac-noreply at einsteintoolkit.org Thu Oct 10 10:17:49 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 10 Oct 2024 15:17:49 +0000 Subject: [ET Trac] #2825: GRHayL documentation files uses extra LaTeX package Message-ID: #2825: GRHayL documentation files uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Fixed in git hash [6853fe9](https://github.com/GRHayL/GRHayL/commits/6853fe9ae29276621746325d125fa6239460921d) "GRHayLib: removed xspace, moved macros for docgen compatibility" of [GRHayL](https://github.com/GRHayL/GRHayL) and git hash [db43d81](https://github.com/GRHayL/GRHayLET/commits/db43d81b570a7ed388f7df0a288995af566c8786) "Docs: removed xspace, moved macros for docgen compatibility" of [GRHayLET](https://github.com/GRHayL/GRHayLET) ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2825/grhayl-documentation-files-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 10 10:18:00 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 10 Oct 2024 15:18:00 +0000 Subject: [ET Trac] #2825: GRHayL documentation files uses extra LaTeX package Message-ID: #2825: GRHayL documentation files uses extra LaTeX package Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: Changes (by Roland Haas): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2825/grhayl-documentation-files-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 10 10:18:24 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 10 Oct 2024 15:18:24 +0000 Subject: [ET Trac] #2826: NRPyEllipticET documentation file uses extra LaTeX package Message-ID: #2826: NRPyEllipticET documentation file uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Fixed in git hash [4d4e969](https://github.com/assumpcaothiago/NRPyElliptic/commits/4d4e96913d0601b8e126437b1b169e09d4272851) "NRPyEllipticET: removed xspace, moved macros to fix docgen errors" of [NRPyElliptic](https://github.com/assumpcaothiago/NRPyElliptic) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2826/nrpyellipticet-documentation-file-uses -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 10 10:18:31 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 10 Oct 2024 15:18:31 +0000 Subject: [ET Trac] #2826: NRPyEllipticET documentation file uses extra LaTeX package Message-ID: #2826: NRPyEllipticET documentation file uses extra LaTeX package Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: Changes (by Roland Haas): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2826/nrpyellipticet-documentation-file-uses -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 10 10:19:34 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 10 Oct 2024 15:19:34 +0000 Subject: [ET Trac] #2828: WVUThorns_Diagnostics defines new macro outside of the "% START CACTUS THORNGUIDE" block Message-ID: #2828: WVUThorns_Diagnostics defines new macro outside of the "% START CACTUS THORNGUIDE" block Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Fixed in git hash [378d2a0](https://bitbucket.org/zach_etienne/wvuthorns_diagnostics/commits/378d2a0e90e37b3d9ac477488ccb370bc0ae22fd) "Docs: fixed errors with toolkit doc generation" of [wvuthorns\_diagnostics](https://bitbucket.org/zach_etienne/wvuthorns_diagnostics) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2828/wvuthorns_diagnostics-defines-new-macro -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 10 10:19:43 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 10 Oct 2024 15:19:43 +0000 Subject: [ET Trac] #2828: WVUThorns_Diagnostics defines new macro outside of the "% START CACTUS THORNGUIDE" block Message-ID: #2828: WVUThorns_Diagnostics defines new macro outside of the "% START CACTUS THORNGUIDE" block Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: Changes (by Roland Haas): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2828/wvuthorns_diagnostics-defines-new-macro -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 10 10:29:27 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 10 Oct 2024 15:29:27 +0000 Subject: [ET Trac] #2824: CarpetX documentation file uses extra LaTeX package Message-ID: #2824: CarpetX documentation file uses extra LaTeX package Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): No longer happens as of git hash [b63528e7](https://bitbucket.org/cactuscode/cactus/commits/b63528e751b3d8e7bcf0114f902a0868ac39020b) "Cactus: add tabularx LaTeX package" of [cactus](https://bitbucket.org/cactuscode/cactus) which includes the missing packages in `cactus.sty`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2824/carpetx-documentation-file-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 10 10:29:35 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 10 Oct 2024 15:29:35 +0000 Subject: [ET Trac] #2824: CarpetX documentation file uses extra LaTeX package Message-ID: #2824: CarpetX documentation file uses extra LaTeX package Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: minor Component: Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2824/carpetx-documentation-file-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Oct 16 11:17:22 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 16 Oct 2024 16:17:22 +0000 Subject: [ET Trac] #2822: work around full paths used by pkg-config in `-l` options Message-ID: #2822: work around full paths used by pkg-config in `-l` options Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): Pull request is here: [https://bitbucket.org/cactuscode/cactus/pull-requests/166](https://bitbucket.org/cactuscode/cactus/pull-requests/166) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/work-around-full-paths-used-by-pkg-config -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Oct 16 11:17:34 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 16 Oct 2024 16:17:34 +0000 Subject: [ET Trac] #2822: work around full paths used by pkg-config in `-l` options Message-ID: #2822: work around full paths used by pkg-config in `-l` options Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): Please review -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/work-around-full-paths-used-by-pkg-config -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 21 11:30:24 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 21 Oct 2024 16:30:24 +0000 Subject: [ET Trac] #2822: work around full paths used by pkg-config in `-l` options Message-ID: #2822: work around full paths used by pkg-config in `-l` options Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): Applied as git hash [9032a73c](https://bitbucket.org/cactuscode/cactus/commits/9032a73c39ded0e279a5200aa42d439d5c68a093) "Cactus: work around pkg-config files that use full paths in -l" of [cactus](https://bitbucket.org/cactuscode/cactus) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/work-around-full-paths-used-by-pkg-config -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 21 15:43:08 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 21 Oct 2024 20:43:08 +0000 Subject: [ET Trac] #2822: work around full paths used by pkg-config in `-l` options Message-ID: #2822: work around full paths used by pkg-config in `-l` options Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: minor Component: Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/work-around-full-paths-used-by-pkg-config -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 21 16:11:16 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 21 Oct 2024 21:11:16 +0000 Subject: [ET Trac] #2787: einsteintoolkit.th no longer sorted alphabeticallly Message-ID: #2787: einsteintoolkit.th no longer sorted alphabeticallly Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: trivial Component: Comment (by Roland Haas): Manually sorted in git hash [69313d9](https://bitbucket.org/einsteintoolkit/manifest/commits/69313d91a303a74986f77bd0f80688254c2f0530) "[einsteintoolkit.th](http://einsteintoolkit.th): sort thornlist" of [manifest](https://bitbucket.org/einsteintoolkit/manifest) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2787/einsteintoolkitth-no-longer-sorted -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 21 17:08:47 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 21 Oct 2024 22:08:47 +0000 Subject: [ET Trac] #2787: einsteintoolkit.th no longer sorted alphabeticallly Message-ID: #2787: einsteintoolkit.th no longer sorted alphabeticallly Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: trivial Component: Changes (by Roland Haas): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2787/einsteintoolkitth-no-longer-sorted -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Mon Oct 21 22:58:43 2024 From: trac-noreply at einsteintoolkit.org (Maxwell Rizzo) Date: Tue, 22 Oct 2024 03:58:43 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: open Milestone: ET_2024_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Maxwell Rizzo): ReadMe/Documentation/Parfiles 1. In Output, hdf5 data is also supported through CarpetIOHDF5/IOHDF5 with Kuibit. 2. All 3 par files \(Piecewise, Simple, Tabulated\) have `IO::out_fileinfo="none" `and `CarpetIOASCII::compact_format = no` , both options Kuibit does not like. I recommend commenting out the first option and changing the second to yes to enable Kuibit support for ASCII files here. 3. In the documentation.tex, in the section ?Solving the ODE system? multiple different thorns are mentioned which gives off the impression that these thorns are critical in the operation of TOVola which I don?t think is the case. In the spirit of generality to other gravity/hydro solvers than what is used in the example parfiles this language could be refined. Some language dedicated towards how TOVola could be generalized with other solvers not used in the example parfiles might be helpful for users. Param.ccl 1. `TOVola_error_limit` could use description of what it actually is doing. 2. `TOVola_Max_Interpolation_Stencil` comment could be refined, it has the same comment as the previous parameter. General Driver 1. Since only the stencil size and the amount of layers in a simple polytrope are checked in the `TOVola_Parameter_Checker`, the inline comments and cactus output could maybe be refined to reflect that, both in the main driver and the schedule.ccl. The current output and comments may lead users to believe more parameters are being checked than just the two. 2. Looks like the logic in `switch (TOVola_TOV_Populate_Timelevels)` for case 3 and case 2 could be combined, code looks entirely identical except for one variable. Overall, I compiled TOVola into the ETK 2024\_05/ LevLandau release with no changes. I compiled the documentation.tex and the corresponding HTML. Additionally, I ran the two provided tests, simple and piecewise polytrope TOVola stars successfully. I visualized the initial output with Kuibit after the above changes to the parfiles were made. I went through the main driver routine and its supporting files, and can say the code is well documented and formatted. I apologize for my C knowledge with Cactus being slightly inadequate to say more, I will have to defer to Roland?s comments above regarding memory/Cactus infrastructure. I found TOVola to meet my standards and the quality/formal criteria listed in the Einstein Toolkit documentation for new components. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Oct 23 18:41:09 2024 From: trac-noreply at einsteintoolkit.org (tootle) Date: Wed, 23 Oct 2024 23:41:09 +0000 Subject: [ET Trac] #2772: Issues link against Kadath thorns and Intel MKL due to link ordering Message-ID: #2772: Issues link against Kadath thorns and Intel MKL due to link ordering Reporter: tootle Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by tootle): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} I?ve merged the final version of this fix into the master branch of the KadathThorn - no changes were needed to the KadathImporter thorn -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2772/issues-link-against-kadath-thorns-and -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 24 08:11:17 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 24 Oct 2024 13:11:17 +0000 Subject: [ET Trac] #2772: Issues link against Kadath thorns and Intel MKL due to link ordering Message-ID: #2772: Issues link against Kadath thorns and Intel MKL due to link ordering Reporter: tootle Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [f10c756](https://bitbucket.org/fukaws/KadathThorn/commits/f10c756894a84c5912de1e88b4434115652c93e0) "add finer control of link ordering to resolve UB when using MKL libraries" of [KadathThorn](https://bitbucket.org/fukaws/KadathThorn) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2772/issues-link-against-kadath-thorns-and -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 24 14:01:43 2024 From: trac-noreply at einsteintoolkit.org (David Boyer) Date: Thu, 24 Oct 2024 19:01:43 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: open Milestone: ET_2024_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by David Boyer): Thank you for the comments. After addressing and making all the changes based off of the comments from Zach and Roland which were pushed to my repo last week, I have now made the associated changes according to Maxwell?s review and also pushed those changes to my github. @{712020:002d68cb-a9e4-45eb-9433-93bf55a13168} The code and documentation is ready for another look. Thanks. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 24 16:51:52 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 24 Oct 2024 21:51:52 +0000 Subject: [ET Trac] #2772: Issues link against Kadath thorns and Intel MKL due to link ordering Message-ID: #2772: Issues link against Kadath thorns and Intel MKL due to link ordering Reporter: tootle Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2772/issues-link-against-kadath-thorns-and -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Sun Oct 27 19:19:00 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 28 Oct 2024 00:19:00 +0000 Subject: [ET Trac] #2783: MoL: Avoid empty array Message-ID: #2783: MoL: Avoid empty array Reporter: Erik Schnetter Status: open Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [88d50580](https://bitbucket.org/cactuscode/cactusnumerical/commits/88d505802862c15d3d05926f92c8e55de2487781) "MoL: Avoid empty complex array" of [cactusnumerical](https://bitbucket.org/cactuscode/cactusnumerical) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2783/mol-avoid-empty-array -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Sun Oct 27 19:19:11 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Mon, 28 Oct 2024 00:19:11 +0000 Subject: [ET Trac] #2783: MoL: Avoid empty array Message-ID: #2783: MoL: Avoid empty array Reporter: Erik Schnetter Status: resolved Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2783/mol-avoid-empty-array -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 29 11:20:00 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 29 Oct 2024 16:20:00 +0000 Subject: [ET Trac] #2807: Hydro_RNSD passes CFLAGS to LD Message-ID: #2807: Hydro_RNSD passes CFLAGS to LD Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Roland Haas): Pull request is here: [https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/19](https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/19) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2807/hydro_rnsd-passes-cflags-to-ld -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Oct 29 11:20:13 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 29 Oct 2024 16:20:13 +0000 Subject: [ET Trac] #2807: Hydro_RNSD passes CFLAGS to LD Message-ID: #2807: Hydro_RNSD passes CFLAGS to LD Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2807/hydro_rnsd-passes-cflags-to-ld -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Oct 30 08:54:59 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 30 Oct 2024 13:54:59 +0000 Subject: [ET Trac] #2761: some ExternalLibraries require cmake to build Message-ID: #2761: some ExternalLibraries require cmake to build Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Pull request is here: [https://bitbucket.org/einsteintoolkit/manifest/pull-requests/24](https://bitbucket.org/einsteintoolkit/manifest/pull-requests/24) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2761/some-externallibraries-require-cmake-to -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Oct 30 08:55:10 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 30 Oct 2024 13:55:10 +0000 Subject: [ET Trac] #2761: some ExternalLibraries require cmake to build Message-ID: #2761: some ExternalLibraries require cmake to build Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Please review -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2761/some-externallibraries-require-cmake-to -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 31 08:59:27 2024 From: trac-noreply at einsteintoolkit.org (Maxwell Rizzo) Date: Thu, 31 Oct 2024 13:59:27 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: open Milestone: ET_2024_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Maxwell Rizzo): Looks like the parfiles still have ``` CarpetIOASCII::compact_format = yes ``` , which I tested and kuibit doesn?t seem to work with. Additionally, it isn?t clear to me how I would go about using the Tabulated EoS support, I can?t easily find documentation here or on GRHayLib for how to go about creating and using tabulated EoS with TOVola. Other than that, everything looks good to me. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Oct 31 09:41:25 2024 From: trac-noreply at einsteintoolkit.org (Cheng-Hsin Cheng) Date: Thu, 31 Oct 2024 14:41:25 +0000 Subject: [ET Trac] #2827: TwoPunctures_BBHSF defines new macro outside of the "% START CACTUS THORNGUIDE" block Message-ID: #2827: TwoPunctures_BBHSF defines new macro outside of the "% START CACTUS THORNGUIDE" block Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Changes (by Cheng-Hsin Cheng): responsible: [] (was ) assignee: Cheng-Hsin Cheng (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2827/twopunctures_bbhsf-defines-new-macro -------------- next part -------------- An HTML attachment was scrubbed... URL: