From trac-noreply at einsteintoolkit.org Tue Sep 3 09:46:35 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 03 Sep 2024 14:46:35 +0000 Subject: [ET Trac] #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Message-ID: #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Pull request is here: [https://bitbucket.org/einsteintoolkit/einsteinutils/pull-requests/4](https://bitbucket.org/einsteintoolkit/einsteinutils/pull-requests/4) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2819/setmask_sphericalsurface-uses-loopcontrols -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 3 09:46:49 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 03 Sep 2024 14:46:49 +0000 Subject: [ET Trac] #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Message-ID: #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2819/setmask_sphericalsurface-uses-loopcontrols -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 3 15:43:05 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 03 Sep 2024 20:43:05 +0000 Subject: [ET Trac] #2821: update PETSc to 3.21.5 Message-ID: #2821: update PETSc to 3.21.5 Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn ExernalLibraries/PETSc fails to compile for me with gcc-14 and required both an update \(to 3.12.5\) and change in how it is compiled to make its own `configure.py` pass. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2821/update-petsc-to-3215 -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 3 15:48:12 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 03 Sep 2024 20:48:12 +0000 Subject: [ET Trac] #2821: update PETSc to 3.21.5 Message-ID: #2821: update PETSc to 3.21.5 Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Pull request is here: [https://github.com/EinsteinToolkit/ExternalLibraries-PETSc/pull/3](https://github.com/EinsteinToolkit/ExternalLibraries-PETSc/pull/3) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2821/update-petsc-to-3215 -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 3 15:48:21 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 03 Sep 2024 20:48:21 +0000 Subject: [ET Trac] #2821: update PETSc to 3.21.5 Message-ID: #2821: update PETSc to 3.21.5 Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2821/update-petsc-to-3215 -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 3 15:48:32 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 03 Sep 2024 20:48:32 +0000 Subject: [ET Trac] #2821: update PETSc to 3.21.5 Message-ID: #2821: update PETSc to 3.21.5 Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2821/update-petsc-to-3215 -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Sep 4 10:42:44 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 04 Sep 2024 15:42:44 +0000 Subject: [ET Trac] #2822: support full paths to libraries in LIBS variables Message-ID: #2822: support full paths to libraries in LIBS variables Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: minor Component: On macOS using Homebrew `pkg-config` for HDF5 returns full library paths instead of `-lLIBNAME` stanzas: ``` rhaas at gdd6l52n-ofc Cactus % pkg-config --libs-only-l --static hdf5 -lhdf5 -lm -ldl -l/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/lib/libz.tbd -l/opt/homebrew/lib/libsz.dylib ``` This happens only for static linking. This causes g\+\+ to fail at link time: ``` rhaas at gdd6l52n-ofc Cactus % g++ `pkg-config --libs-only-L hdf5` `pkg-config --libs-only-l --static hdf5` dummy.c clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated] ld: library '/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/lib/libz.tbd' not found ``` This seems like bug in the pkg-config file \(\`/opt/homebrew/Cellar/hdf5/1.14.3\_1/lib/pkgconfig/hdf5.pc\`\) supplied by HomeBrew: ``` rhaas at gdd6l52n-ofc Cactus % cat /opt/homebrew/Cellar/hdf5/1.14.3_1/lib/pkgconfig/hdf5.pc prefix=/opt/homebrew/Cellar/hdf5/1.14.3_1 exec_prefix=${prefix} libdir=${exec_prefix}/lib includedir=${prefix}/include Name: hdf5 Description: HDF5 (Hierarchical Data Format 5) Software Library Version: 1.14.3 Cflags: -I${includedir} Libs: -L${libdir} -lhdf5 Requires: Libs.private: -lhdf5 -lm -ldl -l/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/lib/libz.tbd -l/opt/homebrew/lib/libsz.dylib -l/opt/homebrew/lib/libsz.dylib Requires.private: ``` Correct would be to not use `-l` with the full path \(at least it will link\): ``` g++ `pkg-config --libs-only-L hdf5` dummy.c /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/lib/libz.tbd ``` Right now we have no way of handling full paths in LIBS files though git hash [cb3a8731](https://bitbucket.org/cactuscode/cactus/commits/cb3a873135a3032230aa687ed6174081c66b90b1) "Cactus: New pseudo-flag `-file=`" of [cactus](https://bitbucket.org/cactuscode/cactus) proposes some \(partial\) solution. This would require changes in all ExternalLibraries though \(that may need to pass `LIBS` to their own `configure`\). Another solution might be \(in `bash_utils.sh`\) to detect full paths in `-l` entries and split into a `-L` and a `-l` entry. This assumes knowledge of the library prefix \(usually `lib`\) and extension \(`.a`, `.so`, `.dylib`, `.dll`\). A workaround for HDF5 is to self-compile HDF5 using `HDF5_DIR=BUILD`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/support-full-paths-to-libraries-in-libs -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Sep 4 11:33:12 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 04 Sep 2024 16:33:12 +0000 Subject: [ET Trac] #2822: support full paths to libraries in LIBS variables Message-ID: #2822: support full paths to libraries in LIBS variables Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): A possible workaround in `bash_utils.sh` is ```shell # NOTE: This breaks if pkg-config returns quotes strings, i.e., path names # with strings in them. It doesn't seems to happen in practice. # If it does: let us know what pkg-config prints in that case, and we # can try to fix it. local INC_DIRS=$($PKGCONFIG --cflags-only-I "$STATIC" "$LIBNAME" | perl -pe 's/(^| )+-I/\1/g') local LIB_DIRS=$($PKGCONFIG --libs-only-L "$STATIC" "$LIBNAME" | perl -pe 's/(^| )+-L/\1/g') local LIBS="" local ALLLIBS=$($PKGCONFIG --libs-only-l "$STATIC" "$LIBNAME" | perl -pe 's/(^| )+-l/\1/g') for lib in $ALLLIBS; do if [ "${lib%/*}" != "$lib" ] ; then LIB_DIRS="$LIB_DIRS ${lib%/*}" lib=${lib##*/lib} lib=${lib%.*} fi LIBS="$LIBS $lib" done ``` ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/support-full-paths-to-libraries-in-libs -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Sep 4 11:41:56 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 04 Sep 2024 16:41:56 +0000 Subject: [ET Trac] #2822: support full paths to libraries in LIBS variables Message-ID: #2822: support full paths to libraries in LIBS variables Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/support-full-paths-to-libraries-in-libs -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Sep 4 11:43:13 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 04 Sep 2024 16:43:13 +0000 Subject: [ET Trac] #2822: support full paths to libraries in LIBS variables Message-ID: #2822: support full paths to libraries in LIBS variables Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Changes (by Roland Haas): On macOS using Homebrew `pkg-config` for HDF5 returns full library paths instead of `-lLIBNAME` stanzas: ``` rhaas at gdd6l52n-ofc Cactus % pkg-config --libs-only-l --static hdf5 -lhdf5 -lm -ldl -l/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/lib/libz.tbd -l/opt/homebrew/lib/libsz.dylib ``` This happens only for static linking. This causes g\+\+ to fail at link time: ``` rhaas at gdd6l52n-ofc Cactus % g++-14 `pkg-config --libs-only-L hdf5` `pkg-config --libs-only-l --static hdf5` dummy.c ld: library '/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/lib/libz.tbd' not found collect2: error: ld returned 1 exit status ``` This seems like bug in the pkg-config file \(\`/opt/homebrew/Cellar/hdf5/1.14.3\_1/lib/pkgconfig/hdf5.pc\`\) supplied by HomeBrew: ``` rhaas at gdd6l52n-ofc Cactus % cat /opt/homebrew/Cellar/hdf5/1.14.3_1/lib/pkgconfig/hdf5.pc prefix=/opt/homebrew/Cellar/hdf5/1.14.3_1 exec_prefix=${prefix} libdir=${exec_prefix}/lib includedir=${prefix}/include Name: hdf5 Description: HDF5 (Hierarchical Data Format 5) Software Library Version: 1.14.3 Cflags: -I${includedir} Libs: -L${libdir} -lhdf5 Requires: Libs.private: -lhdf5 -lm -ldl -l/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/lib/libz.tbd -l/opt/homebrew/lib/libsz.dylib -l/opt/homebrew/lib/libsz.dylib Requires.private: ``` Correct would be to not use `-l` with the full path \(at least it will link\): ``` g++-14 `pkg-config --libs-only-L hdf5` dummy.c /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/lib/libz.tbd ``` Right now we have no way of handling full paths in LIBS files though git hash [cb3a8731](https://bitbucket.org/cactuscode/cactus/commits/cb3a873135a3032230aa687ed6174081c66b90b1) "Cactus: New pseudo-flag `-file=`" of [cactus](https://bitbucket.org/cactuscode/cactus) proposes some \(partial\) solution. This would require changes in all ExternalLibraries though \(that may need to pass `LIBS` to their own `configure`\). Another solution might be \(in `bash_utils.sh`\) to detect full paths in `-l` entries and split into a `-L` and a `-l` entry. This assumes knowledge of the library prefix \(usually `lib`\) and extension \(`.a`, `.so`, `.dylib`, `.dll`\). A workaround for HDF5 is to self-compile HDF5 using `HDF5_DIR=BUILD`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/support-full-paths-to-libraries-in-libs -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 09:30:48 2024 From: trac-noreply at einsteintoolkit.org (Leonardo Werneck) Date: Thu, 05 Sep 2024 14:30:48 +0000 Subject: [ET Trac] #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Message-ID: #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Leonardo Werneck): Please apply. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2819/setmask_sphericalsurface-uses-loopcontrols -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 09:37:24 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 14:37:24 +0000 Subject: [ET Trac] #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Message-ID: #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Thank you. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2819/setmask_sphericalsurface-uses-loopcontrols -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 09:37:34 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 14:37:34 +0000 Subject: [ET Trac] #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Message-ID: #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [01d568f](https://bitbucket.org/einsteintoolkit/einsteinutils/commits/01d568fb7ae258e6822af450353d5a7dc3401168) "SetMask\_SphericalSurface: support padded grid arrays" of [einsteinutils](https://bitbucket.org/einsteintoolkit/einsteinutils) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2819/setmask_sphericalsurface-uses-loopcontrols -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 09:37:43 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 14:37:43 +0000 Subject: [ET Trac] #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Message-ID: #2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2819/setmask_sphericalsurface-uses-loopcontrols -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 09:39:15 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 14:39:15 +0000 Subject: [ET Trac] #2822: support full paths to libraries in LIBS variables Message-ID: #2822: support full paths to libraries in LIBS variables Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): @{5bae587b96242d2e2b6110a4} says that this also can be \(for hdf5 with homebrew\) be avoid by not passing the `--static` flag to `pkg-config`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/support-full-paths-to-libraries-in-libs -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 09:40:46 2024 From: trac-noreply at einsteintoolkit.org (Leonardo Werneck) Date: Thu, 05 Sep 2024 14:40:46 +0000 Subject: [ET Trac] #2817: update ExternalLibraries-libjpeg to version 9f Message-ID: #2817: update ExternalLibraries-libjpeg to version 9f Reporter: Roland Haas Status: open Milestone: Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Leonardo Werneck): Please apply. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2817/update-externallibraries-libjpeg-to -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 10:13:30 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 15:13:30 +0000 Subject: [ET Trac] #2817: update ExternalLibraries-libjpeg to version 9f Message-ID: #2817: update ExternalLibraries-libjpeg to version 9f Reporter: Roland Haas Status: open Milestone: Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [04d84a6](https://github.com/EinsteinToolkit/ExternalLibraries-libjpeg/commits/04d84a62e498663be3bdc5a8c678a3bf1143f5bf) "libjpeg: add docs for INC\_DIRS and LIB\_DIRS" of [ExternalLibraries-libjpeg](https://github.com/EinsteinToolkit/ExternalLibraries-libjpeg) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2817/update-externallibraries-libjpeg-to -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 10:13:41 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 15:13:41 +0000 Subject: [ET Trac] #2817: update ExternalLibraries-libjpeg to version 9f Message-ID: #2817: update ExternalLibraries-libjpeg to version 9f Reporter: Roland Haas Status: resolved Milestone: Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) Comment (by Roland Haas): Thank you. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2817/update-externallibraries-libjpeg-to -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 12:02:36 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 17:02:36 +0000 Subject: [ET Trac] #2822: work around full paths used by pkg-config in `-l` options Message-ID: #2822: work around full paths used by pkg-config in `-l` options Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Changes (by Roland Haas): title: work around full paths used by pkg-config in `-l` options (was support full paths to libraries in LIBS variables) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/work-around-full-paths-used-by-pkg-config -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 14:31:45 2024 From: trac-noreply at einsteintoolkit.org (Steven R. Brandt) Date: Thu, 05 Sep 2024 19:31:45 +0000 Subject: [ET Trac] #2822: work around full paths used by pkg-config in `-l` options Message-ID: #2822: work around full paths used by pkg-config in `-l` options Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Comment (by Steven R. Brandt): This change looks good? should it be a PR? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2822/work-around-full-paths-used-by-pkg-config -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 14:51:44 2024 From: trac-noreply at einsteintoolkit.org (David Boyer) Date: Thu, 05 Sep 2024 19:51:44 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: new Milestone: Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn TOVola is an enhanced TOV solver that has support of multiple different EOS types \(Simple and Piecewise Polytrope, and **Tabulated EOS**\) through the use of the GRHayLib thorn. It also has access to two different ODE methods through the use of GSL?s ODE solver \(RK4\(5\) and DP7\(8\)\), but more methods can be added in the future if there is a desire, as long as it is a GSL compatible method. ? To be used in the GRHayL announcement paper, currently in prep. ? Here is the github link: [https://github.com/dboyer7/TOVola](https://github.com/dboyer7/TOVola) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 15:46:41 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 20:46:41 +0000 Subject: [ET Trac] #2824: CarpetX documentation file uses extra LaTeX package Message-ID: #2824: CarpetX documentation file uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: minor Component: Using extra packages \(`listing` in this case\) breaks the `-ThornGuide` target which builds a single PDF file with all documentation \([http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-34000B3.3](http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-34000B3.3)\). The only packages that may be used \(and they don?t need a `\usepackage`\) are those already required by `cactus.sty`: ``` $ grep RequirePackage repos/flesh/doc/latex/cactus.sty \RequirePackage[utf8]{inputenc} \RequirePackage{fancyhdr} \RequirePackage{graphicx} \RequirePackage{latexsym} \RequirePackage{amssymb} \RequirePackage{amsmath} \RequirePackage{ifthen} \RequirePackage{calc} \RequirePackage{thumbpdf} \RequirePackage{hyperref} ``` ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2824/carpetx-documentation-file-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 15:48:40 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 20:48:40 +0000 Subject: [ET Trac] #2825: GRHayL documentation files uses extra LaTeX package Message-ID: #2825: GRHayL documentation files uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Using extra packages \(`xspace` in this case\) breaks the `-ThornGuide` target which builds a single PDF file with all documentation \([http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-34000B3.3](http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-34000B3.3)\). The only packages that may be used \(and they don?t need a `\usepackage`\) are those already required by `cactus.sty`: ``` $ grep RequirePackage repos/flesh/doc/latex/cactus.sty \RequirePackage[utf8]{inputenc} \RequirePackage{fancyhdr} \RequirePackage{graphicx} \RequirePackage{latexsym} \RequirePackage{amssymb} \RequirePackage{amsmath} \RequirePackage{ifthen} \RequirePackage{calc} \RequirePackage{thumbpdf} \RequirePackage{hyperref} ``` ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2825/grhayl-documentation-files-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 15:51:27 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 20:51:27 +0000 Subject: [ET Trac] #2826: NRPyEllipticET documentation file uses extra LaTeX package Message-ID: #2826: NRPyEllipticET documentation file uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Using extra packages \(`listing` in this case\) breaks the `-ThornGuide` target which builds a single PDF file with all documentation \([http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-34000B3.3](http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-34000B3.3)\). The only packages that may be used \(and they don?t need a `\usepackage`\) are those already required by `cactus.sty`: ``` $ grep RequirePackage repos/flesh/doc/latex/cactus.sty \RequirePackage[utf8]{inputenc} \RequirePackage{fancyhdr} \RequirePackage{graphicx} \RequirePackage{latexsym} \RequirePackage{amssymb} \RequirePackage{amsmath} \RequirePackage{ifthen} \RequirePackage{calc} \RequirePackage{thumbpdf} \RequirePackage{hyperref} ``` ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2826/nrpyellipticet-documentation-file-uses -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 15:53:18 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 20:53:18 +0000 Subject: [ET Trac] #2826: NRPyEllipticET documentation file uses extra LaTeX package Message-ID: #2826: NRPyEllipticET documentation file uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Also has a new macro `\nrpyell` defined outside of the `% START CACTUS THORNGUIDE` block \(and outside of the `% Add all definitions used in this documentation here` comment. ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2826/nrpyellipticet-documentation-file-uses -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 15:56:18 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 20:56:18 +0000 Subject: [ET Trac] #2825: GRHayL documentation files uses extra LaTeX package Message-ID: #2825: GRHayL documentation files uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Also has a a number of new macros defined outside of the `% START CACTUS THORNGUIDE` block \(and outside of the `% Add all definitions used in this documentation here` comment\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2825/grhayl-documentation-files-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 15:59:47 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 20:59:47 +0000 Subject: [ET Trac] #2827: TwoPunctures_BBHSF defines new macro outside of the "% START CACTUS THORNGUIDE" block Message-ID: #2827: TwoPunctures_BBHSF defines new macro outside of the "% START CACTUS THORNGUIDE" block Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: This breaks that `-ThornGuide` target with ``` ! Undefined control sequence. l.40349 \bracket { \frac{^{(4)}R}{16\pi} - \frac{1}{2} g^{\mu\nu} ? ! Emergency stop. ``` new macros must be defined inside of the magic comments ideally just below the comment `% Add all definitions used in this documentation here` which the documentation template contains. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2827/twopunctures_bbhsf-defines-new-macro -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 5 16:02:45 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 05 Sep 2024 21:02:45 +0000 Subject: [ET Trac] #2828: WVUThorns_Diagnostics defines new macro outside of the "% START CACTUS THORNGUIDE" block Message-ID: #2828: WVUThorns_Diagnostics defines new macro outside of the "% START CACTUS THORNGUIDE" block Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: This breaks that `-ThornGuide` target with ``` ! Undefined control sequence. l.42427 {\bf Title:} & \thornname \\ ? ! Emergency stop. l.42427 ``` new macros must be defined inside of the magic comments ideally just below the comment `% Add all definitions used in this documentation here` which the documentation template contains. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2828/wvuthorns_diagnostics-defines-new-macro -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Sep 6 16:55:59 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 06 Sep 2024 21:55:59 +0000 Subject: [ET Trac] #2824: CarpetX documentation file uses extra LaTeX package Message-ID: #2824: CarpetX documentation file uses extra LaTeX package Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): This patch removes the packages but does suffer from less pretty layout: git hash [337b3f8c](https://github.com/einsteintoolkit/CarpetX/commits/337b3f8c77a0c6629dce9f93a2028366d1359652) "CarpetX: remove tabularx and listings from documentation" of [CarpetX](https://github.com/einsteintoolkit/CarpetX) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2824/carpetx-documentation-file-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Sep 6 16:56:05 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 06 Sep 2024 21:56:05 +0000 Subject: [ET Trac] #2824: CarpetX documentation file uses extra LaTeX package Message-ID: #2824: CarpetX documentation file uses extra LaTeX package Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2824/carpetx-documentation-file-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Sep 6 16:58:01 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Fri, 06 Sep 2024 21:58:01 +0000 Subject: [ET Trac] #2824: CarpetX documentation file uses extra LaTeX package Message-ID: #2824: CarpetX documentation file uses extra LaTeX package Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Changes (by Roland Haas): responsible: [] (was ) assignee: Lucas Timotheo Sanches (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2824/carpetx-documentation-file-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Sep 13 13:11:26 2024 From: trac-noreply at einsteintoolkit.org (Steven R. Brandt) Date: Fri, 13 Sep 2024 18:11:26 +0000 Subject: [ET Trac] #2829: Piraha lookup ref issue Message-ID: #2829: Piraha lookup ref issue Reporter: Steven R. Brandt Status: new Milestone: Version: Type: bug Priority: major Component: Cactus Flesh: Currently, lookup\_var returns a reference to the value of a var. When a unop is called, this has the effect of negating the value in the table. Thus: ``` $zip = 1 foo::xmin = -$zip foo::xmax = $zip ``` This results in both xmin and xmax being set to the same value \(-1\). The fix is to have lookup\_var return a copy rather than a reference. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2829/piraha-lookup-ref-issue -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Fri Sep 13 13:12:23 2024 From: trac-noreply at einsteintoolkit.org (Steven R. Brandt) Date: Fri, 13 Sep 2024 18:12:23 +0000 Subject: [ET Trac] #2829: Piraha lookup ref issue Message-ID: #2829: Piraha lookup ref issue Reporter: Steven R. Brandt Status: new Milestone: Version: Type: bug Priority: major Component: Cactus Comment (by Steven R. Brandt): PR is here: [https://bitbucket.org/cactuscode/cactus/pull-requests/165](https://bitbucket.org/cactuscode/cactus/pull-requests/165) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2829/piraha-lookup-ref-issue -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 17 13:49:05 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 17 Sep 2024 18:49:05 +0000 Subject: [ET Trac] #2829: Piraha lookup ref issue Message-ID: #2829: Piraha lookup ref issue Reporter: Steven R. Brandt Status: new Milestone: Version: Type: bug Priority: major Component: Cactus Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2829/piraha-lookup-ref-issue -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 17 13:49:12 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 17 Sep 2024 18:49:12 +0000 Subject: [ET Trac] #2829: Piraha lookup ref issue Message-ID: #2829: Piraha lookup ref issue Reporter: Steven R. Brandt Status: open Milestone: Version: Type: bug Priority: major Component: Cactus Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2829/piraha-lookup-ref-issue -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 17 13:59:36 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Tue, 17 Sep 2024 18:59:36 +0000 Subject: [ET Trac] #2829: Piraha lookup ref issue Message-ID: #2829: Piraha lookup ref issue Reporter: Steven R. Brandt Status: open Milestone: Version: Type: bug Priority: major Component: Cactus Comment (by Roland Haas): Changes are being requested. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2829/piraha-lookup-ref-issue -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 17 20:19:32 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 18 Sep 2024 01:19:32 +0000 Subject: [ET Trac] #2829: Piraha lookup ref issue Message-ID: #2829: Piraha lookup ref issue Reporter: Steven R. Brandt Status: open Milestone: Version: Type: bug Priority: major Component: Cactus Comment (by Roland Haas): Please apply. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2829/piraha-lookup-ref-issue -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 17 20:34:27 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 18 Sep 2024 01:34:27 +0000 Subject: [ET Trac] #2829: Piraha lookup ref issue Message-ID: #2829: Piraha lookup ref issue Reporter: Steven R. Brandt Status: open Milestone: Version: Type: bug Priority: major Component: Cactus Comment (by Roland Haas): ? Applied as git hash \[ddf3c7ac\]\([https://bitbucket.org/cactuscode/cactus/commits/ddf3c7ac2363d1ef2c75fc1c22e52373e50d6633](https://bitbucket.org/cactuscode/cactus/commits/ddf3c7ac2363d1ef2c75fc1c22e52373e50d6633)\) "Cactus: lookup\_var should return a shared\_ptr, not a shared\_ptr." of \[cactus\]\([https://bitbucket.org/cactuscode/cactus](https://bitbucket.org/cactuscode/cactus) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2829/piraha-lookup-ref-issue -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Tue Sep 17 20:34:48 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 18 Sep 2024 01:34:48 +0000 Subject: [ET Trac] #2829: Piraha lookup ref issue Message-ID: #2829: Piraha lookup ref issue Reporter: Steven R. Brandt Status: resolved Milestone: Version: Type: bug Priority: major Component: Cactus Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2829/piraha-lookup-ref-issue -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Sep 18 09:28:28 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 18 Sep 2024 14:28:28 +0000 Subject: [ET Trac] #2813: Allow CarpetX to implement Driver. Message-ID: #2813: Allow CarpetX to implement Driver. Reporter: Steven R. Brandt Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [4aafc0ac](https://github.com/einsteintoolkit/CarpetX/commits/4aafc0ac2cbf859e9356b3c3c371ebc5321301b8) "CarpetX: Change the implementation to Driver" of [CarpetX](https://github.com/einsteintoolkit/CarpetX) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-implement-driver -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Wed Sep 18 09:28:44 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Wed, 18 Sep 2024 14:28:44 +0000 Subject: [ET Trac] #2813: Allow CarpetX to implement Driver. Message-ID: #2813: Allow CarpetX to implement Driver. Reporter: Steven R. Brandt Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-implement-driver -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 19 09:20:02 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 19 Sep 2024 14:20:02 +0000 Subject: [ET Trac] #2824: CarpetX documentation file uses extra LaTeX package Message-ID: #2824: CarpetX documentation file uses extra LaTeX package Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): In today?s ET call it was decided to add `lstlistings` to the default Cactus packages if possible \(ie if included in ?base? typical LaTeX installation on macOS and Linux and if ok for the TeX to HTML conversion\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2824/carpetx-documentation-file-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 26 09:14:45 2024 From: trac-noreply at einsteintoolkit.org (Lucas Timotheo Sanches) Date: Thu, 26 Sep 2024 14:14:45 +0000 Subject: [ET Trac] #2824: CarpetX documentation file uses extra LaTeX package Message-ID: #2824: CarpetX documentation file uses extra LaTeX package Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: minor Component: Comment (by Lucas Timotheo Sanches): I report that the package `listings.sty`, which provides the `lstlistings` environment _**IS** present on the_ `texlive-base` package of Ubuntu?s latest release. See [here](https://launchpad.net/ubuntu/+source/texlive-base). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2824/carpetx-documentation-file-uses-extra -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 26 09:29:58 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 26 Sep 2024 14:29:58 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: new Milestone: Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): responsible: [] (was ) assignee: Maxwell Rizzo (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 26 09:31:14 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 26 Sep 2024 14:31:14 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: new Milestone: Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Useful notes for reviewers and contributors: [https://docs.einsteintoolkit.org/et-docs/How\_to\_Review\_a\_new\_component](https://docs.einsteintoolkit.org/et-docs/How_to_Review_a_new_component) Quality measures: [http://einsteintoolkit.org/contribute.html](http://einsteintoolkit.org/contribute.html) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 26 09:32:45 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 26 Sep 2024 14:32:45 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: new Milestone: ET_2024_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): milestone: ET_2024_11 (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 26 09:32:51 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 26 Sep 2024 14:32:51 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: open Milestone: ET_2024_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 26 09:34:20 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 26 Sep 2024 14:34:20 +0000 Subject: [ET Trac] #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Message-ID: #2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support Reporter: David Boyer Status: open Milestone: ET_2024_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): @{712020:002d68cb-a9e4-45eb-9433-93bf55a13168} will review -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with -------------- next part -------------- An HTML attachment was scrubbed... URL: From trac-noreply at einsteintoolkit.org Thu Sep 26 09:35:13 2024 From: trac-noreply at einsteintoolkit.org (Roland Haas) Date: Thu, 26 Sep 2024 14:35:13 +0000 Subject: [ET Trac] #2748: Inclusion of Z4c in Einstein Toolkit Message-ID: #2748: Inclusion of Z4c in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2024_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): @{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} will review Currently test cases are missing. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2748/inclusion-of-z4c-in-einstein-toolkit -------------- next part -------------- An HTML attachment was scrubbed... URL: