<html>#1974: Add WVUThorns_Diagnostics to the ET
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Zach Etienne</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2018_08</td></tr>
<tr><td style='text-align:right'> Version:</td><td>development version</td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>minor</td></tr>
<tr><td style='text-align:right'>Component:</td><td>Other</td></tr>
</table>
<p>Comment (by Steven R. Brandt):</p>
<p>This arrangement has about 2k lines of code. Now that tests are available, I'm in favor of adding it.</p>
<p>One problem I have with the code is that it makes use of the c-preprocessor when C++ offers better ways of doing things. I've created a pull request with a suggested refactoring: <a href="https://bitbucket.org/zach_etienne/wvuthorns_diagnostics/pull-requests/1/avoid-using-the-c-preprocessor-to-define/diff" rel="nofollow" class="ap-connect-link">https://bitbucket.org/zach_etienne/wvuthorns_diagnostics/pull-requests/1/avoid-using-the-c-preprocessor-to-define/diff</a></p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/1974/add-wvuthorns_diagnostics-to-the-et'>https://bitbucket.org/einsteintoolkit/tickets/issues/1974/add-wvuthorns_diagnostics-to-the-et</a></p>
</html>