<html>#1974: Add WVUThorns_Diagnostics to the ET
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Zach Etienne</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2018_08</td></tr>
<tr><td style='text-align:right'> Version:</td><td>development version</td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>minor</td></tr>
<tr><td style='text-align:right'>Component:</td><td>Other</td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>To further add to the confusion, for C code (but the affected code in VolumeIntegrals_vacuum is C++), we seem to rely on the old pre-C99 behaviour of <code>inline</code> which <em>would</em> make <code>inline</code> appear externally as well (and then <em>should</em> complain about multiply defined symbols). See <a href="https://bitbucket.org/einsteintoolkit/tickets/issues/484/cctk_check_c_inline-can-define-away-the" rel="nofollow" class="ap-connect-link">https://bitbucket.org/einsteintoolkit/tickets/issues/484/cctk_check_c_inline-can-define-away-the</a> . The safest solution is most likely to always declare an inline functions as <code>static inline</code> which agrees between old and new usage.</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/1974/add-wvuthorns_diagnostics-to-the-et'>https://bitbucket.org/einsteintoolkit/tickets/issues/1974/add-wvuthorns_diagnostics-to-the-et</a></p>
</html>