<html>#2257: Piraha return in wrong place
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Steven R. Brandt</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>Cactus</td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>Looks mostly fine with me. Please apply. An actual pull request would have been nice though since it would have made it easier to inspect the code and verify the code in context.</p>
<p>For example the lower bound of the loop is somewhat off since the loop starts from 1 so the first <code>val_next</code> inspected is <code>gr->group(1)</code> which has already been assigned to <code>val</code> befor in <code>val = meval(gr->group(1),eedata)</code>. This does not lead to incorrect results (since <code>min(a,a) = a</code>) but is a bit odd.</p>
<p>The test change is good to apply as well because, while it does remove a test for assigning a simple float to a parameter, there is another such assignment in</p>
<div class="codehilite"><pre><span></span>TestPar::real1[2] = 42.
</pre></div>
<p>ideally the tests would also include a call of <code>min(42.)</code> ie a single argument to min or max.</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2257/piraha-return-in-wrong-place'>https://bitbucket.org/einsteintoolkit/tickets/issues/2257/piraha-return-in-wrong-place</a></p>
</html>