<html>#2286: Add the Fishbone-Moncrief initial data thorn to the ET
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Steven R. Brandt</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2019_10</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>I peeked at the code and it is using <code>drand48()</code> in an omp parallel section. However looking at "man drand48" it says that <code>drand48</code> is not thread safe "MT-Unsafe race:drand48" so this seems wrong to use in a multi-threaded section.</p>
<p><code>drand48()</code> is POSIX 2001 which Cactus technically does not require (it also requires a C99 compiler which we do not specifically point out and POSIX 2001 would seem to be 18 years old by now so should exist everywhere).</p>
<p>The README file should be closer to Cactus default so that it can be parsed for eg author, maintainer and license information.</p>
<p>Should not user <code>printf()</code> but instead <a data-is-external-link="true" href="https://www.einsteintoolkit.org/referencemanual/ReferenceManualch2.html#x4-221000A2" rel="nofollow">CCTK_VINFO()</a> so that output can be controlled by Cactus.</p>
<p>ID thorns are expected to only set ID for metric/gauge/hydro variables if the respective ADMBase / HydroBase variables are set to their registered parameter value (I do not know on top of my head the fraction of ID thorns that actually do so, <code>TOVSolver</code>, which to some degree is the prototypical ID thorn, does do so).</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2286/add-the-fishbone-moncrief-initial-data'>https://bitbucket.org/einsteintoolkit/tickets/issues/2286/add-the-fishbone-moncrief-initial-data</a></p>
</html>