<html>#1276: Intel 2013.1.117 mis-compiles NewRad
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Roland Haas</td></tr>
<tr><td style='text-align:right'> Status:</td><td>resolved</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td>development version</td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>minor</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Changes (by Roland Haas):</p>
<p><table>
<tr><td>status:</td><td>resolved (was open)</td></tr>
</table></p>
<p>Intels compiler fails (with -O2) to push values for bmin onto the stack in lines 316 of newrad.cc and line 126 of extrap.cc. Adding printf's for bmin perturbs the bug out of existence, but adding a printf of the address of bmax and reveals that at the time extrap_kernel is call the integer just before this address is still the initialization value of bmin[2] and not the correct value.</p>
<p>The attached patch disables optimization for the two driver functions affected (but not the actual kernel).</p>
<p>The patch is specific (via an #if) for this particular compiler and version. What is the best way of handling this? Target any intel version starting from the known failing one until we know of known good one? Or starting from an older known good one (that would be intel 11 in my case).</p>
<p>Hopefully no similar bug is triggered by Carpet's use of the same idiom.</p>
<p><strong>Keyword:</strong> NewRad</p>
<p>Comment (by Roland Haas):</p>
<p>Applied as git hash <a data-is-external-link="true" href="https://bitbucket.org/cactuscode/cactus/commits/c754548935dbfc046b880200b95d067d2d8b4f31" rel="nofollow">c7545489</a> "Cactus: regenerate configure" of <a data-is-external-link="true" href="https://bitbucket.org/cactuscode/cactus" rel="nofollow">cactus</a></p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/1276/intel-20131117-mis-compiles-newrad'>https://bitbucket.org/einsteintoolkit/tickets/issues/1276/intel-20131117-mis-compiles-newrad</a></p>
</html>