<html>#1382: Cactus should disable collapse sections automatically for C _and_ Fortran
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Frank Löffler</td></tr>
<tr><td style='text-align:right'> Status:</td><td>resolved</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td>ET_2013_05</td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>minor</td></tr>
<tr><td style='text-align:right'>Component:</td><td>Cactus</td></tr>
</table>
<p>Changes (by Roland Haas):</p>
<p><table>
<tr><td>status:</td><td>resolved (was open)</td></tr>
</table></p>
<p>Currently, Cactus disables OpenMP collapse due to compiler problems either when specified explicitly in the option list, or when finding certain compilers that are known to have this kind of problem. However, the latter is only done for C and C++, but not Fortran. In addition, Cactus aborts compilation if collapse is not explicitly disabled, but affected compilers are found, with a message that collapse is disabled for C, but not for Fortran, indicating an error in the option list. While the first is true since Cactus actually disabled the collapse sections because it found a faulty compiler, the latter is not, since the option list doesn't mention collapse sections at all and isn't inconsistent.</p>
<p>This means in the end that the auto-detections isn't really working in the way that is was intended: that Cactus does things automatically if faulty compilers are found. Instead, Cactus currently aborts, with a message that isn't leading users in the right direction. A workaround right now is to define CCTK_DISABLE_OMP_COLLAPSE for both C and Fortran in the option list.</p>
<p>The proposed patch removes this error message, and instead adds the same compiler-detection for Fortran, that is already present for C and C++. The advantage would be that option lists wouldn't need to define anything. Cactus would either disable the collapse sections for all languages, or for none.</p>
<p>If accepted, I propose to backport this change, in addition to applying it to the development version. The patch was created using ET_2013_05.</p>
<p><strong>Keyword:</strong> openmp<br />
<strong>Keyword:</strong> flesh<br />
<strong>Keyword:</strong> ET_2013_05</p>
<p>Comment (by Roland Haas):</p>
<p>Applied as git hash <a data-is-external-link="true" href="https://bitbucket.org/cactuscode/cactus/commits/ebfb70a5c4ccba110ad49fff714d7e3f22f09ab6" rel="nofollow">ebfb70a5</a> "Cactus: regenerate configure" of <a data-is-external-link="true" href="https://bitbucket.org/cactuscode/cactus" rel="nofollow">cactus</a></p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/1382/cactus-should-disable-collapse-sections'>https://bitbucket.org/einsteintoolkit/tickets/issues/1382/cactus-should-disable-collapse-sections</a></p>
</html>