<html>#2331: piraha accepts in-string comments on first line of string
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Roland Haas</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>Cactus</td></tr>
</table>
<p>Cactus' parameter files allow things like:</p>
<div class="codehilite"><pre><span></span>ActiveThorns = "
# PUGH
Carpet
HydroBase
"
</pre></div>
<p>ie allow one to comment out lines in a multi-line string by starting it with a “#”. However Piraha does not quite handle this correctly. It accepts</p>
<div class="codehilite"><pre><span></span>ActiveThorns = "#FooBar"
</pre></div>
<p>which is incorrect. <code>#</code> comments are supposed to be only allowed in lines <em>after</em> the first line. The original commit git hash <a data-is-external-link="true" href="https://bitbucket.org/cactuscode/cactus/commits/b6cd766ac46285af393034bcc390a4841a597e20" rel="nofollow">b6cd766a</a> "Accept comments in multi-line strings in parameter files" of <a data-is-external-link="true" href="https://bitbucket.org/cactuscode/cactus" rel="nofollow">cactus</a> does this but piraha’s <code>string_reparser</code> function (bad name) does not.</p>
<p>This makes it impossible to set a string to “#” eg if one wanted to let a user specify a comment character for output files.</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2331/piraha-accepts-in-string-comments-on-first'>https://bitbucket.org/einsteintoolkit/tickets/issues/2331/piraha-accepts-in-string-comments-on-first</a></p>
</html>