<html>#2300: Update: Add Piecewise Polytrope EoS Support to IllinoisGRMHD, Improved TOV Solver?
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Zach Etienne</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2020_04</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>At this point, in IllinoisGRMHD, while I have not fully dug down into the code it seems that the changes do no more harm that usual development for new features. Ie I can see that there may be roundoff / truncation level differences due to updated equations, there is nothing that obviously will break things.</p>
<p>Comments:</p>
<ul>
<li>instead of hand-crafting parallelism in <code>generate_IllinoisGRMHD_from_ipynb_files.sh</code> it may be better to provide a makefile. Note that the current script likely does not what you expect it does. Namely “wait” waits for <em>all</em> child processes to finish no <em>any</em>. “Proper” parallelism could be achieved by using (GNU) xargs' <code>-P</code> option, though make seems preferable to me.</li>
<li><code>generate_IllinoisGRMHD_from_ipynb_files.sh</code> modifies the input notebooks (in the sed line). It really should not do so.</li>
<li>Currently removing the output thorn directories <code>Convert_to_HydroBase</code> and <code>ID_converter_ILGRMHD</code> and running <code>generate_IllinoisGRMHD_from_ipynb_files.sh</code> does not regenerate all files, ie. there are hand-written files mixed in with the auto-generated ones (license, README, documentation.tex). It would be better if this was not done.</li>
<li>A duplicate of the notebook is included in the thorn’s doc directory and that duplicate is not auto-generated. This will lead to inconsistencies and should be avoided.</li>
<li><code>generate_illinoisgrmhd_from_ipynb_files.sh</code> only generated <code>Convert_to_HydroBase</code> and <code>ID_converter_ILGRMHD</code> but not the actual <code>IllinoisGRMHD</code> thorn. Update after call: I now see where they are generated.</li>
<li>Some places significantly (and to me surprisingly) simplify the code eg:</li>
</ul>
<div class="codehilite language-c"><pre><span></span><span class="k">static</span> <span class="n">CCTK_REAL</span> <span class="nf">pressure_rho0_w</span><span class="p">(</span><span class="n">CCTK_REAL</span> <span class="n">rho0</span><span cla
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2300/update-add-piecewise-polytrope-eos-support'>https://bitbucket.org/einsteintoolkit/tickets/issues/2300/update-add-piecewise-polytrope-eos-support</a></p>
</html>