<html>#2300: Update: Add Piecewise Polytrope EoS Support to IllinoisGRMHD, Improved TOV Solver?
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Zach Etienne</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2020_04</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>Unfortunately even requiring a trivial modification is not acceptable. This is partially due to what is trivial tending to depend to be on the level of experience a user has with the code in question, ranging from the author, for whom everything is trivial, to someone trying to run a gallery parfile or example parfile from the web, for whom nothing is trivial.</p>
<p>An acceptable way would be the following:</p>
<ul>
<li>Re-add the parameters</li>
<li>In this release introduce an additional parameter “eos_params_from_illgrmhd” to <code>ID_converter_ILGRMHD</code> which must default to “false”. Have <code>ID_converter_ILGRMHD</code> use either its own parameter value or ILGRMHD’s values depending on the value of this new parameter</li>
<li>in the 2020_04 release mark this new parameter and the two that were removed as “deprecated”</li>
<li>in the 2020_10 release remove all three deprecated parameters as well as the extra code</li>
</ul>
<p>To retire <code>ID_converter_ILGRMHD</code> it also needs to be deprecated for one release. Note that we typically retire code only once it no longer functions, not when it is not longer considered interesting, both to allow very old parfiles to run and also since we never quite know what the ET community is still using.</p>
<p>As far as I can tell there is no way to put the parameters back in and warn a user about them not be supported anymore (b/c one cannot change the default values and must accept runs with the default values for only one of the pair of corresponding parameters).</p>
<p>Policy on retiring functionality is outlined on the wiki: <a data-is-external-link="true" href="https://docs.einsteintoolkit.org/et-docs/Policies_to_retire_functionality" rel="nofollow">https://docs.einsteintoolkit.org/et-docs/Policies_to_retire_functionality</a></p>
<p>Thorns and parameters probably should not stay deprecated for very long before being removed (ie don’t just mark everything as deprecated to get a blank cheque on removing anything anytime) but given <a data-is-external-lin
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2300/update-add-piecewise-polytrope-eos-support'>https://bitbucket.org/einsteintoolkit/tickets/issues/2300/update-add-piecewise-polytrope-eos-support</a></p>
</html>