<html>#2299: Proposal: Add BaikalETK to the Toolkit
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Zach Etienne</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2020_05</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>Comment (by helvi witek):</p>
<p>[Zach’s response]</p>
<p>Hi Helvi and Roland.</p>
<p>Here is my response on the Baikal ETK thorns "Baikal" and "BaikalVacuum".</p>
<p>Thanks again Helvi for this amazing review. The Baikal ETK thorns are much better as a result! I believe I have completed all requested changes and made all appropriate fixes. Please see comments below.</p>
<div class="codehilite"><pre><span></span>Report on Baikal ETK (13 May 2020)
--------------------------------
- Two thorns "Baikal" (Einstein's equations coupled to Tmn) and "BaikalVacuum" (Einstein's equations in vacuum)
- very clean and readable implementation, both the the jupyter notebook and the auto-generated code.
- exceptionally well documented
- benchmarked against McLachlan (and Lean test is underway): reproduces standard qc0 run (BBH with 1 orbit before merger)
BaikalVacuum (15 May 2020):
---------------
- same comments as above, except for schedule.ccl (BSSN->ADM conversion seems correct)
</pre></div>
<p>Yep, see responses to Baikal.</p>
<div class="codehilite"><pre><span></span>- you might consider adding a documenting notebook that you used to generate the vacuum code (similar to the "doc" folder in Baikal)
</pre></div>
<p>Both thorns are generated using the same notebook, simultaneously. Regardless this is a good point (BaikalVacuum currently has no doc directory), so I added documentation.tex files along the lines Roland suggested (include a short description and links to the full documentation).</p>
<div class="codehilite"><pre><span></span>- [OK] in "par": what is difference between bench-qc0-...par and qc0-...par?
</pre></div>
<p>bench-* is for benchmarking purposes only; it only outputs to a bare minimum of files to avoid file I/O from causing noisy benchmarks. qc0-*.par is for science, outputting all the usual diagnostics files.</p>
<div class="codehilite"><pre><span></span>- [OK] example parameter files do not use symmetry? Why? not implemented or not used?
</pre></div>
<p>Symmetries aren't yet
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2299/proposal-add-baikaletk-to-the-toolkit'>https://bitbucket.org/einsteintoolkit/tickets/issues/2299/proposal-add-baikaletk-to-the-toolkit</a></p>
</html>