<html>#2299: Proposal: Add BaikalETK to the Toolkit
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Zach Etienne</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2020_05</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>Comment (by helvi witek):</p>
<h2 id="markdown-header-updated-report-response-to-zachs-response-4018-may-202041">Updated report -- response to Zach's response (18 May 2020)</h2>
<p>SUMMARY: All my comments have been addressed and corrected. So, I'm giving my OK to include the code.</p>
<p>**** BaikalVacuum<br />
** Yep, see responses to Baikal.</p>
<p>HW: OK</p>
<p></p>
<p>** Both thorns are generated using the same notebook, simultaneously. Regardless this is a good point<br />
** (BaikalVacuum currently has no doc directory), so I added documentation.tex files along the lines<br />
** Roland suggested (include a short description and links to the full documentation).</p>
<p>HW: OK</p>
<p>** bench-* is for benchmarking purposes only; it only outputs to a bare minimum of files to avoid<br />
** file I/O from causing noisy benchmarks. qc0-*.par is for science, outputting all the usual diagnostics files.</p>
<p>HW: that's what I guessed. It may be worthwhile noting this in the script or README.</p>
<p>** Symmetries aren't yet fully tested so I cannot vouch that they are 100% functional.<br />
** I have added documentation to this effect in the thorns' doc/documentation.tex files.</p>
<p>HW: OK</p>
<p></p>
<p>**** NRPy+ Jupyter notebook (15 May 2020)</p>
<p>** These links work fine in the live Jupyter session, and point to a syntax-highlighed (editable) version of the Python file.<br />
** Indeed in the read-only nbviewer (<a data-is-external-link="true" href="https://nbviewer.jupyter.org/github/zachetienne/nrpytutorial/blob/master/Tutorial-BaikalETK.ipynb" rel="nofollow">https://nbviewer.jupyter.org/github/zachetienne/nrpytutorial/blob/master/Tutorial-BaikalETK.ipynb),</a>,)<br />
** the editor is disabled and the user will find a 404 error instead. I updated the links to just open the files as read-only text files<br />
** (without syntax highlighting, oh well).</p>
<p>HW: OK</p>
<p></p>
<p>** This is how we enforce trA=0. I have added comments to this effect to the BSSN_RHSs tutorial, with an equation reference to Brown 2009:<br />
*
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2299/proposal-add-baikaletk-to-the-toolkit'>https://bitbucket.org/einsteintoolkit/tickets/issues/2299/proposal-add-baikaletk-to-the-toolkit</a></p>
</html>