<html>#2398: Multipole: Default (midpoint) integration method incorrectly implemented, yielding wrong results... especially with m=odd modes
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Zach Etienne</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Zach Etienne):</p>
<p>Here is my proposed patch for the upcoming release branch, which replaces the default integration with trapezoidal. I checked the test/ directory, and all parfiles select the integration_method explicitly, so no patch should be needed for those.</p>
<div class="codehilite language-python"><pre><span></span><span class="n">diff</span> <span class="o">--</span><span class="n">git</span> <span class="n">a</span><span class="o">/</span><span class="n">Multipole</span><span class="o">/</span><span class="n">param</span><span class="o">.</span><span class="n">ccl</span> <span class="n">b</span><span class="o">/</span><span class="n">Multipole</span><span class="o">/</span><span class="n">param</span><span class="o">.</span><span class="n">ccl</span>
<span class="n">index</span> <span class="n">b2ac27e5</span><span class="o">..</span><span class="mf">8125e48</span><span class="n">c</span> <span class="mi">100644</span>
<span class="o">---</span> <span class="n">a</span><span class="o">/</span><span class="n">Multipole</span><span class="o">/</span><span class="n">param</span><span class="o">.</span><span class="n">ccl</span>
<span class="o">+++</span> <span class="n">b</span><span class="o">/</span><span class="n">Multipole</span><span class="o">/</span><span class="n">param</span><span class="o">.</span><span class="n">ccl</span>
<span class="err">@@</span> <span class="o">-</span><span class="mi">25</span><span class="p">,</span><span class="mi">11</span> <span class="o">+</span><span class="mi">25</span><span class="p">,</span><span class="mi">11</span> <span class="err">@@</span> <span class="n">CCTK_STRING</span> <span class="n">coord_system</span> <span class="s2">"What is the coord system?"</span>
<span class="n">KEYWORD</span> <span class="n">integration_method</span> <span class="s2">"How to do surface integrals"</span> <span class="n">STEERABLE</span><span class="o">=</span><span class="n">always</span>
<span class="p">{</span>
<span class="o">-</span> <span class="s2">"midpoint
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2398/multipole-default-midpoint-integration'>https://bitbucket.org/einsteintoolkit/tickets/issues/2398/multipole-default-midpoint-integration</a></p>
</html>