<html>#2368: Instabilities with Summation by Parts thorn 4th order operator
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Miguel Zilhão</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by User e6f22):</p>
<p>Looking at the pull request and based on discussion in today’s ET call, I have the following review comments:</p>
<ul>
<li>since now the <code>if</code> and <code>else</code> branches of the 2nd derivatives are indentical, I would remove the if statement and replace it by a comment. Usually I would suggest replacing it by a check that the passed option is either “minimal bandwidth” or “optimal” choice for the operators, however the current code already does “minimal bandwith” or “other” so there seems little point of adding such a check now.</li>
<li>I would advocate removing the now dead code from the repository, anyone who needs it can get it back from the version control system</li>
<li>I would check that the documentation is updated if it mentioned the existence of an “optimal” 2nd derivative operators</li>
</ul>
<p>Fine to apply otherwise.</p>
<p></p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2368/instabilities-with-summation-by-parts'>https://bitbucket.org/einsteintoolkit/tickets/issues/2368/instabilities-with-summation-by-parts</a></p>
</html>