<html>#2425: param.ccl code creators creates incorrect C code if parameter description is missing
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Roland Haas</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>Cactus</td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>Technically I reported that CST does not complain and instead generates code that does not compile. </p>
<p>Thank you. This patch seems to work for me.</p>
<p>I had a look what the corresponding error message in the pre-piraha parser looked like (around line 419 of <code>parameters_parser.pl</code>):</p>
<div class="codehilite language-perl"><pre><span></span><span class="o">&</span><span class="n">CST_error</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span class="s">"Missing description for parameter $variable in "</span> <span class="o">.</span>
<span class="s">"param.ccl for thorn $thorn."</span><span class="p">,</span>
<span class="s">"The first line of each parameter definition must have "</span> <span class="o">.</span>
<span class="s">"the syntax <TYPE> <NAME> <\"DESCRIPTION\">"</span><span class="p">,</span>
<span class="n">__LINE__</span><span class="p">,</span> <span class="n">__FILE__</span><span class="p">);</span>
</pre></div>
<p>and would like to suggest to use that text to address this regression (mostly for the hint, the error message text is almost identical). However I would also suggest retaining <code>$guts->linenum(), $ccl_file</code> that the patch has instead of reverting to <code>__LINE__, __FILE__</code> which, as far as I can tell would give line number and file name of the Perl script which is (much) less useful than the file name and line number of the <code>param.ccl</code> file.</p>
<p>Please apply.</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2425/paramccl-code-creators-creates-incorrect-c'>https://bitbucket.org/einsteintoolkit/tickets/issues/2425/paramccl-code-creators-creates-incorrect-c</a></p>
</html>