<html>#2446: Cactus: New cGH fields tile_min, tile_max
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Erik Schnetter</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>proposal</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>Cactus</td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>I am afraid this may require more work. Sorry for the piecemeal review (though some of the comments were present before):</p>
<ul>
<li>this changes the <code>omp single</code>clause by removing the <code>copyprivate(cctki3_bndsize, cctki3_is_physbnd)</code> which will leave <code>cctki3_bndsize</code> uninitialized in the threads that do not execute the single clause it seems since those arrays are automatic, private variables. They could be made static though it seems, which hopefully won’t make them <code>threadprivate</code>.</li>
<li>the prototype of <code>GetBoundarySizesAndTypes</code> should not be duplicated. Thorns using <code>CCTK_LOOPX_INT</code> must themselves <code>USE</code> or <code>REQUIRE</code> the aliased function at which point a prototype will be available when the macro is expanded</li>
<li>
<p>the </p>
<p>```c</p>
<h1 id="markdown-header-else">else</h1>
<h1 id="markdown-header-define-cctk_loop_tile_mincctkgh-d-0">define CCTK_LOOP_TILE_MIN(cctkGH, d) 0</h1>
<h1 id="markdown-header-define-cctk_loop_tile_maxcctkgh-d-cctkgh-cctk_lshd">define CCTK_LOOP_TILE_MAX(cctkGH, d) (cctkGH)->cctk_lsh[d]</h1>
<p><code>``
* does not seem to be required since both</code>cctk_Loop.h<code>and</code>cctk_GroupsOnGH.h` are in the same repository so will be kept in sync by git
* no support for Fortran is provided (F90 is still in use, see <a data-is-external-link="true" href="http://lists.einsteintoolkit.org/pipermail/users/2020-February/007298.html" rel="nofollow">http://lists.einsteintoolkit.org/pipermail/users/2020-February/007298.html</a>) </p>
</li>
</ul>
<p></p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2446/cactus-new-cgh-fields-tile_min-tile_max'>https://bitbucket.org/einsteintoolkit/tickets/issues/2446/cactus-new-cgh-fields-tile_min-tile_max</a></p>
</html>