<html>#2369: PreSync circumvents scoping of Cactus grid functions for C/C++ functions.
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Steven R. Brandt</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2020_11</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>Comment (by Steven R. Brandt):</p>
<p>So the only thing that needs to be done here is convert warnings to errors. Correct?</p>
<div class="codehilite"><pre><span></span><span class="gh">diff --git a/lib/sbin/rdwr.pl b/lib/sbin/rdwr.pl</span>
<span class="gh">index 24b3cf12..e1be427c 100644</span>
<span class="gd">--- a/lib/sbin/rdwr.pl</span>
<span class="gi">+++ b/lib/sbin/rdwr.pl</span>
<span class="gu">@@ -527,7 +527,7 @@ sub create_macros</span>
$hint = "Check variable or group '${th}::$full_var' and verify ".
"correct implementation/thorn name and variable name.'";
}
<span class="gd">- &CST_error(1, "Error in read/write declaration of '${th}::$full_var' for '$nm' in schedule."</span>
<span class="gi">+ &CST_error(0, "Error in read/write declaration of '${th}::$full_var' for '$nm' in schedule."</span>
,$hint, $errline, $ccl_file);
next;
}
<span class="gu">@@ -536,7 +536,7 @@ sub create_macros</span>
# the variable type...
if($vtype eq "CCTK_") {
my $hint = "Bad variable group name '$full_var' at $errline";
<span class="gd">- &CST_error(1, "Error in read/write declaration $nm schedule. Check variable or group '$full_var'" .</span>
<span class="gi">+ &CST_error(0, "Error in read/write declaration $nm schedule. Check variable or group '$full_var'" .</span>
' and verify correct implementation/thorn name and variable name.'
,$hint, $errline, $ccl_file);
next;
<span class="gu">@@ -569,7 +569,7 @@ sub create_macros</span>
if(!defined($decls->{$full_var})) {
my $line = $reads_writes->{$namekey}->{$th}->{$full_var}->{line};
my $hint = "Check access of variable. M
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2369/presync-circumvents-scoping-of-cactus-grid'>https://bitbucket.org/einsteintoolkit/tickets/issues/2369/presync-circumvents-scoping-of-cactus-grid</a></p>
</html>