<html>#2492: h5check fails to build
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td></td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2020_05</td></tr>
<tr><td style='text-align:right'> Version:</td><td>ET_2020_05</td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>blocker</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>Ok, that explains it then. I have adapted your fix and pushed it as git hash <a data-is-external-link="true" href="https://github.com/einsteintoolkit/ExternalLibraries-HDF5/commits/7090973a7d413f549fce0529ba6e537004011b18" rel="nofollow">7090973</a> "HDF5: make h5check compile even if _GNU_SOURCE is defined" of <a data-is-external-link="true" href="https://github.com/einsteintoolkit/ExternalLibraries-HDF5" rel="nofollow">ExternalLibraries-HDF5</a></p>
<p>I cannot find where <code>_GNU_SOURCE</code> shows up in the docs or tutorials either, but it is used in a couple of simfactory option lists (which all use a system compiled HDF5 library) so having the fix is a good idea anyway just in case we ever need to build our own HDF5 library on those machines.</p>
<p>You already seem to have a workaround, alternatively I would have suggested compiling without <code>-D_GNU_SOURCE</code> which ought not be required, in particular if you already use <code>-std=gnuc11</code> and <code>-std=gnu++11</code> anyway.</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2492/h5check-fails-to-build'>https://bitbucket.org/einsteintoolkit/tickets/issues/2492/h5check-fails-to-build</a></p>
</html>