<html>#2526: McLachlan has incorrect READ declarations for presync.
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Peter Diener</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2021_05</td></tr>
<tr><td style='text-align:right'> Version:</td><td>development version</td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>The <code>READS</code> generation is somewhat related to using Tmunu in expression as of commit hash <a data-is-external-link="true" href="https://github.com/ianhinder/Kranc/commits/e69182cf0e78e4120d6d3e518883037f9fde9eb5" rel="nofollow">e69182c</a> "generate READS statement for stress_energy_state if needed" of <a data-is-external-link="true" href="https://github.com/ianhinder/Kranc" rel="nofollow">Kranc</a> which is in ET_2020_05_v0.</p>
<p>While that commit does <em>not</em> produce <code>READS: TmunuBase:eTxx</code> it queries the <code>RequireGroups</code> variable for their presence and that variable is the one used to generate the <code>READS</code> and itself generates a <code>READS: TmunuBase::stress_energy_state</code>. Meaning: if there is a <code>READS: TmunuBase::stress_energy_state</code> then <code>RequireGroups</code> contained TmunuBase variables and <code>READS</code> for them will be generated. This seems to be what happens for ML_BSSN_ADMBaseEverywhere.</p>
<p>That commit (once one ignores whitespace changes and putting code in a <code>Module</code>) adds:</p>
<div class="codehilite"><pre><span></span><span class="c">(* must match list in CodeGenCalculation.m *)</span><span class="w"></span>
<span class="n">ignoreGroups</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="p">{</span><span class="s">"TmunuBase::eTtt"</span><span class="p">,</span><span class="w"> </span><span class="s">"TmunuBase::eTxx"</span><span class="p">,</span><span class="w"> </span><span class="s">"TmunuBase::eTxy"</span><span class="p">,</span><span class="w"></span>
<span class="w"> </span><span class="s">"TmunuBase::eTxz"</span><span class="p">,</span><span class="w"> </span><span class="s">"TmunuBase::eTyy"</span><span class="p">,</span><span class="w"> </span><span class="s">"TmunuBase::eTyz"</span><span class="p">,</span><span class="w"></span>
<span class="w"> </span><span class="s"
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2526/mclachlan-has-incorrect-read-declarations'>https://bitbucket.org/einsteintoolkit/tickets/issues/2526/mclachlan-has-incorrect-read-declarations</a></p>
</html>