<html>#2485: include complex and real scalar evolution code from Canuda in ET
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Roland Haas</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>task</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>Comment (by 池田大志):</p>
<p>Hi, I checked the thorn, and I have several comments. Now, there is not test case, my comment is only about code now. Since I am checking development branch, the line and file name are based on development branch.</p>
<hr>
<p>In ScalarBase, </p>
<ul>
<li>
<p>In line 16th in param.ccl in ScalarBase, we should add absolute value for phi.</p>
</li>
<li>
<p>The description of parameters lEF and mEF in param.ccl is misleading. Current version supports only (lEF,mEF)=(0,0), (1,1), (2,2) and not (1,0),(2,0), (2,1). (see 68th line in Scalar_rhs_forcing.F90)</p>
</li>
<li>
<p>Is there information about external force as document ? I can not find it.</p>
</li>
</ul>
<hr>
<p>In ScalarEvolve,</p>
<ul>
<li>
<p>In ScalarEvolve, why BSSN-like variables are public ? Since same name variables are used in other thorn (like lean_public) and they are just auxiliary field to calculate rhs of the equations, private is better for them.</p>
</li>
<li>
<p>In Scalar_calc_Tmunu.F90, in Scalar_calc_Tmunu, xx and rr should be private in OpenMP in grid loop.</p>
</li>
<li>
<p>In current version, in Scalar_calc_Tmunu, "compute_fluxes==1" and "use_jacobian=false" is not available....Should we add the comments in param file ? </p>
</li>
<li>
<p>In Scalar_ord4_calc_rhs.F90, line 638th and 639th (def sn1 and sn2) can be outside grid loop ? or should the excision procedure be separated as independent thorn ?</p>
</li>
<li>
<p>Also, Rout_excision1, Rout_excision2, Rin_excision1, Rin_excision2 can be outside grid loop ?</p>
</li>
<li>
<p>In schedule, flux grid function is allocated, and Scalar_zero_densities is called when compute_fluxes is true. But, in Scalar_zero_densities, flux grid functions are initialized only when use_jacobian is false. So, if compute_fluxes is true and use_jacobian is true, flux grid function is not initialized.</p>
</li>
</ul>
<hr>
<p>In ScalarInit</p>
<ul>
<li>
<p>In ID_SF_BS, bh mass assumed to be one ? There is parameter m_plus, but, it is not used appropriately.... for example, line 40th and 41th.</p>
</li>
<li>
<p>I
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2485/include-complex-and-real-scalar-evolution'>https://bitbucket.org/einsteintoolkit/tickets/issues/2485/include-complex-and-real-scalar-evolution</a></p>
</html>